From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A895AC74A5B for ; Wed, 29 Mar 2023 08:50:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E952D6B0072; Wed, 29 Mar 2023 04:50:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E45896B0074; Wed, 29 Mar 2023 04:50:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0D266B0075; Wed, 29 Mar 2023 04:50:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BCC996B0072 for ; Wed, 29 Mar 2023 04:50:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 93498120519 for ; Wed, 29 Mar 2023 08:50:38 +0000 (UTC) X-FDA: 80621314956.05.9142F76 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id 839C840005 for ; Wed, 29 Mar 2023 08:50:36 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sWSd8GK8; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf04.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680079836; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e5tA8e6Rq5IwjYRoES39AKzgJsaOL1PNlGaNEuxuSls=; b=Y90EU2v/7g/DGFe/947ymXgkNLrfNa3ZpGU1NDmmaO0jZ5RggzwTn0nb1i10/uvo8fHsyw FyqCj8jbbgk6mrGFy3ou3v1Z20r0nxQ4i+k1Rj6H2vlef4tLGFeuKRLS4bWLcYkaaDxpg4 6KsQvfB6QA3HjV/HYym5AnTFjC/9wqA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sWSd8GK8; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf04.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680079836; a=rsa-sha256; cv=none; b=yj283BBVkf4lPD/yqe+WUSmfDMwd5vWarA2A1rU0bEVI5pL8WTPBHS4Qv8Xz+kocQcCYZZ gzOZM7DgrMfqOY7W7e7XZ8KxWtXp3z9DljAigOvqhXTFXC7RBsiPRxxvdagGkf+9iw880C VblG1LI9QlvJpayN6dziX0dBpPPuGKc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=e5tA8e6Rq5IwjYRoES39AKzgJsaOL1PNlGaNEuxuSls=; b=sWSd8GK8NgS3mwvhKkk5UU60DL 6VYlzhrKeVpDukC3hI+hgNmvegOJXMWNu5TEn4Y1bJcdkeJ9/2Ut9HuA8o613+biAgpnBhJJIIf+Q lJOuoQtyvtNqE9lw/ScdNMnsNbMb0k0U9xjK2GoTaVapuWDpQ6phU6HTsZeRQYy+DNJcC9Wgnel9M F36iUDnN1NxYsmUUgVuLJCDxcRUb0FNRS8EJarc8scJCpectqbSfXYPFpxP82NuTsgPAZ8zJON/PL e11vkI/VLdfW6MjpK8dc0HQG0yjrrx1s7xoAzuvbB2F26R0tF6B7+YEgPHoghboChnIOrrndTXb4S VwPkVqYw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1phRVf-00HBUN-0H; Wed, 29 Mar 2023 08:50:23 +0000 Date: Wed, 29 Mar 2023 01:50:23 -0700 From: Luis Chamberlain To: Arnd Bergmann Cc: Andrew Morton , Minghao Chi , Vlastimil Babka , Arnd Bergmann , Miaohe Lin , Baolin Wang , Mel Gorman , "Matthew Wilcox (Oracle)" , Kefeng Wang , NARIBAYASHI Akira , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: compaction: remove incorrect #ifdef checks Message-ID: References: <20230329080248.2543492-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230329080248.2543492-1-arnd@kernel.org> X-Rspamd-Queue-Id: 839C840005 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 334s1obkp9gtfgsrmr739sfcoftr8yzi X-HE-Tag: 1680079836-209008 X-HE-Meta: U2FsdGVkX1/4kkz5xIWlMAj60aqpIEzdSsr80lZA2qfQu5mlHoJTk8IyQNqIy4ph02BrdEyqxriIxB50J16h1ykg/E3tBY31PD+mwjB/V4OjT7cBN9s6wUczvXFxu7aYwq6xc9MocU6xBPuBom9XR2oYF+H0uJ7iBRX3g1V2Nq8WF+HgIJyQ4WPn8uurDHoW5atspwWCoOHDEOKycOaL08NEHOTitJ9bopBqzgUoqA342MGFRnOXwEoRxnIOuadWEplAz5RdUWrEhGiKQPFhDv0SoBpKMyrpDOvAJdvShw5yFBKovsgfV99qdyYik4a3bwvPTlOk/BH2KN2+DcKuYGCynBpxJgIzKsoymne/ixltzkccMPH/GItQbyvCEbt85Yi0ROMkqT13ylBqCCShCkrRG+k87dVAHbGJfw2VZ0/ckJLX0fxLGnaMf9Bd4rj37Mt3JwrdSCuJu0IMPtA4o6Jg2pFezBtfxbZlyQPI5E4An4zfTmZAxYPRR5NvKxR4BAw08gs9Rf7648fBUPUO8FiTr2on33oo2V7Q7oiH6CV1qr0kSZI+JJNac9Q3nhCY5z86gxWTvseY9gB8n/PiuJeG3nBu1qloPec5HGdy+Ho7xPmUn/9kKM/RmgcJxli3f8k6V1thhAmbvCwEawsp9jRSeKPbhEcsew5Y4lGz94NjNK3WgN8dxIEoQ3oIHaUytDhMSgDBWtInhEHvIVOyJVJ4nlUDHElTm6ojHcDuDGa9DOqYdUOlMsc+hg4T3fv1BPwIgUcX9OWnzx57mFnOBgIEFAewIRjwGymt7QYd2hsnEjXJ/dEZrCtfFmOeAyUNKdQacMXK4U2k7QBOLMR6Ef4cS1abCRW6dUCOWSxFdYnHJSUzltbqyDa334N6oKmBBrQ35o1SEVRVnkkAo/G2jZBNmpaTjwlaJyMacfNCDoJzLvTTq/1cbLnE4CjgdUlLsZZtw56d8eQxC/+pfdJ 2pYtC0ph 3JEEIcfOg0aajzhbSNraN3P7FHOVmioKcV8Dd/F1vvi/BomD8vRjWGOJu22DxChKJhSnoTIeQJHcSwWxeInTHRjYHvHoQo703WTg4W0pLzjqiAjxzGDB6nx7EMLK26jolXcUrJxYvzSGYGaYgKFQL/yInglrcrx42KC/l6PGaNaq5ouw7ltFrL185T+dSErLefjgH/odZ56tm6IG5gUhMjQEhXvYDlamLygbQAY3NmEefU1TKZgRd5zcKbZvRcywGgIrjX/zgcl9Hdx2KiSXB4qy8EpZhQU/0q4uHFXk6P6igmWsa4Vx3qI2h/IwGLDOImucmH5/3U+nlu+U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 29, 2023 at 10:02:41AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Without CONFIG_SYSCTL, the compiler warns about a few unused functions: > > mm/compaction.c:3076:12: error: 'proc_dointvec_minmax_warn_RT_change' defined but not used [-Werror=unused-function] > mm/compaction.c:2780:12: error: 'sysctl_compaction_handler' defined but not used [-Werror=unused-function] > mm/compaction.c:2750:12: error: 'compaction_proactiveness_sysctl_handler' defined but not used [-Werror=unused-function] > > The #ifdef is actually not necessary here, as the alternative > register_sysctl_init() stub function does not use its argument, which > lets the compiler drop the rest implicitly, while avoiding the warning. > > Fixes: c521126610c3 ("mm: compaction: move compaction sysctl to its own file") > Signed-off-by: Arnd Bergmann Thanks! Queued up. Luis