From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6751CC76196 for ; Tue, 28 Mar 2023 17:55:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEE806B0074; Tue, 28 Mar 2023 13:55:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9EBB900002; Tue, 28 Mar 2023 13:55:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D662D6B0078; Tue, 28 Mar 2023 13:55:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C7F356B0074 for ; Tue, 28 Mar 2023 13:55:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9E33580B13 for ; Tue, 28 Mar 2023 17:55:58 +0000 (UTC) X-FDA: 80619060396.14.1FE79AC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 013ABA0003 for ; Tue, 28 Mar 2023 17:55:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=y0TFmUPk; spf=none (imf15.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680026157; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mF44mTcQDxi32SHw5oS+hBomZQPJLxNczN7gzosvezE=; b=sn4b1WhSDboYWmAufr3VM52qLE5QfwlgkWoVlmdtIFiNGkN7rqLH1rO+8PFqLDMu1h/+EV 0heeutC8AreTkL7PZVQyWWMyYX7RwNMWQHBHcUp4tMsSkZqnblbNc6Ql+2j7WA7/tVTDuS X2VOuv0BUedH/iVlrfy/tUnZF0W6PuY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=y0TFmUPk; spf=none (imf15.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680026157; a=rsa-sha256; cv=none; b=PbKSXLPCvVJw++fr5Kb5ohYvd7L/n3LdgmqS8Kc85XwF9FMmBoG1cpShG+g6DYT2kIHlnu 1zMHnn5ZVWmokwrPmZoADj3CnHZZZC4j+QP5oTUDg9iW0WFRhomqG2UDOV/oe90bC+6lRk LDUYKROMBdolj+KW5vz/WMjDGZrJsyI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mF44mTcQDxi32SHw5oS+hBomZQPJLxNczN7gzosvezE=; b=y0TFmUPknQKAfD9dwyLjsgdaED XgLLqy5ZHDwzF4g/tlxv6M/rpKW6NB0Bx2ITjzBzuybM65sgwYr13eKwHVZVqfaRBhW4g+0QlHksX RLfqpGVYMm3c/QiP+EwB5QFm41QTg2/ZaukbmG/ReovW0muWrP/1yEqzI3Ertj/O05CL7oDqIj3Gv Cjq+1cbyHwksimH75ezvlCkjFoCIG94wLIKsK7A4lzQf9DwkaxZGnHq3zr2xWgHt7hxox7pErzp1S ktUyn2DraEcxedanXjc8L6/36fJ9l4AiF+04u/Dsk4Zn7iYxWDa6egToAOkX5V3VBgyxQAHDz8bW6 enIB5zxw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1phDY0-00FNsr-1z; Tue, 28 Mar 2023 17:55:52 +0000 Date: Tue, 28 Mar 2023 10:55:52 -0700 From: Luis Chamberlain To: Matthew Wilcox , Vincenzo Palazzo , Lucas De Marchi Cc: Mike Rapoport , Michal Hocko , linux-mm@kvack.org, Andrew Morton , Dave Hansen , Peter Zijlstra , Rick Edgecombe , Song Liu , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, x86@kernel.org, linux-modules@vger.kernel.org, Pankaj Raghav , Daniel Gomez , "kbus >> Keith Busch" , Davidlohr Bueso , Adam Manzanares , Kees Cook Subject: Re: [RFC PATCH 1/5] mm: intorduce __GFP_UNMAPPED and unmapped_alloc() Message-ID: References: <20230308094106.227365-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 013ABA0003 X-Stat-Signature: cj8ej3kp9b343xx9qdigck98ydiqag51 X-Rspam-User: X-HE-Tag: 1680026156-852247 X-HE-Meta: U2FsdGVkX19LMPj9hrt56gsoacZQtpU+1cfWaP1nQmZLPE0hWm4tvpJ4lunKGTP79bBb7A2UpSI/V1OwcryIKQdvButm0Mcml9o7Y7AZ8s7Qx0JzAEB0/6DBUh+RIfk6RIFYsdhYBtekmgf70Q4yf8KVONjiChu8rqe0PtGDoJP7FB3YFdQLgxJqLd9aPTKrIQtObg7tuxj96VsSUXW/PQxEo5+e4N/gmLoTBok/lRVQ5CGcgkn5neCSY4rvQ6yjv383/ewmj/maecQ0hhlWwkIec9sC7z3NqqrCWQE1z38qni/Olr3apYbWpwvOJcQF8Kk6esOaJsHN6Ne8ZUzdx5Er3E4SvmYqzXAWFjv+UizA0MN141Z6Uiiks+ytIWmn5VypHKXDJ2M1EQFZo6xYgPLW5LzkUUA4KWN4NdTHlCZ9HsRYIR58+bxmHkCN9C19jESykIAmE29XUZjcwvIgyI239qZ3iH04tWDUdP8XUa4N6UenZL8uAmAcaoG6qy/2AXmTPfp8cSp/I9MhU0c5fXPrFPMLMrRHbDAKWbQCAk2wXeckQIE0AgY9ycx5DnWVjzttSLIAaXYMQShqbWDpiTU/FDhIagjT9omBgJPMYHfDHfSVaCQBzLVCHRk1TgbT/LrUNPBcXVCsEZ73d1xaU1UNP+BSugo+kE9hievjcHgPL6GvrdVnk87JzGLFKHV+H/E5ZY1gNfQYbDNZfGRAb8aeHhbJs8EbwBqpu32x1ATZ+dV7yRLSl3hOOSOblK9LuonsBdZEiNgUNW+LZuVx23DRecTFmumx0fx2ksKGFf9nmf33pCkOXHS1Gln4a0jmeZndhDlXY2FDsR60f612CxDM6E5TyTP+xLqPseyZKBsOzp9RTKVfxt2PRbB5LV5tjZJYxCt91X+ySkUcw855mLU8OEYJjWekgMXsxNL1ayG8vrmAXqJWYS6D9aiKF9JLEcYC2qmWUSu8YycGHFN e5QuQV9r RKBEoiXLvd9m8ZYVAKBu5YCm8/PMNcC/zUCv6IJ9NrpjlSomTuAg3ZePe7mRFpD76uy2l2M32qKBrrR6CNcJGsvVE7ZqpJQFBtyz10pidCkrFQiVecxczjAnfnX0LWFzB+XXBVVykg3yNTruyDUNRiAaTUPQblXHz5rDtKGbOsGZF96on82nrn4GOyn1rrSOk3Sk2qbBj1K69/otE9Cwf/K5Zj74v2AoCKY0ya6G5HzwFSlDcqleh0it8LULDSBDf6q5KbhoY+X0Zc9l6lo5M63qfrz8JgH+AoZsssVN101lnykG9K9GiPD7zBZyyk47o1SIRXHcXRfJEySNHVRUg2MXIcypE/bS7XQeZH4vpO52OuMEyaaAPJf2SpWaohZlLspA0EZzF7ctQ6GSIXGdTPsYiwDuv7fo65AeW9fwQraCP7Uu/zfNuj0sXJ4z2kebTxwnh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 10:52:08AM -0700, Luis Chamberlain wrote: > On Tue, Mar 28, 2023 at 06:37:13PM +0100, Matthew Wilcox wrote: > > On Tue, Mar 28, 2023 at 10:18:50AM -0700, Luis Chamberlain wrote: > > > differences with eBPF programs is that modules *can* be rather large > > > in size. What is the average size of modules? Well let's take a look: > > > > > > mcgrof@bigtwin /mirror/code/mcgrof/linux-next (git::master)$ find ./ > > > -name \*.ko| wc -l > > > 9173 > > > > ummm ... wc -c, surely? > > That's the number of allmodconfig modules found. > > mcgrof@fulton ~/linux (git::sysctl-next)$ find ./ -name \*.ko| head -2 > ./arch/x86/crypto/twofish-x86_64.ko > ./arch/x86/crypto/serpent-avx2.ko > mcgrof@fulton ~/linux (git::sysctl-next)$ find ./ -name \*.ko| head -2 | > wc -l > 2 > mcgrof@fulton ~/linux (git::sysctl-next)$ find ./ -name \*.ko| head -2 | > wc -c > 70 > > wc -c would give a lot more. wc -l gives me the module count. > > > > mcgrof@bigtwin /mirror/code/mcgrof/linux-next (git::master)$ find ./ > > > -name \*.ko| xargs stat -c "%s - %n" | sort -n -k 1 -r | tail > > > -$((9173-5)) | awk 'BEGIN {sum=0} {sum+=$1} END {print sum/NR/1024}' > > > 160.54 > > > > ... which invalidates all of these. > > Not sure ? But regardless the *.text* lookup is what we care for though > which was later. Which gets me thinking it'd be super nice if kmod tools supported querying this for us, then no fat finger could mess up the math: For all modules available: * Average module size * Average .text module size For only modules loaded: * Average module size * Average .text module size Luis