From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A89C3C761AF for ; Tue, 28 Mar 2023 17:46:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 028716B0074; Tue, 28 Mar 2023 13:46:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1AA46B0075; Tue, 28 Mar 2023 13:46:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3096900002; Tue, 28 Mar 2023 13:46:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D44BD6B0074 for ; Tue, 28 Mar 2023 13:46:50 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B2320160B12 for ; Tue, 28 Mar 2023 17:46:50 +0000 (UTC) X-FDA: 80619037380.21.FB55ABC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id 011B9140020 for ; Tue, 28 Mar 2023 17:46:48 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=H4RJjAuN; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf23.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680025609; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y9+w3S5J3Vw2FuGbI9EqpsTol39UocOltTUjYy56Ws4=; b=JvRB4PcNv0UG5XRbNuy3h22YirwTWwLopGIDrCSOoe2P8MDGg7dYn3edxIoClY3z3GYgCn U+QALZVAlbiYKLqdvY5y903877i13MTv9OFyPypYuFdLmKzEn8VBV7OTljxIhxEHkMAEls DlnAIZu01LL9SJulWoMq1XK1f8dkS8U= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=H4RJjAuN; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf23.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680025609; a=rsa-sha256; cv=none; b=SKaTOhsnwz+uzSyUX8w/HnNZFN34x4m+na7IPCjYvDeynpzqULv2zsNJROu9/lTiyFEJ+7 2YJRDmOblibb5aZILQCV4RfnHX4jQjpnKJK/smbvStKar+OooS104sCX9NgdOyroUnjD7X vyRqiv6ct3dFUCWmYUjONDpQJ9niGss= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Y9+w3S5J3Vw2FuGbI9EqpsTol39UocOltTUjYy56Ws4=; b=H4RJjAuNFBRkz6dH6ykqU0ih3r NQsUFwJozFJ1SE0+eYgfPSdIWrRdNZSw1w0jQ2D6YSBSQ5lB6BibYdrSonVIO6sBOU7vAZhZ2+JxZ Yqv2GfSj3MsuHi3kIyJOq1jOQeG1codlZUTC4wTbkof/pbBDsyKy5bdpS+Rbsppv/KlnlsblBCETg d3by0muu5JlA5BgXtSKEMJDu7XJgmkrFcCxr3Y2DI9A9IlYjrNNuO9RDLx+V9Tz6DA0mlRJiTx/HT D/yx0NZlaPGnISqiFVnl2qQunqS4WXNHEbGDzq6UUtZlMrHkSIAFbW5fjemrbafOppGey6U1fPLFZ Mf/VpBBA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1phDP6-00FMVR-1L; Tue, 28 Mar 2023 17:46:40 +0000 Date: Tue, 28 Mar 2023 10:46:40 -0700 From: Luis Chamberlain To: Vlastimil Babka Cc: ye.xingchen@zte.com.cn, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, chi.minghao@zte.com.cn, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH V8 1/2] mm: compaction: move compaction sysctl to its own file Message-ID: References: <202303281446280457758@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 011B9140020 X-Stat-Signature: jg1hsfjqkkijtuwkxhb361qq7iushtn9 X-HE-Tag: 1680025608-458213 X-HE-Meta: U2FsdGVkX18+uxzwjys1ess6h+9RztuyOJhJ01jOYgbU5lP09qYe1aMO2tlGykbWQANklLvervZNXcK8au7WYv+hbBlkHzMPqte1ChJqoEJU5uW1v+dSR+61CiSiwpZo5hBSsZEmg2WdgPJdTJcAx5v3lwVXadIy5QrdTGwoDKdzWImmuo6ie+kcj4PZBSbmj01tel0vAz3mp+ZjIEgZ0va/kprOQkUiZKn91Tz7JSUy8tuosBReGhKVbOC7khIjETxQdJdGxvhb1inMxAL+KzoyjDJoyic5Pg8ifp5BeJQt22D3wta1fAM5aCdu8Wlv6/M+JYSkYxK3th0mNo+xgXpyvZXNYeJ8KN3nj11knsnnF1cxd+++d30Kb6M822YFaNvjnPGAWiSRTOutQ9Mfu6xatOg+1CO/NyU6QT3yMEfdzzo0GfFxGb37ta0nLDJf3npS7esJ6MnVLXX3sU0SIYZkx0zKjAddS9lNaohsUGtGoIiX8q/6Y77l/JYac1AKcqThq7eBvntJAePruFcqYqFME/nGkDCWi5aE25teE8426Od28fHMhuASAvlVNFx2DkR169WOfFfjJHc5XtNqLuUa3uOq6xQ3gd22tyPZa7C1P+hA+s5GqhySq7j0cm9xAPQDRlDXVaidFDdxRwvmAKpYhJD7ZZQD0eK6AnWuXAzB+ZGDpOcMSOxtGCkFKp8gP07JtZLYi+q8eyC1YV1oRLx9GDgj+Pg5ObXjuWx+8DJ794v1GgkRMgxWKPtsENMiSmN+L5JX/SKGfE8H7VpSHr6PUVL31GqlQ/WEaSfMDSz1r92Ey8l4P+ewJimIYPueYvRMT6dbCpyVPLcV4nwSfvvph+p4DCioi0Hen6WaxRNvjzqohmOcv1OXTmPQ3NwjjfIoNwR9PXh3/5Snb0XaXulaBZn8Nk4ZGiAtpTkDEw+OZVQYjaCOoiWUFv9MEaK5ik2q2+Zuwho10pB0oW0 hg8lGbIp hG2eBilVa6yr0bLht9Jv7XvJ3RhXuJKc8L9q+RMTnswiDpb6t8n6xQxNiB6i4hJhuoKjDrh9oGusmVif7EWQ7fTp6DreP6r2/QNPq/cFC0EdpGPhoSCDn60QVVS1+2uNx/sjZCw8LmI/ckRRChLPFyMg/RkRxFQid2EgfM2owM/AYwds6MjKu+C7pIg6euqcf+S0ZBn/njM3Mv/YdlcsgBEk/PP8umbpXX2fGmsANaqvSzZ/59GvPfymw2inYCleUj/6K8XqQ7tTu/sN92wAqIQyxGe4r7wBZdAENsp1Cyt5JdNex8KBBJQzzjYJ3mbEqVPh0ooahB4oTm0B9kKwWG4JMBmCUCb3XabRyZQP7YfxlNtPWedrwNYvI3urfmdMwGxfaAIo2BNLNIvk0xWn0rJoTorqq7qF45NYaZhFEEu+0pPy3twtA4e1UVBge5Lxlj5YY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 10:56:52AM +0200, Vlastimil Babka wrote: > On 3/28/23 08:46, ye.xingchen@zte.com.cn wrote: > > From: Minghao Chi > > > > This moves all compaction sysctls to its own file. > > > > Move sysctl to where the functionality truly belongs to improve > > readability, reduce merge conflicts, and facilitate maintenance. > > > > I use x86_defconfig and linux-next-20230327 branch > > $ make defconfig;make all -jn > > CONFIG_COMPACTION=y > > > > add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94) > > Function old new delta > > vm_compaction - 320 +320 > > kcompactd_init 180 210 +30 > > vm_table 2112 1856 -256 > > Total: Before=21119987, After=21120081, chg +0.00% > > > > Despite the addition of 94 bytes the patch still seems a worthwile > > cleanup. > > > > Link: https://lore.kernel.org/lkml/067f7347-ba10-5405-920c-0f5f985c84f4@suse.cz/ > > Signed-off-by: Minghao Chi > > Acked-by: Vlastimil Babka Thanks, queued up on sysctl-next. Luis