From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0889C6FD18 for ; Tue, 28 Mar 2023 17:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAA9D6B0071; Tue, 28 Mar 2023 13:42:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5A856B0072; Tue, 28 Mar 2023 13:42:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFBA56B0074; Tue, 28 Mar 2023 13:42:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BDE3A6B0071 for ; Tue, 28 Mar 2023 13:42:39 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9497CC09E4 for ; Tue, 28 Mar 2023 17:42:39 +0000 (UTC) X-FDA: 80619026838.12.70702E4 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf17.hostedemail.com (Postfix) with ESMTP id A84064000F for ; Tue, 28 Mar 2023 17:42:36 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=XkSSaVRh; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680025356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OdjXZM63BnqFRkAjlfnPpinEdD7TpZ20uen1Kc76yzY=; b=B7MfT5nE2OtnBgzmw5gEKZVTp10tazMRoi5FzxQIQ0DvPCawjrUfDQjGJKcGN23k/s2Sbq CnK24cWZ7OJeVyTYIPyKzHgthNaoBm57l3A9D8Shwl2R/12UKbweKqUaSabY1gqisY+i0U vNxcIZac1cI8HQizKX8nZGOF5D/aRis= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=XkSSaVRh; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680025356; a=rsa-sha256; cv=none; b=1b46IyibQGyJQCn9a7QAIPWfCmxEYfO2z/iuQwOWBPnaAgkSkk2idb5r38v38XmBxe+4or z64E8QYIM1O/qp4HO4Oah64WFEFVii1ELOz5T3rRNEgnsVtZIdWVmGYf31Q1uZSyMk9Rxr OoCKD8eUmpKDRNC9Lim5ae2avLVLC6I= Received: by mail-ed1-f44.google.com with SMTP id y4so53026886edo.2 for ; Tue, 28 Mar 2023 10:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1680025355; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OdjXZM63BnqFRkAjlfnPpinEdD7TpZ20uen1Kc76yzY=; b=XkSSaVRhEu8Jkiy0akM6wNvHj81vWyDUX4zDbELthR0W7IKpQL5VFjzfb4O7oRJJzx /+V55i/y66oIT17EyRgliReH0SzCaNchzN37b7i9Qy0JtGZpxpt7TDCkTv3Y8TJq8/cS XOcgYZMVWjFB/pGadqgIUEGENaTNPM9ivJBqqcUY22+PWsjwhB34WKDjosN59L+2zHzd 9UCNcEUVm8EhuOlILx44UWRGvgqsn/bty2TQm7+eBdaRlAsjqc6dHNsL4cpUS9UT+j5B 6OQYzm4H9GReeF59X9O43IdgySJFfL9l+9J/dVpP2YlhzNOLrcjJfVgUfcaZE7yZ/JXP mKvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680025355; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OdjXZM63BnqFRkAjlfnPpinEdD7TpZ20uen1Kc76yzY=; b=1tSqimlbUiMxUyFvskuKdW6gW6NAeYGRdalcTPWQ2GhkwZHBp9tSNCq/+G074SrrtT ojBu7QL9cJxyaSqixJfPzU/1mQ4TLhCP6OGWHaA/vpfJnlIPUKXZpqnYMYR5tDhZR5x0 6icsiyAO5r2tv1td4PHmRAHzpsl4IFQDlVWqNqbBsN+GFf4qxHOnhwfmON8o4kRr5VTy dQaYD2j11t+guoV+n+Lly70ZeZ+1cZq0KXpku/qfgwTU4QZA0GaTQZgD2wxAGlKmI+SJ 4k0rIT5OAGpOluuQTFcfTJ0orFQ916+RPFQJwENGsZI8UMu6nlErniqm5N/9vV5sbo+5 VtoA== X-Gm-Message-State: AAQBX9c9rxzC7QuJr5hA0sjosN4GewN8d0MGCCD5e9EZ5Ic4Lhffhd+7 RSvbCeZVPZ27jKMzURHst1ezcA== X-Google-Smtp-Source: AKy350amP79GzP8XYvyQlTbyF7h5Y94HZ31RR7yRjEski8rNi0DQR5LhSQYAPBPO0k/xCK9hXfVXbA== X-Received: by 2002:aa7:d658:0:b0:4bc:f925:5dbe with SMTP id v24-20020aa7d658000000b004bcf9255dbemr16254610edr.42.1680025355066; Tue, 28 Mar 2023 10:42:35 -0700 (PDT) Received: from localhost ([2a02:8070:6387:ab20:5139:4abd:1194:8f0e]) by smtp.gmail.com with ESMTPSA id c5-20020a170906924500b0092be625d981sm15559189ejx.91.2023.03.28.10.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 10:42:34 -0700 (PDT) Date: Tue, 28 Mar 2023 13:42:33 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v1 1/9] cgroup: rename cgroup_rstat_flush_"irqsafe" to "atomic" Message-ID: References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328061638.203420-2-yosryahmed@google.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A84064000F X-Stat-Signature: p8fdcj5stn99asw9py35xhibqaqtuyau X-HE-Tag: 1680025356-193308 X-HE-Meta: U2FsdGVkX19vZmzsShJBO0VwaGA72m4iSKbttuGPIjf522p0GELZajfCCl5eEjIDBlm3JC9XbJ4jBwaX/us05FGEpFFfFiy8EuC/cvE8zZLlI6AC6kx7lgtTO8BFUPtpfcHAeyvnCfPccpILMBGKDDi1nvcZuMQe6UFHWNx4ryH529t1JssWoQeG7OLzrlXtOwkXWc+YmSi7xH8s4MB9IDW/1fl1A6eg/xzm0ck0G1fVRLlrHFmKs8Lh95yPeowUwjrC3S40rZgBXqeW8gBEgdbbMXRTBr0rgpalYhcg01PkfptCGtPib/RkFaGzPUEwa5C7Jbl2gQZB0xZYD/qVrejF+YYNFR2manarEHtDMYdIziiD1ZhwAZbdOVjsMLhNOnvtZ91Iv8Nrr9XabGHVB1RcZJO1oFjGN+495mdD8KgFW3ZCuUvBw/LAFzHBGR/0aOIqqBaBIonzWSX8cuZzX/z2coa8EUY2420eSWVj6CSHN61cLzgof1953s+KxWt65uT/rt5ZNgA8uiw75fP7KgTAuGMzJI8M+E3/Bao0ZC28KDAaik6u8GrobFh6e55pGsuPPyJGUr5iPITmFyr6tRGBNDNU4E/r5loFIEwyU7HL3JJKQvr7154ME2nsvVDwSH+0CpOYUf0gB1b1AAZA0EQ7zfVK2JqbbPfWU0LAYC9SteiWXZTgehGnBfT0T9dTCxkSLGLgiUnGGyx9Lmp1Kiw+dkxY5+ok6FORBZ1MoLNLxP6CJtIoiEMrK1iqZVqBqI6imMRPAPrlcHIhXFosP/r8/gIJ43un4N/P0xUTVwZTe4fg+mlN3CwQjCIC/ksGeN7NKXmhikb16qhAgiUtLB2B2eSAASgC4aCqaRXjt3HhoapsNLzq7RuOmcBBuz9qB2lk4rGlHmMZLK2ThO+l8LPWEsymxusFnxLcMVnxYW7IxtVM1KpBHWbSA3eIc1M2Ucu2l7fq+9x1Ucgn51Y op9l8INC YixTep6aRW5zrK9/jsEoOIhfoFeFLb0l/FsQZJg0K59mEEdIqihaLQgFJjinzJ5UE2qV2w1K0cV58YgnjhQwitXgNm2fnWJ1GAsoPd/3CTjQZ0+NziBk9O8Pc0OybQ+4AD93v1BOY9pWqGwNcIBt9X7MAEEkt88tjWJHMjQD1x1g86ilBzzUr7GNpTwhbiaR+Hpf2H6nqpzIPiHBW3oH0jckT9LfsXnM7Q9sw8EfIqecI3tBli5ox9ocCtqGwZhykfFfFoDhZolsa3kAwfDfh0kCa+byC9B7QwBogO8oRHUsz7pw4jdES52fz0F1nZkZflRyaI8CMCZJT2w3ufTXC7YBZK69dL2B/bJ2rwDTWB1atVnallXK1RjUpoTJ3Ytf4pZ35qIHqNo4OcP0B7ttXZEo9kHIwAwHuO48KD11QfQY04ZnLOlMVrXjD6Gzp8wAUpSwmTFgSPvtPw+AswoslycfBvyd79WwwsnZGKsYDbBVwZG9UdDjrTMN0I3XLT9L1WnbAMKMckZfLq6CpxgBaXUu8F65o7NRP4tRfKNAumBll7wAkoP+xSFg9uQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 06:16:30AM +0000, Yosry Ahmed wrote: > cgroup_rstat_flush_irqsafe() can be a confusing name. It may read as > "irqs are disabled throughout", which is what the current implementation > does (currently under discussion [1]), but is not the intention. The > intention is that this function is safe to call from atomic contexts. > Name it as such. > > Suggested-by: Johannes Weiner > Signed-off-by: Yosry Ahmed Acked-by: Johannes Weiner