From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63DF7C76196 for ; Tue, 28 Mar 2023 15:19:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7B8F6B0071; Tue, 28 Mar 2023 11:19:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B292D6B0072; Tue, 28 Mar 2023 11:19:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A18726B0074; Tue, 28 Mar 2023 11:19:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 917E56B0071 for ; Tue, 28 Mar 2023 11:19:30 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3C775140AA4 for ; Tue, 28 Mar 2023 15:19:30 +0000 (UTC) X-FDA: 80618666100.16.F05E0A0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id D2796C002A for ; Tue, 28 Mar 2023 15:19:26 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pr1joZer; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680016767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wX0gmGH9IveBATxHqfl2f3+O0L57UTWE20X3bYSnO1g=; b=HXrU51eRPtgSivTMPzNQt5QFrYZei8zMXqexht9VZJsbAt9HCYugbpZumTVsFB5slDLGuy TKVqQ3r0LD4RGQMoOh4Fo5GPkjAL3pWNVHwTjVk1+u0vgsrPAgR/bm4PZiItaQN8k4nKuj mzFbKg5pCpbQRZOBhLZTXtD7mt8vkzY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pr1joZer; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680016767; a=rsa-sha256; cv=none; b=4d8meiRf2OyWmJ05RoWIsgmXdHSYigzX7ip3XWOubvyC2mhGHZfFl24dzUMq/wV0uFGYiF A8os/pNiS4oBRgo1bGc/e8MPNtVzMpaApRCearF8RFOQyBGajgh/83HT1dyPBgTl6CoBFe zo7X+XjchrwaiQGXLBWscKpKP1gpq14= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wX0gmGH9IveBATxHqfl2f3+O0L57UTWE20X3bYSnO1g=; b=pr1joZerHeKsBlyHogQ7a2PLlI OnKh0jl/7d0I5iiAMB3X7PawFs8SxWFO5NOBIiE/eGbmzg3mKFkP+FwRa5Ny5sshyl1sTJhGnrPxM i0MpOhosQtQBiby8hQFQO7A547F7BZHII2Gq3lLxvo2wHCUyCNlUkBH2lWpFKhivqkwK73X1FvCJ1 xLdu2PshCd8JBCdj8YknFzz0zElmgXh2/EyRWj8nrbt2FtuH5VKto89AE5WltWejQQIgwhOsB109K 5E0AzOvrQIsWkVletsJB/nREkTB9gE00L06B+oQy1+yUivc+7vioonZ2bMQDnHKEDOstKf2D+vqu9 lfiylSRA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1phB6P-008XAW-Sn; Tue, 28 Mar 2023 15:19:13 +0000 Date: Tue, 28 Mar 2023 16:19:13 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: martin@omnibond.com, axboe@kernel.dk, minchan@kernel.org, akpm@linux-foundation.org, hubcap@omnibond.com, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, brauner@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, devel@lists.orangefs.org Subject: Re: [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler Message-ID: References: <20230328112716.50120-1-p.raghav@samsung.com> <20230328112716.50120-2-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328112716.50120-2-p.raghav@samsung.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D2796C002A X-Rspam-User: X-Stat-Signature: 74w67yeiconx4fp4ejgynasude9tdffr X-HE-Tag: 1680016766-52622 X-HE-Meta: U2FsdGVkX18eq7fuIWuwXOZkLmZNddSEcgHF5PCy3gSM8JzMgZcMp2CPQtK0T4rLzjrvYEI4nmBDoh9tRjgORNaOLsL8rh4AHk7HdhLtM07vRh1ZRhppT/NDwS1fleKelOC2klPgktos7uDMfcujBcr3pFbtbjuD5TC1AQ/x1fqiOfq4ZltChGDXad/WVo4D+nW3LmOSu44K2Tk1WmJS8OZGi6XRVxpRBaLe7M5FvzWkqITexhl32idsswtJ2U+2s027z2pmhmGpRNhBQdJBxukO2Xa8nr3Vdo8vVQTQX0wf93O5X3dms8LERKaXFRjLDzzcCGjQXXVs5VjkBCgW3M2txoaaB/GKFIomonoerc/BULHBGM9xDPHZAEx1HLYT0yb0fjx88dNAR0JR07UArZ2EXTSt/vzxOtYbx+mkZlnp64YS63EF+Rr/ZkZnUSbbRJ7Z/hKp9Z0pU/Y0utqsTdfb8FKXIIqgWn9K4ArnVZ//cu7e+IybFhKhubCVutN0Cj0WWzy2DJDTdYnDMJtYHRSZ0sJOJd4vPPm59aVEy+7xbuDvTzy4w2WCOsCEgSz768TZ0sYQt+d7QArjk+dTgvJgne0LYhX0GN5tFIbXDFE9q+JLnomSzhFCfVq4aHNT7D+jLBfs5mekoFLYfD0b1uHkPTO7O9dgTW2i8ROZZyQvEpfT8KyuAXGrAtKB0701v1Se6F3YSYqatu0xq+8gsIsX9kzdI8pG8Jjfsx1L0T5Ip4r+MEg6KvjBo8Sgm2iUFDulqIT6t+iTCT5ZW7vi605B/J/z1K1Fq6cCFdom6NRL4+g32iM2w+RCmUGnFRTyik0uDlhTJIajro78LhqXp0fiA6glg3MKMhz6iBV6tTQYWbBfFdR/lgxTKFIXbusqX4qBheNpqCv1dBbFSWAqkExEE1XIjzdCkm1aN9ofdUkdFJ4SUApRWbXZfDMJCzOARORQUGoV6QCIRk2Z00m sYd8E17V Uf+D30oO6XRsR2el11rInGdqtJoR1dqTAuMnFoysOdD11Gl2JvA1Q6OuvSmqlhdI0ByD5/tT9Svwj+froBm0/6R+0g6YpodOFgx5MYj2UjqoGve59c/b2OZTAglWAPdrIYrGEzj5lwzSeb8lJYAgs+uoTmHhN92ms//hJMzFssAyK3VI74LW+SfqBca+tSyvwe0a58wMCqfZ7lFA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 01:27:12PM +0200, Pankaj Raghav wrote: > -static void zram_page_end_io(struct bio *bio) > +static void zram_read_end_io(struct bio *bio) > { > - struct page *page = bio_first_page_all(bio); > - > - page_endio(page, op_is_write(bio_op(bio)), > - blk_status_to_errno(bio->bi_status)); > bio_put(bio); > } > > @@ -635,7 +631,7 @@ static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec, > } > > if (!parent) > - bio->bi_end_io = zram_page_end_io; > + bio->bi_end_io = zram_read_end_io; Can we just do: if (!parent) bio->bi_end_io = bio_put; drivers/nvme/target/passthru.c does this, so it wouldn't be the first.