From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7500BC76196 for ; Tue, 28 Mar 2023 18:49:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F15B96B0071; Tue, 28 Mar 2023 14:49:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC5346B0072; Tue, 28 Mar 2023 14:49:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8D8E6B0074; Tue, 28 Mar 2023 14:49:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C7C006B0071 for ; Tue, 28 Mar 2023 14:49:12 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9BA22C0656 for ; Tue, 28 Mar 2023 18:49:12 +0000 (UTC) X-FDA: 80619194544.08.1F73836 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf13.hostedemail.com (Postfix) with ESMTP id 7D01E2000B for ; Tue, 28 Mar 2023 18:49:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=A+bhfvmq; spf=pass (imf13.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680029350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MHTXhpf5WdLfr15cViMQdFbTg30x0rT0B0hTFtHLctQ=; b=KZRzF5uRBPn+2TpRow8TJh1CNFkHp877TlGvjnjuByxtRaBbhXJvgMS4LPP9nRIXjvTbn7 JFaptu5RPUI+Fu5duITz+A300QlHECECiE7K1Q0vwFjjOjDjStD+ztk5q7SzKekBfxPB8g AqF18pFknoa9ju3L17uT1gTGVxxCMAk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=A+bhfvmq; spf=pass (imf13.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680029350; a=rsa-sha256; cv=none; b=iC1hIJNr9DeMPau7hj1G8HLrUsSWfRHW3h9KePL/2vKk608vxhE2VNFAeCsA78/YUma8nY jESbBAH6rh3MMZIdt/3Bt+BEjzMeE39kzZQ3yzjxMCnzSnTYJoyMMewzpdWWamJ4/CYsWG TKeimr4OQQyYhCBs2nlb5g3FLa4HBMU= Received: by mail-ed1-f54.google.com with SMTP id cn12so53706980edb.4 for ; Tue, 28 Mar 2023 11:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1680029349; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MHTXhpf5WdLfr15cViMQdFbTg30x0rT0B0hTFtHLctQ=; b=A+bhfvmqTQqrdmC67+EygQyWGShN3KOSkBIckR39BPvNI8GfURZ1gozY1+nQ8g2e0m jwALDtiRqqvy7Dl6sjQAE+x4uZOoeCwvcdvpQMAFmHxFO9KQeg/CqH4tpOYfL1gF7py3 B+n9C6BMcKyPaz7fjY1oMPBMIPiwkgZJD2o1gtyoR0aVn76NuZ3ODcG/dQlbntZyKyq6 Xp7hkl1M8VCln1cL+sIq11V/s6ekKJ+lkdBoRdQoAwlxN14hlHAny4tZFSms6XFgMKTS V06rgFWRb/PQ2lg3EQ2mbe6dpaAnFDwTh6qWLNe59V5mvbJ8uoQwqImOyZBKI4BAmbGJ bMTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680029349; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MHTXhpf5WdLfr15cViMQdFbTg30x0rT0B0hTFtHLctQ=; b=XGAKvxMUtdRkndT6+zZHJF8wZHHIyTQ+hXwAQ0SzR0AdtQsKsIPAneAlCwnqFjCFij kAE8wEjHfKv0VpBcrtZ3lZKOpmclnNYVMiPFXDTPBEZEcozfXvTtEryNxprxhKugKvGf B0L908IAm28p5GxG+GdRW12XeWcPiQWfobIk2qHkCTSeuGf8eYNQpFwxdvj2X3HfLtic S16bAVRQ7viU+8iA4FRR19oBbVg5GdRD/RnA9kdYtuoH0OsVAtW4/gpv9wo0FWnykOne G4uqd9BLXG16IWh8iI25nVaQUcRBT3UJtBk3rfwUGMbvN2IenMQPBwvR8PNDI+8graIR NLNA== X-Gm-Message-State: AAQBX9f8jhVt20FEoAkOAsnUNcmJTm8R+V5Wg1sLH44hrjMc34OJm110 Zs9xwCrldMEo+l83P6jkk+9XaQ== X-Google-Smtp-Source: AKy350adtGZ/7F/zVdHFitatxgIwu2Smy8+dPv9uzMEAZupE75jqmmpPy4o+6UrU3JW/cx73A3BepQ== X-Received: by 2002:a17:906:9bdb:b0:93c:81b9:a2b1 with SMTP id de27-20020a1709069bdb00b0093c81b9a2b1mr17059102ejc.62.1680029348943; Tue, 28 Mar 2023 11:49:08 -0700 (PDT) Received: from localhost ([2a02:8070:6387:ab20:5139:4abd:1194:8f0e]) by smtp.gmail.com with ESMTPSA id a21-20020a170906191500b009339e2e36e4sm12932534eje.81.2023.03.28.11.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 11:49:08 -0700 (PDT) Date: Tue, 28 Mar 2023 14:49:07 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v1 8/9] vmscan: memcg: sleep when flushing stats during reclaim Message-ID: References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-9-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328061638.203420-9-yosryahmed@google.com> X-Rspamd-Queue-Id: 7D01E2000B X-Stat-Signature: n619n6zyw5rewagaz3foxph9sb7n5kya X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680029350-1922 X-HE-Meta: U2FsdGVkX1/eetGZIy5i3fTdf89dLFOyeoMKKcrghi75J1MKTBrpqguJq3a9zuPHweFd8hV8vQcH2UFbHkDUC5rGtjwqtxcoi+Hwz0/UvlMhIpRJGeV3IXN/BDp10vgwJ5teIOHdgvl9+05MnwP1cmq3nXq5KHOZjgPqpR1uOgwEwqELWBYxe0tZm8YaCL/5WwpBAuIwRsh9mbBNRWyuGC+QwF5SiTGiru8qQhdlcqNtklFigyWMB1JqO4GMWP//iAJN49hjk+2WB9gjflsygfubnVK07Yecpg0yTGKDHK4yQkt90oLg6c9d4rVpScijHRQOpG5CNuRocFZKU4XfGd68WawJUPYLkjhLBWkrE1PDcLqZzQxuy8KTXURokZxdf3ZwwXVnfzxyjsKrYsPdAxt3pX2eSB12UGE/ftTlFlrFkaxYU1a/w745hy3T/dMXog/R3I4CP1UZ2jj2KikDB4Wp/erEThMnFO41Ma30JgEBfNTrz22CCVtPxoX/H3kea39g1IhnngobuQ68RWg6+O71AbvClrkqKZ4nPYp9EDYFWhJk0N2NDqigvPtDjKFsz/Glhfmx3/pc4wJWdNbCqaVm8oALEXdi41u3KgBsShNnfbl0kqUVtmJW4KvMcS0R8cXVXTIlZWlznYJ7gxNALlWfXWIu9RMu6JmDpqUBTxbzu5gzZ+XJbkVlk31+vMbwFUctUX9yVWzZdlZfLuMVZ3PViYDCsp95nZqoCPZ6ijGm/IUv7mVyl7mvRDsmpPcl8gSDQl4oU+0G20a6KDRHktvgS9wdmApxM4EycfGcCIADlweubGxUWZFK76JZUG8GzalPm0wE0+T041F8ygdTuPw32rZVmHzNU8D1ccOQJp8BrA9i+fTuEfUvdUwRMF79JMJfMtrq15+eANumj03sKJ0LJtCp0lcSAudodHNXTlQQ8C8yR8vuCpIVNrQqrIwlHA/kPifABxv0wwRhG/t ABwkIv0b 7nwRTL/SbPem9gM5JhCw6BvnDPgQwv7cVRcFR8WNzeHttEoHPrX0X1AnjeXSBhg4Vbt/eO90BxLQ9/hqyyjM7VmjYEUZ4t+jPuH+Qm3meu8J6NAhPn8HuPz57145oQzlpKhBIUIPmXmj5QMcRiS8tSnpteUshsx79l91uBHXBMnW2mZbST527Jey2okRsaVYgHNgM6oyH4QT19LXIpE9DYU/UvSk5fLoPNZM3jzeDqGawfPbTu8KnZQY6j4p3e5g/cl8TSg329g8Ir3Ndb/ldEoBdPBZepf7Q+A5hMXfDm4S3t7MqyL5fAxvPeS7CFiykdq1Au/Mzm2ApVtY7M22TcCo27buQH6KY4t8BkoZ+TmTI9bBeGiIXxAUl9f3Ip9ENi2/I2I2YkdtDVYGWzhwfOZRNCbVV6KHYcyuWWYxtHndDcbAcqgRMO+i4PJh5hw9+skfyfrKSc/zDuwOOGhTtaJzKkdMHTfi0xUQfpX8nlkV50UFtKFpzsLZD4Qrj3pKKQJ7FDqJLrdaTzMU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 06:16:37AM +0000, Yosry Ahmed wrote: > Memory reclaim is a sleepable context. Allow sleeping when flushing > memcg stats to avoid unnecessarily performing a lot of work without > sleeping. This can slow down reclaim code if flushing stats is taking > too long, but there is already multiple cond_resched()'s in reclaim > code. > > Signed-off-by: Yosry Ahmed Forget what I said about this in the previous patch. :) Acked-by: Johannes Weiner