From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03446C76196 for ; Tue, 28 Mar 2023 18:50:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96EB76B0071; Tue, 28 Mar 2023 14:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91EDE6B0072; Tue, 28 Mar 2023 14:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 819476B0074; Tue, 28 Mar 2023 14:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 715026B0071 for ; Tue, 28 Mar 2023 14:50:26 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2EDC1AC025 for ; Tue, 28 Mar 2023 18:50:26 +0000 (UTC) X-FDA: 80619197652.08.E3B5E17 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf17.hostedemail.com (Postfix) with ESMTP id 3D4024001A for ; Tue, 28 Mar 2023 18:50:23 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=1QR4XjLL; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680029424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iZSVb7anGXXb5zwCrWYt7xgUpKRegbsbYrM5HxY90BU=; b=gBdpQSgqEs24ZiuGPtihKxbLpTQOn35zLsct80rkxLxb2EeOzwZqq2rtGdlS/OCQ94To1u GbOup8HaQpQkqAW1ZXzUP0B9DVEraIDuWG+H7FbbcyHjo9Wo6k2178Cz3+m/70u7AO3zE7 DY2g5F2cMYnjEA9Mtzkrmzl/yujS0n4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=1QR4XjLL; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680029424; a=rsa-sha256; cv=none; b=Dx7DRivHnOJpRrSjvY4BAUDwzgptd5NrzbcHWvXTCHHrVfBnjLOWSUy7gmzIgj+q+Vr+I2 9hrW+39FNDt2mLT8tOBFFZm64jcbLw6mBsUVDxwvm2STFIz8xjqaghYCOK3A2LC7pmoUvJ uysCzYAYpJYr+I29PBLDtwwV9UA6ntE= Received: by mail-ed1-f44.google.com with SMTP id b20so53742530edd.1 for ; Tue, 28 Mar 2023 11:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1680029423; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iZSVb7anGXXb5zwCrWYt7xgUpKRegbsbYrM5HxY90BU=; b=1QR4XjLLHLwM3Zmsgaw3zWAa78I3csLORy/e4VsQEXzXCtITlQVpm9CWPmkA6lEcIE l9vmq5KaRQWWkY58REzTUL7Y/u5ZvmJs1xya/EdeYG29I/YbohF5pbuCFsfRBDGYlfpa p4+KCJ7vkwLoJ30cObjArAxVzTagZEWVhWKhny11ej+ktXnisgks1Ea5bw54UXSAFUJP EZNJCkG8Zn+gP472ONOhnUlgPe0T6dvbJ34PIKUqkH13xcjMBzi1bU5dV74ngPS+pWrQ xUZz6BK/4anNdLHeDCltA0sRYmjomO3FLH8/SVTCua/HLKFTspSzgbYC2LJ0qTlNrcOp Y5Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680029423; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iZSVb7anGXXb5zwCrWYt7xgUpKRegbsbYrM5HxY90BU=; b=OvvhJY5N/nSjBRM/VO6A+CrxpIOYoht+v/Blk2K5tgNRAF5XigFZOY3lNNylb8bbpG /jUx7QP1aM37J8s4a++PFcO2MdFE1BPkn25QRbEHAvGm4efcgY1odhkf9j4U+3v6GVrX 3YXB2XDNoxvhAOENAIbAkszVxOil+jUm+Sev3N6LP1+UcBY8wiA9j4c/axBDvYbxlE4k 3ntsyZnE0bF1wajwawlVukAZA/c9wNlcpoO59JOti/KdVuZQ43X0kHlhZGLiapLUS/yg J2Gv41rCLyveg5kiy3s9zQL9JlGKBobDC+dFjtVgoW/pMDD9KcJEiYQDk6DmMG1iBvto BPMw== X-Gm-Message-State: AAQBX9cSDJFg1w3K8HumNKTTYxTfuW7Oyg85dKUc76/LZL9BnBlzst0u GvdADPcQVZV1RBAEuenhQY3brQ== X-Google-Smtp-Source: AKy350YqMLxfTGiBnlGBlam96cEvk7E1kr7TovxbqhmiDlCO1BHyJq1gMHGtAsqa2MLi2frxb39ujQ== X-Received: by 2002:a17:906:3590:b0:8b1:75a0:e5c6 with SMTP id o16-20020a170906359000b008b175a0e5c6mr17691817ejb.18.1680029423006; Tue, 28 Mar 2023 11:50:23 -0700 (PDT) Received: from localhost ([2a02:8070:6387:ab20:5139:4abd:1194:8f0e]) by smtp.gmail.com with ESMTPSA id h25-20020a1709063c1900b008e8e975e185sm15495056ejg.32.2023.03.28.11.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 11:50:22 -0700 (PDT) Date: Tue, 28 Mar 2023 14:50:21 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v1 9/9] memcg: do not modify rstat tree for zero updates Message-ID: References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-10-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328061638.203420-10-yosryahmed@google.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3D4024001A X-Stat-Signature: gawsu3y6wx7op69wftxkf6y3xqtxakrt X-HE-Tag: 1680029423-559103 X-HE-Meta: U2FsdGVkX193vcRpTGmpHibp67jA6gj9BF1ZZXf+GwwKqgzMa4QQ0B6qcvRe92G4JmWzgPQHkpeRQrS4fMAYvTbxyNV2nIX7M4c3eYf0xSYIIClUk4C4L8H0RAvnmgE5HHha2hwH76t1rcRyq4KvIcqGeTlJoFKhzJl97d2Q9N6VcZs5O3XdKRHzfh3XHLhzPXluR+b3Vk8gILAGl1z8uZVfSlsv6OyObaoCCZCYZZlVTnMuu0dJ59DFRhPmcPwKdi2aPXfLIORYYmEnOwpKSPJslb+2LwJ8flTdFlj791KduvZXRI7t7guMyX51S2MXr6pFXcmInF/To8aAg/fo58WGGBK3/Mjt8VrJCG6qvBqsMICNEUe8858x0YggMgE5e9ysE/Mgq0+MlwKWaC6hDt5P5sZuNFn9pMGPvRYTrAMNz1msfExeaaD1Cf2nnJyD4x13u2eXAU/ljKcXuv98H/0XCipgx9itxFEg0COifGjWsieN+ttahHSaBguym5GIqyT0IWPBlbLzkItv65b8KmIvjoOQSPDbYO7oB/fdX1G1qJZMwdIpo9/xYgQ6Nh4xZ0Q5pdZ7gxWJb99ouwZH8Yake29rciz8dj4fefUGhRm4N4NtJN0arm6Gzy8DH8GSeu/BtX4B/LChrpnznXVr7p90Rp3SYRzObgItAS+bqtc0RQEDpJw/Z84sVbhIOJKhp5IazMB+GcwRMgeWczVBqNs9U2tnjGeVuEB6osi5otZcurOV7MA0s1Wsi9EsDnbkgn7UPTHk0Ebq7Vu2XEr/S9vHi+U4RdYmLIzM1Fu4ksO+z+pswwxuTzCs0GIJnkyW/AsemFCZzEJX6UG6y0mOFWYkAoJI/TG4M7kXKLOUi0rI6D5Tjt7idxAEXUXthY6qz0x9R3ZZglDoKyLvU4eDFMJhyMfzW4X7vVBpIJjfC6MAEhMihW8iSS5zjIeLOrDsKudPKJ+vjMm0M6n3AOe 7hIBQIP8 g8tqhPQNAw3hue+XnQAjj65Z5emR/gxFnN8MapWAzps6IY9G9WHsbP4DCn1lU8dTWHPUsqBsir+aENx0m+YpHOb9FWVz70D3k450SZfg00/2jEOV2jZ65CJUm9j//0Z5V9ns90PiExM0YRQC4WP6Bxvk+ewDbM36D+rY+pwiOUfjVBVjtd8Q2o0/kctRr7L+jqIe9uupzVd3+oW6kUSAWzW3UPEOj/zdHASA4aCKgedGTyFEfNdbYecfFeqYVxm4pVALpTTrk69LBCb9hfs/Qd2WqAxCqnnYoyr48Jl+cZOs3KRt/4H5PkNzJgfww7lKY5/E5I1vPjNFWekRXAJXxlCHQaCKMWVORopwP/FW/uqxeaSU18ZkoLUeYYRpE4GePzSTlzTiCbMwAbzEsALcr9fADcuWqEqrniiuyVJGErVSMaMmliNSKR56NHqhnFmcUYmHXtvLTKAg2tqvkcaWU0EZ8Lpfv3cWy4NY8wZM1kAVEv1v6eZkJ1r3x31agwR3vL1x8OjAu/BN3Qnk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 06:16:38AM +0000, Yosry Ahmed wrote: > In some situations, we may end up calling memcg_rstat_updated() with a > value of 0, which means the stat was not actually updated. An example is > if we fail to reclaim any pages in shrink_folio_list(). > > Do not add the cgroup to the rstat updated tree in this case, to avoid > unnecessarily flushing it. > > Signed-off-by: Yosry Ahmed Acked-by: Johannes Weiner