From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8569C6FD18 for ; Tue, 28 Mar 2023 18:43:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 221486B0071; Tue, 28 Mar 2023 14:43:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AB606B0072; Tue, 28 Mar 2023 14:43:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 023626B0074; Tue, 28 Mar 2023 14:43:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E288F6B0071 for ; Tue, 28 Mar 2023 14:43:26 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BB6411C565D for ; Tue, 28 Mar 2023 18:43:26 +0000 (UTC) X-FDA: 80619180012.07.00B0D36 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf23.hostedemail.com (Postfix) with ESMTP id 70CD4140007 for ; Tue, 28 Mar 2023 18:43:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=gsJgxRHD; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.48 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680029005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rj2RQnjDsXwaVL7ntpieUXva4Ffe8kxZx/xthWWU0bA=; b=05EH66bac+UxjKSLHGIZLatz0MHsVJm6J5L6IKHbxNsXKGBH0+XrCQn85p6bIU/OsmKVM0 A9aAC/7uewLjEEccjjZ7QF7KXl2JZmTPXhND+ZiJY8vigGN61/wNZm7VA1gUMpBt66WPDa 4itgyZ3cmW06ADIiyJDudRKlea1L5XY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=gsJgxRHD; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.48 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680029005; a=rsa-sha256; cv=none; b=FwbP9UJSmziF8OclQedxtzSUOESb68osxWfXkbt6DuHsEiOjtn3gj3kQl0od3NRwi2n6nE CTY3I8hUal3iju5OqCu7sPBHDAhjke3n2z7WjHfAfA1bQnYluKQwMX69JzeQvBdGiMwOgk UQORo1BomwBfQgOXR7P5SyHE2mjW+ko= Received: by mail-ed1-f48.google.com with SMTP id r11so53634025edd.5 for ; Tue, 28 Mar 2023 11:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1680029002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Rj2RQnjDsXwaVL7ntpieUXva4Ffe8kxZx/xthWWU0bA=; b=gsJgxRHD3bOgSTLtfz5lc8JsyfjCFq9/1NiJAHhPimNN7eSlnuIqbiYFd01bZKnjkP vevcfEYFS4Wi1X3PMT55jO0hLoanb2YDgLQB0gSA0WRGTU7cKXBQ7FdqWZXGIUTi0z/D uwwS34T9zxFwD124x/eKhqE+Q3wUyFb+2h4s1O+zEfRZmy/OhHw2EFVJgNUkqIBI9O3W P1W537yWyPHsem/Dbp1zlCM6bVIkxo4eis/m7QM9I4yKYCM8l+XkutscKtdNCdql72dA 78QHdu1hsBdcel8kv8irSlL4e6NqUJGVkREQTZ4WoslS1aU7O0XplLGhNFJ9T9qXSA5z Fklw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680029002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rj2RQnjDsXwaVL7ntpieUXva4Ffe8kxZx/xthWWU0bA=; b=YLYXURNDZIuzqhvPR8r4sQpSmlGrF5rz7zrplBSPZSLg5nykyQuwobAZjo3Y7W6M5Z nDvxczc2UchUoTKEQktxD/1M23A1UBzrjytlSKfq2O16JUQZLeTnJBGtMNn0dXyAylzh mtG8obPMdyJZAsuI1E6MoVinK67kopiTVsMAHs+jeLgeELLb8Du9WJDZ4tb/KovfEvcm zOBPGd23WDTIEf8DNmeGF7aX/MsDXYX2lpaXQOSoi4nVm+4DUSntnL3cycv+BlAEy7C3 woW8oPNeO/k8IzfPG1e0oTXtIVQRHfT4pxzokqu7kIpi5UHji8+lexur4yuM+b2QCu3g /IAg== X-Gm-Message-State: AAQBX9cs5tRJAJg1dw/LDZenw7xIRtLOL3KRhelG8XbXb0FFES2uZuXz M/SAvuPYkeRzPKVI6I2rkoD33g== X-Google-Smtp-Source: AKy350ZBgNqTLZmGafKvz39W/GT1Mit2dRqnjGmdrRbaKi3drMY5VIC19T1z7xf7oIKC0pmnW1Faqw== X-Received: by 2002:a17:906:5849:b0:931:4b0b:73e3 with SMTP id h9-20020a170906584900b009314b0b73e3mr16287762ejs.65.1680029002767; Tue, 28 Mar 2023 11:43:22 -0700 (PDT) Received: from localhost ([2a02:8070:6387:ab20:5139:4abd:1194:8f0e]) by smtp.gmail.com with ESMTPSA id b1-20020a1709065e4100b008ca52f7fbcbsm15499474eju.1.2023.03.28.11.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 11:43:22 -0700 (PDT) Date: Tue, 28 Mar 2023 14:43:21 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v1 7/9] workingset: memcg: sleep when flushing stats in workingset_refault() Message-ID: References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-8-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328061638.203420-8-yosryahmed@google.com> X-Rspamd-Queue-Id: 70CD4140007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: nebbtfk3tacn1hmqzytdg8g1w3qi79kc X-HE-Tag: 1680029004-636507 X-HE-Meta: U2FsdGVkX1+L5wXDnLgXuqAZaNS1Lvb1ZmKHXRSRllWIGTj7CweNIgCkOta1OBk+Xc/Mwfcyh5o8dBBUFhEuH0uMiCoB28sD7mjf/10lEgfhHnkqi9o6fdnoPqrrH290rb+h8nR+lfMPsFkUIaycK6QeBC27JtQlKSPevPVgB1R1wN8LNE8vvDrDS99FstigaHQE5laG/OUeoi649/0/U71cH+TYYqxKh/IXCZXZw7QlVeYtuTrhCgHzeizSt6JvrIm7O78uesUOdLNQQdfj7rCB5VUFJEJpw1FAzgZTnMF1NOVAUcpSVZQL/Zxsx6sRN1eAbVUe6dFFtt4jGXhmRLr4L85ooppsPWY1vPzOUzuuTRxpvvgIKWFdH3dgXMCSBlMI2DBNP2CYka91RgKo3PctS5JmlY8w4rB89ZqjtvKs6wKzp2oOLDv7o2j35wJPGc1Fzk9RnfIxCV/zVMdaWVHio2+6F1fzwRMY3juxdaGEZr4xzbP4G3EbXhuvx5tua/1Og+MnczFsM+5HDyDKRwKh3nVX3guYIFKcdehLB/ub46MOOc28bB2RiuYkxO8SWZzPGDO5mXBVZ0B2EAGtc83u3H1BOz8/pLeYWtNBQmRkRaQWZ0Y2jzGLh4P5h0L/Jz3iI+Sq6xymP+AJR73/tVtzNXdHnJRYgGfuWe8t9DCLDmsXOBFlD9bJJub0hfJLU4gO/8nVrlYJlHbXNeMtNahR9D5Ra1pEi8DgMmtzQq60QRFW0i+Q0oItWgSWoxWKHRSbNx+BZR1/NGgiNNV1JXRPeo4YTR6QtNynoIMqGresO1ait76oRyDiTQcyPuJET2akwJFziewOrIF4M50Cs/5zh4LS/ARVDNQO+/1fClwfgAMCRya6gWTbmFpvKMH+S13Yv5qzHr0jWwEkxmi+FlY3heIdsR1uQEpE9DHJidLPi30KBKHso6F+E1H+x2x9b1BAlwv7ixSdIc0XjUA i4MYtpfp Iq4eE3FYqxj9sVpQ4E3EvrD5uBGPQm0MpDc2UtCnjyIqkLbRP86GEthBx4FmCYfbJniTkQmD8kfbkhVxXFs7TQSWCZSzn/GqkugEGU/gR3MyRA1xZqsQRZmabmMoISMiSPd3R/ekJBdHXcsvdxn4DNsl2aXo7tvC8RqyFcfe8aVQ8vr2ML5Gvl+OWMxlhPug0404GsshKUNw1P7KLxheWvIUKv40MH09Jgs1glk11rlrMe/XDawZTxgvsBCnlstSxnsZzuFSoneG7u8ksxo002gu2gpv/DqoctDDExyG3zqclyRAw728nk6GfcodhYEPk0V1UwkwlBB9H/ZetHjSpW+4uQl0L54RrSz0J7fwqVBxzNXoryxHPpYR/oB5y9i2JfoiwfMK/geCe3Bs32JZ+RqH6gWlddI5T2OnCRPTcaryK/3WOvJ6YnL/wIbJeQUbfEqSQoseC+viYo90kmZ2ctIdM3/SbU7aQDry6FSyba3aAhB99sZRU8EVFa/FmzWyQSUCuAgO++S/ZXvcV6iL2gBN513Wb7odxUSnKADjOuuPlzBG+g6AS1yNC8C7Y0z0o+X7R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 06:16:36AM +0000, Yosry Ahmed wrote: > @@ -406,6 +406,8 @@ void workingset_refault(struct folio *folio, void *shadow) > unpack_shadow(shadow, &memcgid, &pgdat, &eviction, &workingset); > eviction <<= bucket_order; > > + /* Flush stats (and potentially sleep) before holding RCU read lock */ > + mem_cgroup_flush_stats_ratelimited(); > rcu_read_lock(); Minor nit, but please keep the lock section visually separated by an empty line between the flush and the rcu lock. Other than that, Acked-by: Johannes Weiner