From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D4AC76195 for ; Tue, 28 Mar 2023 04:49:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D88EE900002; Tue, 28 Mar 2023 00:49:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D39EE6B0074; Tue, 28 Mar 2023 00:49:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C27C2900002; Tue, 28 Mar 2023 00:49:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B2A606B0072 for ; Tue, 28 Mar 2023 00:49:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 762D41C628A for ; Tue, 28 Mar 2023 04:49:25 +0000 (UTC) X-FDA: 80617078290.22.4289CC4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id 2E406100006 for ; Tue, 28 Mar 2023 04:49:22 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="RZfF/gk6"; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf05.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679978963; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4mA4hNb6OnP32i3g1Gzqkt4KFpAv2bmnqekfA1Dpebg=; b=NGnaUU+Xsan51/OZERBElG49XIxAFgan1JsXVMo8l0dMwI0JyFYUVyj0dTLbqH4fpprXn3 2y1u4rrnDdod8bariw99/ZVDOekwpYqohze3y3oHi19GDZlrD/BuTt+XcUcvr0ii6w9wQN lwGjGlsacowURAVoQ1tiEeCGjkCMb/Q= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="RZfF/gk6"; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf05.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679978963; a=rsa-sha256; cv=none; b=ROKZTjV1tjNxt8GSGIV28cb71JV43g62m15NPtcFAVYASBUQDN8DNswZQntkAH7f6C+zk8 7WY9ypSCf9A+QtkX8xvz9cXjbEnPd+E66xCLpwQyYpvIwnS/ZYSqHn0XM4YwWJDxHUOBoL DES7OcoXlUyWpsBBwNNw4alRAIj3ReM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4mA4hNb6OnP32i3g1Gzqkt4KFpAv2bmnqekfA1Dpebg=; b=RZfF/gk6N7NwSA5ZMbzMhq518R PQWrrzu/y1F/IOryxWDqxgoXJtAZcKEs8RDss30GpaKVy2ehvBWsVFh3cXB1QtoLwAHT//y4t0x/R 2k37KXaW2AgxQpTJfYglujXf9T+QajagrrxtwhJLPUX8k5XwVuqQqEEZkbCfEr8z9x7mYBnkxlRE9 PCCh/nMxzZrm6lDiXBC+bqgjRRoAHYNbE/C49rNtzxARzT/RsPAzxX8uABmSzAqjb/GTrd3JF9JOA 6ZRwDZwyVvWdI3bYIQW59yxYEAcyfhHiwLFbz4KTG9Iu9godnDU8FtEB4seOeX+OdEDv0nEEuBL3s 3XhbuRkw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1ph1Gi-00D8TU-15; Tue, 28 Mar 2023 04:49:12 +0000 Date: Mon, 27 Mar 2023 21:49:12 -0700 From: Luis Chamberlain To: ye.xingchen@zte.com.cn Cc: keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, chi.minghao@zte.com.cn, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH V7 1/2] mm: compaction: move compaction sysctl to its own file Message-ID: References: <202303281002046981494@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303281002046981494@zte.com.cn> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2E406100006 X-Stat-Signature: bf6a6pur9x6oie3n5mqduzdoxjjbst9y X-HE-Tag: 1679978962-208963 X-HE-Meta: U2FsdGVkX1/9SRUbyzDfrQM6kApGIAVnoTilKge874N4srL3OyJsQeXy+cM//KvNVawCtRi3OZaSSH1yyoPHVsabz9oKLlbO4Bpbl4EiJUq73y6/uhJRyJNGDACcSqjJAOniqv65bnsvj+tHX21U0X9DF7Z359rU6u1EaBTzkLRibL11nUq/VF4fVztj4jEFKBQNGJL9O0Myc+chFpq6fj3ZecQcqdYQEb4/RBlkKgUP4jOy0tXrW39jTXPWZ3KX0BauFL1IOJazVOru3V77e2Cbb5YP7yi3vHgomXIDnqp5LYg+sVUuSpmAuHr/FHvHXZyW3cZo0RUHmUHqXHRYIMS5faItp0wFAI7ZHO2T7J2SaUrsgdZVH5mSCUEq9lX6DKZrUt0HGoW+haGFcBQfs9gt2aXoAUhMlqTBKmLIw+0YxMKujeyo1vwwz5n5Qv6Yf/4SOcCRk7ALPNljF3HYdVrXo5B64YldRMol/j9q+PWqBLSH8D/KRUaAza/5Qo03366WpKdsLaOzS2J4iA0+zkqoI4/ESo2N4a1DTZBeSo2ofFBn98ODgzOj0ofACRbSbmarJuF2ZSgI87I7KSZxu5LtiNlQKAjV3Jl5LlhgUtiZcy+z/md3rlOQ6ILCLz2Z7Dz9wcBwjaTkvXvn9dGNb9hKLgq3J9+0XSoNU6cZH8vIZqgT3jOjPye50mqt8T3o5a4rMtT7U7/QvaQ4zFnZ4YyC6SbXbQb2SjcivT0MRKB6z5spWgbjD/hTVyG/86JwzOKkFrapGLpty9pHKLggWXCflB3jTj+DEehcJk/CVYtbXuRYU2+BSQehRTWKs0IkSvG0SSUnH85p5VMrCRzU4ZIPUPszFbuK0gSL4eSDBlszmAVGIwzZvT+8aPl2bwURya0DcPDsoph5J6SI8Sr0KWY7AOP5/b721iErv/0/Eiz1HmtG9e78GnMbk5orDrOThJHlf53qNiZHx8FTKs8 kRq5O0Od G0eHdsKS1lnOTS3WU3zHNyZdoy9o61USoyP4IJs9ek8nhocs+CSO514/dTPxrPveC7bS7C/8rbdI/UWa6HODWHWrr0oPQGfsCfavJ6OPDqBuIq1VskSUjJWqXQUgt1JfXyf9Yjj8Mr4iElTMjuQBSxmIR6wCBqyLm9DMNkQth5/jLemIay5DJm0nJ07nWR1V+uxTcMUvvEPiryaJbRK607GjH6DEA3SgDxRHCQxawIdnnpJLHjfj0gEcWKL69P3rar98etQE/O8V7KRcKlvgzyZjzjR8vzy2GYdh64J0/HqnnXlvh5JZoNURt15eiKlxtEtMTVSuNgJCu5RgG6grWvXo0H0kyawYmm3MHGQEbIprmcMDI2qIwRZeUkH3teLnmOWBuYNFlgAEHXqgmeyv9E9NROA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 10:02:04AM +0800, ye.xingchen@zte.com.cn wrote: > From: Minghao Chi > > This moves all compaction sysctls to its own file. > > Signed-off-by: Minghao Chi Your commit log did not improve as requested sadly. Please look at the other kernel/sysctl.c changes and you can find much better motivations documented before there. For example a467257ffe4 ("kernel/kexec_core: move kexec_core sysctls into its own file"). You can also now add the defconfig size results you had mentioned last. Luis