From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D15C76195 for ; Mon, 27 Mar 2023 16:54:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E72CC900003; Mon, 27 Mar 2023 12:54:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E24D3900002; Mon, 27 Mar 2023 12:54:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1251900003; Mon, 27 Mar 2023 12:54:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C22AC900002 for ; Mon, 27 Mar 2023 12:54:27 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8D6FD807C0 for ; Mon, 27 Mar 2023 16:54:27 +0000 (UTC) X-FDA: 80615276574.22.2FEF08E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 8F2F8C000C for ; Mon, 27 Mar 2023 16:54:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YnkKBWNo; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679936066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9O/OI0XHxRCl2GWfaF3ldaUFa5QZHQ75qR1bgkdfgB8=; b=0I78taC1fK6/V9kE9UE+X6I1uS1qX5T0SIO+go9/kBXlXPhi7GnjCOWpiEMLLrbIaY+v19 ts7UoCf+bXWzhGsoxosYTDJwmVUCCxPS/fe2YdEOm5UlJ1TJQfSmT0s3Yr1cVSupTGMC6Y ioAmkCNycTRdUl5AH8iBitmgC8UEMFI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YnkKBWNo; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679936066; a=rsa-sha256; cv=none; b=XotuXlotgRgAg2DKjoPZxGU4TQCG9S59liQmaTh3zEsaFFDiap1xiuDHUhr2TjTIbv3lV7 lfM5YEikD96BuelRy8jRzR3UVcq68GO7+4gtDQv5uEloAK204MaLTi8olKZ65cVGTcvR0Q hU6wgWAfwgIl9OtGnKiP9gCQCrkm4kw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9O/OI0XHxRCl2GWfaF3ldaUFa5QZHQ75qR1bgkdfgB8=; b=YnkKBWNo44hWbpWIGmDz5lNiER NKh8h23Zty4oduxWYYDcuX3dYTwV1rwO/SLhuUE9nzO6vuBCvxdkvn9KXHJrRDeswTALYDYCrDRCx 0wZOqCbeu8Ut1zAFbm2b3NxrBsxWR7KJBpQqagropjpYdWmpSNb0K7ABSKnVJnyHlUQ0X8yaIjgUx q9ipKflshOoSM2ci9kJY0N1US7UBwp6CCQcEO/RVlG+Xdr91X7v1/8JBNG7jX06icQCD+nD39zhhL awmWYL5x+TMrxyDTZxprHNI7K/KHeo+79QxdJMzhgrmR6Uic12q49d6Wv5fI11NA6UgfTnyVgZ6V6 FxS8K4tg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pgq6t-007ZOU-4F; Mon, 27 Mar 2023 16:54:19 +0000 Date: Mon, 27 Mar 2023 17:54:19 +0100 From: Matthew Wilcox To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Dave Chinner , Oleksiy Avramchenko Subject: Re: [PATCH v2 1/2] mm: vmalloc: Remove a global vmap_blocks xarray Message-ID: References: <20230327165228.405045-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230327165228.405045-1-urezki@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8F2F8C000C X-Rspam-User: X-Stat-Signature: wft677434et8fi4wtqpa33s3hr4z8tqc X-HE-Tag: 1679936065-915217 X-HE-Meta: U2FsdGVkX1/ejj7ZacoGS4AfMfwwGRRE+e+97PXJeAmUkDNz7BqQe/Ynh7M3X5nBluX1atYfP0DfXQyoQ18Y2YsYe76lyDp62zc1rWW0zvMFIBtfaKXCdeLRhsq92C+VhywFcVDdVKdH6cRbOUq97SomIv+BjxR+S/kuEzbEBtAyHLtVjKqcjWrUhJklwJA+RHbfv7FMbmz4bQmh/AZRFvXzhuGIOjLaQTaRLfiFTL6Ne38gbLyeJ5D9OcTbQW4XmuPAFQKPaows5QJtElw9vgFUUp29vxFnX7eTd01SWQJvwKbXRQi+CNRaKVmHxeRXqxFhsKFdAFMS1v0MFMdbRziStZv7eI8nBBeBPOqcDzO/l9xGmVPYO/5/5fxzn6SYoiPSx9uYwujmnuAw9LLewnSPUZUK/Ex0xme6jiuWIONg94jN57xSQ3M3pdkOeKgG+Q9kVqyFa9SA6YAmrrqOarHLJnVTggQgORwQT1KFyFSnGfiHEVexJ3mL0ug+NnFhF1ydpvjwF1wxe9ZrQtCxiztaDug0fk/0eb96MRf4z1B40+Ig+RLyhSvmxmnqAF44GCyq5Y7xhwEDy2PPldeZ3Nko+h5LCF9OiwYyPfFalGPmxOov/xMciXy22EE2HDn1TGuAtFXllkKrMpj3sSQmu85Qx8UwZh3R37v+Qq5OKD/8NVAejdZ+GOCykWnpbnvPekAVjXgzEXJBdWcXURWeSe5EV2esV0qvD7FRmPgyVxMlZfA6Le5pUHqnYa/i8xKryYTQumHaMCBKfVIvuR0BvwP7eOKcJuhhQzzVUMjHUnBmBgW/i8vRDVJfRhgQEef8Z0FfzuIJMBvZWvvKFKyhgWfiYmZs/5XBJaWbY0WlRIhKKLxatXFh7qZg37+LGotmH/IdT4g8TK+EmDmN9ZA+xXDq00X+UaEp/eWUAoYR/MAUrarAgwXDkR8FEdBnPNuK4iqDxs9WlNyUUv9InbH EZPbGqRy isn1YFG78nhNE92hQPUgSlONpcvR6SbZNxzXxGhiaOQgu94kgW6ZpPNGC6ObTfl2e8oMWTrmnL7oT9o/5STrZWlc6WTPw0kE0xKPxEV1E1XANL2F+S3RxaIfn9mkN0jRg61v1kswh0McEmY/3IttsCHXT3zGq2KfADrIBQuJzd3oKGGyiovAFg96F/S3BhLWEdagDSLxcmNMkZFA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 27, 2023 at 06:52:26PM +0200, Uladzislau Rezki (Sony) wrote: > @@ -1927,25 +1940,47 @@ struct vmap_block { > /* Queue of free and dirty vmap blocks, for allocation and flushing purposes */ > static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > > -/* > - * XArray of vmap blocks, indexed by address, to quickly find a vmap block > - * in the free path. Could get rid of this if we change the API to return a > - * "cookie" from alloc, to be passed to free. But no big deal yet. > +/** This is marked for kernel-doc without being in kernel-doc format. I'd suggest just using a single '*'.