From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B463C6FD1D for ; Mon, 27 Mar 2023 20:40:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2143900003; Mon, 27 Mar 2023 16:40:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D098900002; Mon, 27 Mar 2023 16:40:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 898D4900003; Mon, 27 Mar 2023 16:40:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7ACF0900002 for ; Mon, 27 Mar 2023 16:40:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4B9C41C63B8 for ; Mon, 27 Mar 2023 20:40:43 +0000 (UTC) X-FDA: 80615846766.24.48DBD0E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf15.hostedemail.com (Postfix) with ESMTP id 7449CA0007 for ; Mon, 27 Mar 2023 20:40:39 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=aTyTas8x; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679949639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IgIrKz0UNBCn4PDiHW0xzrI6MTRBYSXxkJu/zMHUvKg=; b=rsnQ1vjDbooar+TXeliKtk6Q7Kro//7/t4laQAeOj8KtoTbNTw+7ADEULsDeGzjLMxdXT1 qXvmmkHIoWGfMFOyJKK1Smo8VaN5+Zgcg/IbAoDGrjlZuCkDGQQClQmm32CBpWigMD/M/U AaCYqSziwadaIzi9wuIBHVzVnmAq30E= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=aTyTas8x; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679949639; a=rsa-sha256; cv=none; b=aoJQ/4wmcyK2vqCb0DN3gQiGA6eAfr/FbmETGpjO+hnQDahzriD8uIkVN+zHncwDVaTLLw Rs9UQvGcyiezCquR5pMRJPuiHfwvevaW4RqfHO0sfUE2Pb8bx2Rzue5LLVgVdoIbUKG5jJ TKvYbh9y4r0dmxCyolIGmM0jZ9EOd9Q= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DE16C1FE22; Mon, 27 Mar 2023 20:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1679949637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IgIrKz0UNBCn4PDiHW0xzrI6MTRBYSXxkJu/zMHUvKg=; b=aTyTas8xnndKQ+7rRpt7+uxegjLQTBesNPvbKnCfTN5qLbE6ycmNqY7poDyjI3gNMFpEEc q9Tr3ZJm7OP//76yYW4qy6Urq56r/oM+X/rPvVywvwdlCrSja9e+wB0YDmj0DVFfr2QMqj TEEofls4ExVM5wz3WIr2NkNvgkrZNJI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C06BA13482; Mon, 27 Mar 2023 20:40:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PIgTLEX/IWSFNAAAMHmgww (envelope-from ); Mon, 27 Mar 2023 20:40:37 +0000 Date: Mon, 27 Mar 2023 22:40:37 +0200 From: Michal Hocko To: Florian Schmidt Cc: Michal =?iso-8859-1?Q?Koutn=FD?= , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] memcg v1: provide read access to memory.pressure_level Message-ID: References: <20230322142525.162469-1-flosch@nutanix.com> <20230324150350.fu7itbqqvtjmyf3s@blackpad> <6f4420d0-2f86-7294-01e1-6806ef7e4686@nutanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6f4420d0-2f86-7294-01e1-6806ef7e4686@nutanix.com> X-Stat-Signature: wggceg4z6wkp5b6rhxswszm1zhy548tj X-Rspam-User: X-Rspamd-Queue-Id: 7449CA0007 X-Rspamd-Server: rspam06 X-HE-Tag: 1679949639-510126 X-HE-Meta: U2FsdGVkX1/duNsSDCloTgGN3B+Bxf0FrneDa8LKgNGCi+RmfMPxHKtkfau1sUNJMH+3X15wSZCf1IDOCRGY78MZNHzVfsCwItIa7dwJfZMiAv2UmYV/pVxPVAU1w6nxskok9hV2XuETGHF/k+HToS0u3Iqy6MG48kWCy/hWOY9OPJl6gfl17JloiRyw5R+b/EJXJBe0PpXn6yC3mSUAhUOsxuiMAtxK4yxZQNgZZCgvU7WCBrieOkikmOfaMpS2HmpyXmWiSieTy7gldCfNwCBglJH8PDZ0w8cfsxVY1T9CB6fVvVfg1fW3QqNp0LosAv70Pfz3yuq3pL8szOmXEVhaG42SlyhdupwySEV11wqKGRd0TZj08bUnr0Gz1LZjhudA0A4ySUbLO6b4Z+YnxWjgkkOgNPhJqHVGubkTqKy9GakurMVx6Kq6sCh9mTgQqyA2V9yfCS3tUtLtgCp5cO1usJWKvE4NhUheao85BEkFMKUNV23s/TjVM1VSijC0CtS9usg6qW43HMpo3Da9qGqwSQqBYHY9FHwMJpfQkqpePdxZUft7rioCbcHUZUOHjw264rkrUwQbYEXrO3/7s7gG5wc37QXqvUxJkX3k4QeUPR5kRr5tcBbCwjuSLREGPUJOFhVwzkuIwTW0kPyRBVAfcnGOkwMe+5ApcZpRMsFPw6/npFGCLmIdYKE4JsfsvCw9Orz3rbKdG6upAPZIc7UYNXFxgfgvyiZWVxx9Ibwk91TU3qLd+owAqe3P0bCLIodpLr2Iw4R1DSXEQ5Hcm0etgv6tXH77RMPH/pr9K2AZoOiSDiS31MHTl6tGldfWE7zQxf6M7qgv9XI1yv5esPjy/EfXdeEIwZ7NRmtR7O6OykI0JjTW9N+bSZ04IyJOGbOYZfj989FUABp9QOYgj5eSBn8VrIq+BPGeYvmPWg88OEyv8UBPmXxT5c9jo3UACXeSw/MjlAsEWBqdyiQ TFh2i8UQ FF0oB4PsZlCgA08W2pNrnkVi2Onr/SAoT9w/QuzqMHKOPN9lPulF9IKfapEpYsvyzPooFQ5sWyJkpswazbiK3Z5HWEF2L88g2zsvuYAWTPlKFyc3DBG5KCXyGz5/ptpIdBxriq4twHXSWWgYq33RRJaIh5jSV5Qj9aEExOi14iKTa7K9T9ZURyIlNw25MXTyp3To8zTuo81P9F2PVf/2l1BAnTalLAx/xov/QpCUjx1G3YUxNU33FkK7k+jyATBzZPlDzlo+CvVTNo2s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 27-03-23 14:59:37, Florian Schmidt wrote: > Hi Michal, > > On 24/03/2023 15:03, Michal Koutný wrote: > > On Wed, Mar 22, 2023 at 02:25:25PM +0000, Florian Schmidt wrote: [...] > > > (b) would you be interested to take this patch, or is it too niche a fix > > > for a legacy subsystem? > > > > I'd rather not extend this "unique way" with additionally unique dummy > > helpers. > > I understand that this is all code that has no modern user any more, which > is why I tried to keep the fix as self-contained as possible. > Another option would be to have a special handler in cgroup_file_mode(), but > that feels a lot klunkier to me, and leaks a v1-specific behaviour into the > shared cgroup code. Yes, this is effectivelly a deprecated interface but I do agree that we shouldn't really make life of users more complicated than necessary. If the simplest solution to address this is to provide an empty callback then be it. I am not sure but I do not think there are other cgroup interfaces to warrant a more generic solution. -- Michal Hocko SUSE Labs