From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7479BC76196 for ; Thu, 6 Apr 2023 19:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C67D96B0071; Thu, 6 Apr 2023 15:42:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF0416B0074; Thu, 6 Apr 2023 15:42:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A91946B0075; Thu, 6 Apr 2023 15:42:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 96EC76B0071 for ; Thu, 6 Apr 2023 15:42:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7BE19A09DC for ; Thu, 6 Apr 2023 19:42:35 +0000 (UTC) X-FDA: 80651988270.11.6E41A8F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 5BF541A0017 for ; Thu, 6 Apr 2023 19:42:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WS2ep4Ri; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680810153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tmB9ef+i/tR2RuBXG/MztGedwZCTfoIM0/9hlfY16FE=; b=8r0xnRRNT/v//ena3S7XUBxu39ykMn+AZtfUvZvKCk2Nco4G3VozTb+/auQRZeqjzyr8ZT Gtl46bDVYYWaXM4zQxR6EKdHVcSN5k9R1z7M8rHYzoGwk0pmCM0AxcgdYcfaDSKa8Ct5ru hi8mm0oMzVBlyw4fIJvSLgnNiY3E7Oo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WS2ep4Ri; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680810153; a=rsa-sha256; cv=none; b=FnGMCIh1uIQc1asP7z7tvsXsPcces/wkkTWBj6kBw47qrSaezooi+jK0d2uuc8pyKcCsvo fpXFw2fiZY67X9Bw44qyW/bl3qPEBN7jAHJE7gaE4Az59efX52P6lZyLS3yMCZbWQ6fCny 5QURHYM2teNJ2H0AxpUZvFKhoqsQvTI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tmB9ef+i/tR2RuBXG/MztGedwZCTfoIM0/9hlfY16FE=; b=WS2ep4RielBa//Iw2N2zKAwJpB qCW3YjQTQSwAfLWsSVsoutV7+iFjBH0DhQtPhkG887UABmFOFnrdWoBFNHbNrBDGCbea+U+ZLElHR jpnGTSqsWJWh0+w3U9mnzIHezeB6zdA0kAhtzl4zo5p3DWPnrqay+5ChonJviuxlPMDAQG8hMWorV 2CC5n6nWzUM6tnRcyPe/cG3Kv4Sm0Ab2RHPfymfryGeBemgO975S3yOvUByubbHw2gtLGkrDa7AmR Wsm44B7yKULXBY79o00EeBYucQQJa/sJzME5G+YJ/eYZV9hsFkGFwuEa6k6mHoenQ1IYFk4Rdb8AG xKOLOPiw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pkVUg-0006hi-MQ; Thu, 06 Apr 2023 19:42:02 +0000 Date: Thu, 6 Apr 2023 20:42:02 +0100 From: Matthew Wilcox To: Tim Chen Cc: Yosry Ahmed , Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Dave Chinner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 2/2] mm: vmscan: refactor reclaim_state helpers Message-ID: References: <20230405185427.1246289-1-yosryahmed@google.com> <20230405185427.1246289-3-yosryahmed@google.com> <7ce03e4323b95c1e8fd3faed32c9b285162fe5a8.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ce03e4323b95c1e8fd3faed32c9b285162fe5a8.camel@linux.intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5BF541A0017 X-Rspam-User: X-Stat-Signature: 9its1e4gqrptua85arb5fj6ubceunxqt X-HE-Tag: 1680810153-494381 X-HE-Meta: U2FsdGVkX19WpJ7NzyHl7hf+BWzT6QCarBDT/XT0Bv7GHGN2d9puBOIG5tppEptFz59TBy5t/4Az7avHUnW421UvzvP+S3lrl1f2gvAZVHYR+K+h/L7moFvcEplIvXKfc71RdWPbqlFLQYopb//69mXv6Ms2dsC3to+Vp9QiJKGp8QgvR3X5goQe6X51aU5a7U/FZUvlvUxOXCKO6zWJ3VuBquXPbBA7LgDqEkVqoIPg9Sl1Xv19wA2LiBJD2XbcCOVEVg/WxYQyv9s6FGGdfpRkwg5YTTDhzIb9Fw0ffAlLxMv3ia+ZoicEWGf/dfCsSZ7YvOynZZaj8b94baeI/pcf0MVsWT816sYlFI4OEM8vIgAYGbll/x8Jlm7utd/NKUcHK37q6e2kAh7MD0gshpPk2sUCWMiFR8weE1lFFFY3qac6rNaklXauw4IEwPzqaTPle+vUiHHA7Bc0+QnjuP/2y+65T8ZaGhTmIsev5Jlu1iKX12t1Z1U3ZXfU5EHQeos4sddnMMHxzHLLCdvX3QeJp8wrDCCNFPyqJkaZW/lWejkzVn9dO5H+S9G6rN1QQ5QrohgpBHimkBNj6qFvrxGR09XbXISYWyOt10F3RZwO+D4RHiUyX3fAWMTAhAJ12QkDVasMKWuw0B6dCI2U4b/Sl7uhbw06b0DjL0zAg/LGrehM2Y0j7LVXjMvEdOMZA81lEoLR2TKKVqL2luNoqwDZ0GUcP/Y5qQ/ILb5+1OUTqQnvwEc54TUvkyQHhwysJKHAnUn1ibxwl5BkCzicvi3PHCj7pRbjXEcs9sW5AOYbdoHwWYFguEfs0Cvx8foFT2gpcnmuw/Mis/19zwQA38E4GHjV8KpTsrLS4abmXglHd4NLX4bFjK94YtB/hjFnoL1/iqdevKoRKgQazqPeMLH5biSlUKPN/y5MIpH+pTBnpePV44Ux2B0UORjbiYUcL2mmRGQloZe5JynTwd1 zzeBbWWx i/gw882dbaZ8Oh8lRwa6y99IlZ6mb4IZYI02+mFllMxboA6tftq8yMPFYvdRw3N61KQSnz7wpZs5onL8RsmYNa9nJsoPfKjivrdxXswCzr2gJMmxff9ziOEE2LDeWvk06cU2rj259hc0fCIGG2/nF7FHDdB1NbS4yj3JZhn3e3LkXQo79mFfQnsrOiX+LYuHyWXbuNh+2H8cx9ZPBm+2oHWDVLWsCQn+6Ppc4CYF7r+Si7pCDE2uCGuLiEVhmzmQYTuxSauq3vt5HTLqFq4NB6CTpdOhhV/vFmVpmCcEvB+eIMXN3NoAxHH26xxlQHGjYA9lXXqptv0ms7R0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 06, 2023 at 10:31:53AM -0700, Tim Chen wrote: > On Wed, 2023-04-05 at 18:54 +0000, Yosry Ahmed wrote: > > + * For all of these cases, we have no way of finding out whether these > > + * pages were related to the memcg under reclaim. For example, a freed > > + * slab page could have had only a single object charged to the memcg > > Minor nits: > s/could have had/could have No ... "could have had" is correct. I'm a native English speaker, so I have no idea what the rule here is, but I can ask my linguist wife later if you want to know ;-) Maybe it's something like this: https://www.englishgrammar.org/have-had-and-had-had/