From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EF47C76188 for ; Wed, 5 Apr 2023 19:55:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C0B56B0074; Wed, 5 Apr 2023 15:55:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86F4C6B0075; Wed, 5 Apr 2023 15:55:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737386B0078; Wed, 5 Apr 2023 15:55:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 641C36B0074 for ; Wed, 5 Apr 2023 15:55:55 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 27B71C059A for ; Wed, 5 Apr 2023 19:55:55 +0000 (UTC) X-FDA: 80648393070.11.38010A6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 5C5482001C for ; Wed, 5 Apr 2023 19:55:53 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bylkG3lu; spf=none (imf13.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680724553; a=rsa-sha256; cv=none; b=rSB6ugTIE9L+dCb/bTa7cqggljpUo5vZFvCwXhdGlQkfRqxfFhgomq7IAYVC/cRv3ESkMu xbUXxbkY/8l5h2Pl8QpJaBXBbVnSwBv30o9bUUxHfg/QcYUzZLJ7BH37bn+evvu8m+3t8j vJBcOEn7ntYCW0nxtrK7B6IoMwu008o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bylkG3lu; spf=none (imf13.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680724553; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oxyebGN4w9Tc2bUcUmGtLbWmMd7cSv90tfCn7BeaNE4=; b=fxaOhHUBi6GYqqLmxL26iEUvVMZ3gFsb5IWQRMV2obMRL4SymFzN9GJnqAHv0n83LU4dgL 1JFERDZV1zw5uvMv7tVh9BDlffnLXWCrZFNhuyC/ZlZNb2u5yOZ0dFuixl1q7NoIPNfjAn BhGajQBomxxoEJYl6jktshs4wIOoI6o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oxyebGN4w9Tc2bUcUmGtLbWmMd7cSv90tfCn7BeaNE4=; b=bylkG3luwr4nDuqdrcTmlfI+IL IwkxblxNXhMeSPF7vjlklPRQBNqK90YVcnKYN+VzRZ+Lb77rq0Aw+y6atIGqqbdPrZNbul0bieJHZ 4cvINOtWp2iddJixjhz5WvyJ1F0IrWsyrOwsRqzdyJ8hAWT515k/6eWze/g2Y16wVLKZ1MPH7QHIh lZL+WOjZ0F0KHwJLoQ+54NgXqbsHeDlIsq+zf1rKDUlpugnMvP4qBKM+VVFWw3ZCSY0Sv/7Xjn+6n VODGc34U2klGE/zQmMiCKdRWrdb+Ydh0vYs1zlW7MI3pqv3vltzx7GWURHtp/AaU4idrGRZ886lG0 Tmk62b6A==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pk9ER-005YBk-20; Wed, 05 Apr 2023 19:55:47 +0000 Date: Wed, 5 Apr 2023 12:55:47 -0700 From: Luis Chamberlain To: David Hildenbrand Cc: patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, rafael@kernel.org, christophe.leroy@csgroup.eu, tglx@linutronix.de, peterz@infradead.org, song@kernel.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v2 2/6] module: move finished_loading() Message-ID: References: <20230405022702.753323-1-mcgrof@kernel.org> <20230405022702.753323-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 5C5482001C X-Rspamd-Server: rspam01 X-Stat-Signature: wzxi3js7qgqqbehtqyqpt3rq4d7ppnfu X-HE-Tag: 1680724553-734542 X-HE-Meta: U2FsdGVkX1+t338fo5pv9EuRwpLlqyLho8V+fiQ0gsSLghxcl7f1erHmAvcgoH/qGV9Ubl1a2Uipue3YvK3stNB+ioSS9bPgm9JqPT329EykisoEL7bYcq24ROW3+UHQpvgX4+t4xy2bVv16y29qWQeug5gX+DgWF87XKsR6KYPJ+2W5pehaxLNONVFj+INiY4vdjUTHcR/Qal43Y4BVYEwmguiTVSeGkbOVAJHaPLTEHLhgkdMFOWb0Q6kQi9MI6LT3uIDGjeYw7CsT52d6W8ioVwkpAgbT6CfnPtZAeYfJgIQTManGSGYhbl5Bu0agQmAijmK8QsTu7URIQ6GUXnY2qxIMrPMhteToNryNbI5pgD55VbqLO6NP9e5ULl7l0YUILc/uXATLTzaRvkNp8x/6GZBRG2yFFXMkHuObfMkVxN2tdd2tceHaz4UL3IHNcxdY6SVdM/69MuGJPFX8Ly78frabm0TcCheUK3MdJo5x/bnRl+3wDB5U3RX0jMouElxjOrLYsetrMjl0D8fXMgbKUXm0H+CdSOLxrRHrzTjbtcM5yt9Ww7xHs1I3x8cEo1uyc+gKeRuf7Cai9vH3+Cg+rAjEJDItV4PBrkmSKgupYXY9E58qYOIyV7ajuASpToAW1zBlTJ+FYg/JRDpjE0p9s+0K4fXhbgQx0ZtknlMBEQmg+o6wU1BA03LVU8UFi6XEwU4oCHKhZ2xs83zK1DniQ1cMe02iDSPDJ/yvu7wKJGq++9W5W7t3fKI16s84u7R/SBZK0Er+OngJ9n7MarYcFnoBRsnKfgCqNzbUeTlnoteaZ4qHthAwaJZM3A7hwFjB5pi36O2kAam5fB7O5CWLpj/pZXiC6sYzGjN5s9+B4pliRzZpDLtTlRV3RNmn7WmtvJ2wwxRwxd6vjbFZivcxtJMlnpn8nTQnLA2e3VYJog0hm1qYm1oUZk2JeRU3ap9C9aQkMXgA4Vful2L mb2I/0lk hH71PmrL6ljBg9iQ+E/wAF79C4CToxfMdAsbwo744M/+rFUyeLkjvn/ywPMMPLpk0NetF36L2v+rt87fhIW3DPMA1I0hWgG9xOiRPk679DZnVR4CIkwioHfOPLbTGiRygcfYrYxk7MyBSEV0wj7hUA5vqQMkuJST8zMQkonOoEtuIegtmS/gn2njmX7FDEtEvqbtuMgwauLE3PTPncJt0CM/3WO32mVJybCB5/3yKLUatVCFgIEFua8686fhUsNH6RMfMMxfcf4jMRBvGVkXBmNEx8D5YUXJwvIMcaAJBkQXYCXayh6j3VyXr6tcqYGUxP5BJc9cI5Fx98b7IWsA0AqF/M++QSlCP4SWuGh4Z2y/NGZNZm3AzpeDz2aTSpAqhzLgcByIXhK2uzrKPm/blZU1x+gRh0ARxQicK1hdvMFYocfObN3Uli51oIKpWGhPtR1gPeE32TdA3jkN8sgbmviFRELzgltTxMFShT78ieZTZExrxCUFLsCIhYldaXi+Nfo+yNEf0WZtTdkWno25sCQ/TlsTdO5GWfd2oU7PxVz6QGIk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 07:06:35PM +0200, David Hildenbrand wrote: > On 05.04.23 04:26, Luis Chamberlain wrote: > > This has no functional change, just moves a routine earlier > > as we'll make use of it next. > > > > Signed-off-by: Luis Chamberlain > > --- > > I'd simply squash into #3, as that's short enough that the move doesn't add > significant noise. Anyhow: I'll fold that, thanks. > Reviewed-by: David Hildenbrand What would be *really* nice, if you can, is an output of the new module debugfs stats on your big system. It would be nice to also see the stats if you revert the patch "module: avoid allocation if module is already present and ready". The delta between those stats should give us a more realistic analysis of probable savings due to that patch on virtual memory on bootup on a large system. In particular the delta between "Virtual mem wasted bytes". Luis