From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C2DC761AF for ; Wed, 5 Apr 2023 16:53:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 303916B0071; Wed, 5 Apr 2023 12:53:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B3F36B0074; Wed, 5 Apr 2023 12:53:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17C416B0075; Wed, 5 Apr 2023 12:53:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F18046B0071 for ; Wed, 5 Apr 2023 12:53:11 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B0748120D15 for ; Wed, 5 Apr 2023 16:53:11 +0000 (UTC) X-FDA: 80647932582.29.5226E77 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 1C9DD4000F for ; Wed, 5 Apr 2023 16:53:08 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Vszq9Sja; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf17.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680713590; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ibm+nWW7IW9tcDE0xVaQziVWYwGIW9klab1GLTkBWA8=; b=iqPtgbSYpH3D6JUX1Fw9PVXzsU2niCns+vGofoRPqF7UbE+na+aR6BDh8dh8IJy62/Qomq isUbwBl3jB7EVCj/Ru6/wQ62OZuaxdM/9XKqKobGN6DMSYV6VMEv9+zl9M2eszIcHu46au clJ54cACzy/NwYYKEllXweEqKYx3M7s= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Vszq9Sja; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf17.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680713590; a=rsa-sha256; cv=none; b=EdwY8WbS12N3E5SKkRpmHLBdvUZC0YnNYkFJRt1YnrLCH0HkznGwkYGFQaP+TLR5sTdTFy bKETE8d1n/hwlXH3uJuu4+pWRYzslT+qCyxiy8T3yYukVCrOAsqx/koZt98/mFrNjPGjxP JRzqdeJ/2ZvRODijqUaOjuu5BCqT1y0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=ibm+nWW7IW9tcDE0xVaQziVWYwGIW9klab1GLTkBWA8=; b=Vszq9Sjag0KovbFyUMSIcdP524 sx4GTfSXPdQPMNeFs+3wFwwWnKOBYkz+C33wureTGP8x88exBW5FHohne8bJGpScLFtLp+RPI5CaN Kut8dzMCf0y59hZNjJCXQcOfUrizMO5bph1jpdXdhCsYgNeG7L0oozB3WVaomOOpdtose9ebh6BBV fOQmoxAnQliQsozhiVBeZzU6VmXbABZUOT9nbGZ08aCmcCEOJpsAvzfRbwfnnJiQ1ly6XCTacLdSn OWB3x2K7tk6m8/9LJIfUd/ucqlolkGqzUHepQBIe9h5b0nfy3tUUQ6cGA/xrcngBZohsJkwiuFqVa Pg1Ne22w==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pk6Na-005BOz-1J; Wed, 05 Apr 2023 16:53:02 +0000 Date: Wed, 5 Apr 2023 09:53:02 -0700 From: Luis Chamberlain To: Linus Torvalds Cc: david@redhat.com, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, gregkh@linuxfoundation.org, rafael@kernel.org, christophe.leroy@csgroup.eu, tglx@linutronix.de, peterz@infradead.org, song@kernel.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v2 5/6] debugfs: add debugfs_create_atomic64_t for atomic64_t Message-ID: References: <20230405022702.753323-1-mcgrof@kernel.org> <20230405022702.753323-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 1C9DD4000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: aw47te3zifu6ngmh46rhbnjqbnrpyzx1 X-HE-Tag: 1680713588-886265 X-HE-Meta: U2FsdGVkX1/76Rj85aOhBQ8b9tXUhwZMQIwVgupG5TFrZnRsw6zGTuL5Ea3Vmac4ULLsMhG5NgErRYwmeKjI56jE1tYj85rSKRa/46trKt6sJ8XZcAF0QEVlGkrcQG+txMDQ2+Z4cXpJMRL2Y3Qsyf8PQHtgn62Ok92Iw2MtT7EOU34eCl8gVCWo7TLvowgTwp291Lhu+P4VyjIgdmCYs2DaIYArNfI7mvdxNI6vxpooR2ZEG3TeYy8UAcvCh1trvceT9A2sS9Y7V2nythS4miuSfybmrB9F5cIFw7XG3loob71OrbQesI+trTq8KO7rzA0vfMt8oWlztV6q5zbYNiHeVXN5xqxaopOIy+ZhCh+JTpnKZq287Jx6owkulm/sup/0/DikwvMAu7cyygaYrVEF3bLb2+ZqCpzrC7JQT12Hvltx1LXKARp2JW+Ic/Xka6TDvPO0GyBgXXJCQE/SJmWs2u/91CJfHS25WyPSxSna/4HAaM29aHqca4/mStbjxDdij/8JxKYyjQI5EYC+AsXtHDNZcmVLDDDYs1OVkZCaXVRIxMPhH8YhSrEoMg7pmlUe9yDxh8YBsFMzlS5y2xl+cAR2LdhHd4J8Ep8GP27S/2ZEQLNmsGSa+CN7Byu4Vvffq8AmucSUDmn7K0tNgl+xUulLeQZs0KqYUdvfr23AXNvmSuKiRZs15QUNB/BEeEmn7JTCEQR+Hb8bXvaJB9IqVmMDCIrJouWqj4Z+zReNVjm77lhPHJgOBP+o8ynADz8Bn6ng/aSwRaQbeQCcTunBYrVQ8PL4hgYTY6jj3TdL1Q+n+s2LqiA1g5i9cT6i6E325cFYQyGkTUcAFWfGHmea13DLhUwEOohYlSPFAauLJxP7JIbKXUGFcE/WSiPVI0ktu1sIINULWaLs9CAciLDiliRutTKl+i8RQHzR3VAYu+K/MhZzh9gygK0bqvTQiQVmz3GiBrxAogWpVbN Ml4WY0pH e7GhYQXSUhlvN6n8HFbmJv0zt/MqZAfB5JPEXPPnB4kEgfzAQ8M9hlTN4JVdRhFMzi6USrG9+orE9RxpMJTPcd1h2jXh4+SQbTo6kax7s0oow3QGOzY8FRkY9NIkKjfw5BBpLaozCBo62xPoHjlpZqLp5c29ABIXsjnjsupfOMYTF1EqLTVBAlYVNK3jB4Nk4UELLQA5FXF6kKsfjtGFFOPC0wkkv22Afmll/6OfbCpCOcpGU+fBN9Jm7UXBMZJOVjcgfFOj+FWB72M+jrFXdE5NqWWWHunv3lH/c6k2BEgtLqN7euL2D23G8n8mgtkkGEn1MkcFgtg4OAMNRwajnnqpZtDW8U7QhvsZzrCv8xsQd0J8yS1k1F6kuHJkUbBgoCu/ub97u6+7hRJDKLBktaUppmYkVejUQUTKF4Bjo//fOJtKeRZHnYtYQWr2jMRWVtEqgMmL8IoYsph+SQSCo1Zo4fbYcSVgZTTTiTXDx5Urfj7yb21Cst6J+tQw409TSDDc8Ar8/njZHN6seg89vtPK2uQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 09:23:09AM -0700, Linus Torvalds wrote: > On Wed, Apr 5, 2023 at 9:11 AM Luis Chamberlain wrote: > > > > Oh but I don't get the atomic incs, so we'd need debugfs_create_atomic_long_t(). > > debugfs_create_ulong("total_mod_size", > 0400, mod_debugfs_root, > &total_mod_size.counter); > > but I didn't actually try to compile that kind of version. > > (I think "counter" is actually a _signed_ long, so maybe the types don't match). I see yes, sadly we'd have to cast to (unsigned long *) to make that work as atomic_long counters are long long int: debugfs_create_ulong("total_mod_size", 0400, mod_debugfs_root, - &total_mod_size.counter); + (unsigned long *)&total_mod_size.counter); That's: unsigned long min bits 32 long long min bits 64 But since we'd be doing our accounting in atomic_long and just use debugfs for prints I think that's fine. Just a bit ugly. Luis