From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 653D3C76188 for ; Wed, 5 Apr 2023 16:11:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC1CC6B0072; Wed, 5 Apr 2023 12:11:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C71926B0074; Wed, 5 Apr 2023 12:11:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B39B26B0075; Wed, 5 Apr 2023 12:11:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A44776B0072 for ; Wed, 5 Apr 2023 12:11:44 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6F7181A0B96 for ; Wed, 5 Apr 2023 16:11:44 +0000 (UTC) X-FDA: 80647828128.15.F818636 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id B104E4000C for ; Wed, 5 Apr 2023 16:11:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uKSk6Om2; spf=none (imf17.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680711101; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qldM/7DycK2kXcPvoSTAVSBVXOLKfEWimS0mzWEN0PA=; b=BGgZzA48ynEEYBc2H5mhUNfhafSd8HL50yis5/h2ywQn3bPByKUSnQcFXcJnQh5LcRCDQH MwPoDL1qGw2s4lNV63ivX7cXFndSVnSogLwCXykbS/OCL1ZBK2rRg47hBjQN+osKX1x50B 91CzGQuanopJpPdWuolvbobs4LqgPDc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uKSk6Om2; spf=none (imf17.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680711101; a=rsa-sha256; cv=none; b=LtCupEaO4fpBNkHBa22D0CG9ujtLGOU6zdJlPlxy+gtWiUfIRFZgKyjARgSD9YJdKACw2O PcUktX2gmHUj1BWXYC+hhSG11aD0VErYY6gl7872vZfDNjUgOiLlGiEBboi8PTzpfd108H L+3doJd9xhkIfIHlvIjmZDU3DB919v0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qldM/7DycK2kXcPvoSTAVSBVXOLKfEWimS0mzWEN0PA=; b=uKSk6Om2/NU3maf33acFrtO6gu OIv1XCwY94g5GkoS4nSdVHO+fLQ8yoVy+2oEIJb6Eo3G0IvV88q4ayMvjqIwIkhy9jUo/dDncVRnx u+FDJHTdt+0wDUVbp1CNAZyEQnlWJtPf53hY9zehTgyAL2CL1aYzhjezH39+RWlYzuamcLYNkzBMR gyC0cepCL3opJ5+N7WaQJlrqWASdTKBDzl5KN8gAS6OZC7+lIVrO3jC7sJmUwBmsmKsBcwZiQGM9M CK7UY2ggk7Q+b5T6z26zL9N5SsI2Z+tj3aiNuFML+3zLB2VD092PdAZgb5UWTSfuvpyP5ogr+yYpg FLUeMU/w==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pk5jQ-0054uI-1P; Wed, 05 Apr 2023 16:11:32 +0000 Date: Wed, 5 Apr 2023 09:11:32 -0700 From: Luis Chamberlain To: Linus Torvalds Cc: david@redhat.com, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, gregkh@linuxfoundation.org, rafael@kernel.org, christophe.leroy@csgroup.eu, tglx@linutronix.de, peterz@infradead.org, song@kernel.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v2 5/6] debugfs: add debugfs_create_atomic64_t for atomic64_t Message-ID: References: <20230405022702.753323-1-mcgrof@kernel.org> <20230405022702.753323-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B104E4000C X-Rspam-User: X-Stat-Signature: pk9kdnmm7bpzyb673kru7toojkor78pi X-HE-Tag: 1680711101-544310 X-HE-Meta: U2FsdGVkX19uByX+AkwAWNh9o+lcZ/y+fzPPHTCPhA0n7RcHIb5ZfNauBJ8nYjI04A1eKgGcJRO50fpISlj8sB/LzAa41yd5emFR3Z4WQfro6vSCmZV/PJnI46QfmoYjRGX9+NzWs65TUoi8G4ZGtvwv8nJrPuhhxWmcXyKC+Ee/Tmakfu5DvoNXHq/QrDK9Av/+v7Sh/Dhor5dBU6r8fCZmrdJmejuTO/xyRdJc9kxu6ArcXUHit0K/ZaS6KrRdlNrb3m5CKqd+tviG6gsdTBTryrx6xjquPhRctpxVrmY9qc6Ji50oJvQR3fmCM9L5x2JHdh08ts10eB7HlGxZ6VzP7Ji7Wj5qm2NtScRyHwRO5wq2kUeEdcTbtLqNE0v7ZhKk3FdW8CR46tw+nhEd+DKDLTLezWuPtKtzYHAmC1ICsEhtbYn6Ycr/9N86j7OorAJC99d/oGwBNxy+3PKzxOAmRgZaCUAhicdDB+GFEQHT/1M9ZijM4Do6jmeA7FJDz0PG2Q2bXXStVavAWGQaAAayT0uv9Rnlht6rB9hOvn5oS9c5hDbNfBnfndZfGVKw7Fl7KIBbz4MdQ0IIonel4FJ/4koKklN6vv+nhQCH10d8mYPDqAKIrZaCZK0QoMo94VahuEL0u3e9R02b5mJ2SS9f+5iNj5+uKzVIhRVEvrLjnT4EG+qa229K/lW1AVhio1wjKHlEeedhBvuc8xIVNImsis0l+HkVdZea/2h8vSAtYRGfynFYh9h3ecfwfgV9QpayI+6Bx0eo/MsZmHIvWHIWcnODUqDATIKhOmwImTN5HynMgdlQE2j/hpl1yF+ib6PfojhYq6zTTfoAwRFyBWqWv83wIJfLdM3BIfP99vSJXWQvvlHsSzm/IkV472hl0DlY9sbfzTMeDP1Bs4etemZkQ3ahUl9nD99JQVRPS+bsUI+BGbu4Z7BXOLtw1nE+dt2GPl9qi2Bt4HkPFA3 ac4XugZ1 EBvMF3FMttSGxhP7s83PH5qZF+f1o5cLyQWDPl2tqG5OVRAUykAiAug6vxtUZ0zjkpD88XUn8j9eZh2+0iEYcSnZi9fDO2SpzD7PLcS2mRXoMKsrJTdA8qIU/f/hY3UhmOM7HXopRZNSNOCMXog0mJ4Jl736odwbfkfSLJzDIMSiAZmPgHx4j2n+uMgfc54njVOqV9dpL83qi6pHhqqOygzEcLrH5pIncjyJ7oxZk9GLTixbJoxuqhv6wmzqWTHOoYOmb8uy1j6ZrCGMWkD1sL5UrI1g8phbJw0LN1Xlcg4UVExLVWsizB10kfj/0lsSGUsNzwmRsCMSAcFklQ/3ZwRmVCor0cootadyWr4AQk63K8e+YlG8cs3W/G9s2+uQqrdudcJdLfReXAGvCR8QUNYOtP2Co/ulrV9fGXxQ5MQg5xLMnmgfZ4TcyWLbYCg7eIAeM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000066, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 09:04:27AM -0700, Luis Chamberlain wrote: > On Wed, Apr 05, 2023 at 08:26:18AM -0700, Linus Torvalds wrote: > > So I realize why you use atomic64, but I really suspect you'd be > > better off with just the regular "atomic_long". > > <-- snip --> > > > So something like > > > > debugfs_create_ulong(... &val->counter ..); > > > > instead of > > > > debugfs_create_atomic64(... &val ..); > > > > Hmm? > > We already have debugfs_create_ulong(), it just uses unsigned long > with no atomic_long. I can just use that then. Oh but I don't get the atomic incs, so we'd need debugfs_create_atomic_long_t(). Luis