From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83215C76188 for ; Wed, 5 Apr 2023 16:04:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 154746B0072; Wed, 5 Apr 2023 12:04:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DDFE6B0074; Wed, 5 Apr 2023 12:04:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC1316B0075; Wed, 5 Apr 2023 12:04:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D701C6B0072 for ; Wed, 5 Apr 2023 12:04:36 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A899241139 for ; Wed, 5 Apr 2023 16:04:36 +0000 (UTC) X-FDA: 80647810152.07.6E0C861 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 641D620036 for ; Wed, 5 Apr 2023 16:04:33 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=URtqACva; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680710673; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TTJqlOzBPX6Z6lfFHUBA0hntJ2NYe0aM0CZZgdoJKu8=; b=c2+pWaTiyyHsgxf2aq12VscAHE68cbJ1LFBSBq1IZoHzFJp/gs4XThjn/xw7KQe2a0lIuv dCPXikHq+ulIjPiam/9K2BS22mtDxgwvQsSvCjXrWeJbU3vx2cBNP+6S6gHjvbhU+EXQ35 ZpxfXJPyxrX8bCTx6p5p97o1NlB69Dc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=URtqACva; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680710673; a=rsa-sha256; cv=none; b=ABV/8SB4W5RC0kw43ZWYRPHLAi1zw69dfDX9AOtwwofseUakJZtml83VEaYDx2tPwy4gdC QUHz3pjo5rEijn2RjwcA3tdaQMP+RFzD3/iKdGPRU+r4en6ayY6XtkK/dloxGyoZZcckUr jh0FgJmPdHFElSXghrJX1tCTAc0oA9U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TTJqlOzBPX6Z6lfFHUBA0hntJ2NYe0aM0CZZgdoJKu8=; b=URtqACva/lTcYYiZuL1O+kwg1y QIrPTD0MuF3fUmsS/DKkTPr00LMG668SXNEFAA5HNBZnQr5CObVHs5Mayrjkhxnf/ZAY0dkuL5ZI7 9gC86eZMhsdQ0UyfbEUa3/gCGwvwYp0rBBMTN1Ct94hqliLmowjZCYSawZCikgjLE7lpdQraexwPr Bg0VbchgJ3KWLoqEoTtBkcDKtQY++5jdKqaIUPLarmEBw20ri6/O51TSKqwqs5M41ndEKW2sOJhxe wz4xaKIzHHyn1mxRwZmyzZXVTohxvwbtjR+MoXNHI+MYdLwT2x1l+Iqu8IgtREM8F+hbwO/uNrQNv EU7x8Seg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pk5cZ-0053kr-12; Wed, 05 Apr 2023 16:04:27 +0000 Date: Wed, 5 Apr 2023 09:04:27 -0700 From: Luis Chamberlain To: Linus Torvalds Cc: david@redhat.com, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, gregkh@linuxfoundation.org, rafael@kernel.org, christophe.leroy@csgroup.eu, tglx@linutronix.de, peterz@infradead.org, song@kernel.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v2 5/6] debugfs: add debugfs_create_atomic64_t for atomic64_t Message-ID: References: <20230405022702.753323-1-mcgrof@kernel.org> <20230405022702.753323-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 641D620036 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: sp8x9tgx6oqjubpomch8scch5hnz44e7 X-HE-Tag: 1680710673-251595 X-HE-Meta: U2FsdGVkX188XDZ/CxfFKYiBJQc9suwL6cDkOplapxUas3cS2vUBlAy50OTNAiM7ayVSa7LHZVX6ltG+HLveJzcj8LSbdiQX4mmQYB5Rwh94CMKNHUDl7T2WveFC56+DSIXIVMKD/5FRIOUQhudOSzH8nmMEJfD+TB9kAgvSdhgwDtbUB0N7Z2ERCYPTJUa3Kb6tVGda/HFJYl4gBdSnKTqO2Ra1tTKcXp+my5SCFbnGngC4u1+zPojAmKWTtsAB4c4IqAfgu0jQ5P+nvDgyc9TXNXRxpz/d3iiiDyw98J5Zmmk5pawzJBJs6zCg2SwcgwTuwvaqmZqKdG85btfmCq4zq44LEsNMsLcN2kATZL1bS6Rjqjlwhu30sr4f9HiEMgNwhVYXEJUIXucU0xIuWv6CKF53I6s/U5xLCHEBMKb5LNFi19Dg0xlJLfciXh4VP0zp2CJBO+X7HmjbC/HaYNUa73nhmWw7bYiypDz3vo/X/mtOiUweNwfFXWyrBt9/HuG7H4bsi3BNGWDfhorSRGBrlI0q1VUSRLZmWYJEhjwiBPUEdhIhgJJECnbvlqIvv5aDIcOo+P2whZrkuqKfUhcdAZ58CGj/8Md93WjpFXZUUOqNU9Zwecyhk4CHITZgdhbqynphErJ+FPnxmVju8q4KhyVGE5B6/o4r/7jTpID6/f16bkSQN0zt2MwRQookU3nCgdCkh63EiqtcvjBl/Qg4rtZagHeGiwVbnSOGHce3BbV1AKYq1YhE1tDtpVLROub54g+7JnmjDXvz4mBjeDniw+gWJP1mnmUufdzFX5ipEZ88NlBkmXjs4G4Q/eN0Sy4sJa4aGi2jm9mvKrjSN7F/BxYI5vKY9NCZQLQrw3Vc2x7bDrm6OoEQJVzoBIrxQPhgg37r9Y452WqLa66S1wrP7/gYyZj73ftp5nVAuaTXfIz74RIr2aDyo0pH9n6lPSdYtQ+v18zzZW5K6ZT P9N8inmW CuBphzhQtIKPO+Ygbn343DSH4NoubIPT4rl3o5SpetU8Ea2qXAa1U42CPi79g5GLCI/ig2ZvxNuqpfVWtgn9o4vUTOmPsBVnU6MVSWn2EVO2dXW+8xSqyEa6YSL1fo6WEOphVMCywaQMcl4bTRyR/yqM97RmfBHjTLdYTcVUI+QhZBQ9AprKbILLqdvHdFoeSpgxuj2qPkmERf4LVYzwPW5p7Iu/DcGAbH6ySMosOvLqyfcDgvUzOsRtDNI72h3ehA+ZTbluSu73ZMQ3oq0lJefUnIxWS8MSPuHL70izk5LyFcAYH0PZeF01HO2DRDdF1sc7KSSGd6yuo8DUxoNDlkn9vcYGgYa6Ds7jkiD/8cBUkvSD1flnAJ1Z6syiKdykQl9ap6zS8QFFPCJA5IrqrqhTxbMuiSvmA3SWTPt6QKzeyFAnUV42vNumpZC6gRsyuGPs2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 08:26:18AM -0700, Linus Torvalds wrote: > So I realize why you use atomic64, but I really suspect you'd be > better off with just the regular "atomic_long". <-- snip --> > So something like > > debugfs_create_ulong(... &val->counter ..); > > instead of > > debugfs_create_atomic64(... &val ..); > > Hmm? We already have debugfs_create_ulong(), it just uses unsigned long with no atomic_long. I can just use that then. Luis