From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A20C76188 for ; Wed, 5 Apr 2023 15:20:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 965C56B0078; Wed, 5 Apr 2023 11:20:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EED36B007B; Wed, 5 Apr 2023 11:20:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 768906B007D; Wed, 5 Apr 2023 11:20:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 612EB6B0078 for ; Wed, 5 Apr 2023 11:20:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3F03A1C704C for ; Wed, 5 Apr 2023 15:20:07 +0000 (UTC) X-FDA: 80647698054.24.9019DA6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 3460E100013 for ; Wed, 5 Apr 2023 15:20:05 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E44Ex7+X; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680708005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZEt4/fLuqkiy2IaMPsm2XYqAFwxWZjnumwAK7my1HZg=; b=sazJY1B4HYZm/+hSe+66e5wqnu+DNVZvYVaf4EHWlEO0p4bI9kGCldQ3s8n35XhtEEzasB Is3mR8RSjyd3kCyqYBlQ4uoOWs2GzgVCisPEwaWt61xj6wMskblVPWw2tUPTL28EIXfMvT 06vWx4Up+IKxttGhf6xnXVtxKhivLuI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E44Ex7+X; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680708005; a=rsa-sha256; cv=none; b=j1ZzBGo6wRBsSnXvPnPb3V70hQEkDye6C3BaU10tXQfk7ExPQ0Tq0/shDrMhVmxalwoV9t Ud0Y97k2eSYIaCtiRfAPlng4CMFdFPmuWdtTJJkZ/wFjYa5Vocwl8JSrxk4YxIvKD6fvm5 /xBOuxuZYgM84IYPGA089UpRS1Al7mM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680708004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZEt4/fLuqkiy2IaMPsm2XYqAFwxWZjnumwAK7my1HZg=; b=E44Ex7+XaVUdBc2/k8mXe4qzcPeK3RgyHEmuh/A6AVOPwD8/0iyGDtaw7ELlmEJ5Zs9Ivg vv2lM/Ws4aTpI2dx4awnH1WTAobMc/yLwjwR7TKHstTH3A2nUhSXsS/sbU2u5ApxifA7og 9u981tWfMEMWlowvXdYk5vFiLtLkZRI= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-X0b8p3clMNimu0ppum1MWA-1; Wed, 05 Apr 2023 11:17:40 -0400 X-MC-Unique: X0b8p3clMNimu0ppum1MWA-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-3e2daffa0d4so12220261cf.0 for ; Wed, 05 Apr 2023 08:17:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680707860; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZEt4/fLuqkiy2IaMPsm2XYqAFwxWZjnumwAK7my1HZg=; b=kYsgoZD9B6PaXR0XA3t6qeCSY/2ettnQzqcefZumNagjiiCuOfCuVa0NdSEInkiUYw TMvyIKrtgUkq8eKPsJdGXqzm9c35PhGPQ6jial4qn7SfNLAEYWx1tcRiAkyXnbiu/UV2 ZwgPaVo8FoW6kvYKOK8u0ZbmxlfMZU7MkUNK0KF9SM6AOkCFbFMOvXQzTKiB/cNfQbun VJmUEQ1ddwKH2ABI7ZpGz86bKjGPxdQwA2HL94mxDpI9h1DxEJrJB7khZvg3Fzygvh9g YKL7N9+cy+jntv5ebiKmP91IImdubkzBGLDSeI4tg3ZnKFCegdo/dmrTn7w4aETzK9aQ ojsQ== X-Gm-Message-State: AAQBX9dp0aeKwL2PgR53Bl7q56MfKI2GOELbroB9zCpoZS1D7J5CIaF2 U/xXAfb7KtRU0MbQqWsXZNZuZNa0v4/ObyGXrVnzfW7WBDXd3VN/fwZb20nDFgaRhgaT4rfVtfL yYdkJAtfvCPk= X-Received: by 2002:a05:622a:1888:b0:3bf:cf77:a861 with SMTP id v8-20020a05622a188800b003bfcf77a861mr6152064qtc.4.1680707860124; Wed, 05 Apr 2023 08:17:40 -0700 (PDT) X-Google-Smtp-Source: AKy350b8ly/4iMZipfGPm/5Nui6FRqDLTv+FDFgHjQe3RkdJkGSapzzq0IulWhiasRWCt2Y+CphflQ== X-Received: by 2002:a05:622a:1888:b0:3bf:cf77:a861 with SMTP id v8-20020a05622a188800b003bfcf77a861mr6152022qtc.4.1680707859781; Wed, 05 Apr 2023 08:17:39 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id e1-20020a05620a014100b0074a1d2a17c8sm4324729qkn.29.2023.04.05.08.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 08:17:39 -0700 (PDT) Date: Wed, 5 Apr 2023 11:17:38 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Muhammad Usama Anjum Subject: Re: [PATCH v1 0/2] mm/userfaultfd: fix and cleanup for migration entries with uffd-wp Message-ID: References: <20230405142535.493854-1-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230405142535.493854-1-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3460E100013 X-Stat-Signature: bxs37zh8gsiu1hb4edsyfic1dr6adrw5 X-Rspam-User: X-HE-Tag: 1680708005-481058 X-HE-Meta: U2FsdGVkX1+nk3NJjii1mA4mB2OvFKS4DobOhNN1CxUdLWzSZLP0aPQfmOLTrKM0Wjlx3Ca3Nayz1EPAwshiPr4PzxKpFncXDSQKCAUdmS8cUNnK2dqiPG4c/6zp8Ooev+agntP5c9ADJC7C1cKTj1h1h5zmOB22s42PlLlDe2StV7bpmnfrWnTTvkoqE0ekMnd4T6+YjyqsaFjAAUtTcpzPc4IgYPUae8a4y0aQchyBp6O6vtlnEC1z3OmAbCKAF7LqqCknOeJXJtv/q1Ru1AMYN2DFR2nVEIVZqbOz/q1AMk8Yh0OKo31irR7RZ82weun7nXmzNe2EfctQhnX2VaCWL0uPMLP5IVRIUQdBBU5Mn1r5xiLAAJ+1Lxi7jjLDDGqdRQiiB6id7AmTRp+YTOzQSHV7yDRzzYzvRQQTIEt+TGReFlJC2s1vrNsqDnKRD/kEP02VjF4Yp0xvpvumNYWngotE1NuqDq8vIda8tomArBAxU4+pUTxKSSD4fw7ru0sLVzm3U18iJuJG0TlmRxChqwgaRDLqphlotSC7qwT+tJp9VN/8Z2hbB7H+m2U6nki6p+HpRnXiL6LDjrNxlbHqVcoJ/+qeTvZK7B2bsRfE/AIaIEbYkpknwN9HHxXQMmW6wO6VmhbJP+M5kPeREV0nhf/13V/G7xUyFfCOc7Y3X5zs9D60tabu/Sh1nVw9KPuAAWHRzcDoE2fL/WJDtwzDi9F1uk6WwiHbiHBdNSj/PUI5z/lH8f5gPUG84dTLKdDQP05BpzTyaeSlLfGYZqD/4jAh8VevFFAHzp49vK0ysnLWGDsP3F4F0F2ttnbH/xLif6mE6Fn0RX0BP25Nevt90TUr8lynlExiHI/o6OfzffJq5dTBLgNLSndibZO+vkpBTJrxgn8/NWtbSPbCS8W00NmJMwwvoTbDP5tQ0ua84JIkTLAyLWwPM8yEmw11T5/f/6p44XPV55XfaoE QzSWszIk lrJgKSpptKUhpQql3vV53wthGZwQvWvtYM7NMdHZTS5K/mE624zE0NcFOefjdHAEWpW+SzGOeJq6wJE7UUg+OtnCBB9hh/87VJWBLw6b9CaAW96pi3plxlRRg+0YqHI972eSJNMOVNsyWbEvAcI6G/vqasxU88FZAKp3t5t31SOhT1QgmJgOz7hhM/pB9KCbRtxODuENKa0AaiA7sRQKJj8+BTRv87wW1q9Da6U2iqkbKAarY86y9f8ZVkPUiHIWpMaVeWPMF5biZ0hKTdB0voGJTKQHS380Ot14BdfwR7Ob4EKUrS0Zge1sCq/u1e9ahLMo5b5ePm8D2UlQDEQpH3T8/0NXZeBzScVNrlJY/mmlaFO/DgeMuLHUTX4kVD8Oc21Bs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 04:25:33PM +0200, David Hildenbrand wrote: > One fix (I have a simple reproducer but it's too long to paste it into > the commit) I hope the recent rework of the unit test can help having more of these unit tests into the kselftests directly. Currently it's still ugly even after the rework patchset - we'll need to reference e.g. area_dst in unit tests for the allocated memory region (with specified type of either MEM_ANON, MEM_SHMEM, ...), but there's plan to make it even better. Thanks for fixing those already. -- Peter Xu