From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B3CCC7619A for ; Wed, 5 Apr 2023 18:07:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B8ED6B0071; Wed, 5 Apr 2023 14:07:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 169076B0074; Wed, 5 Apr 2023 14:07:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 030646B0075; Wed, 5 Apr 2023 14:07:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E47CB6B0071 for ; Wed, 5 Apr 2023 14:07:39 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BBD801C698F for ; Wed, 5 Apr 2023 18:07:39 +0000 (UTC) X-FDA: 80648120238.08.2F9789F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 5CF00100011 for ; Wed, 5 Apr 2023 18:07:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jAtjuZ4x; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680718058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xSgARidbSrbR51sAvFluXb6jWPhaQNLco18yBBJHCVc=; b=zbmT30k/UmYbDJ7kwFvIrDf6Dthe8DxIhkYXnFglyFaQMZxs4jBgwMnpbWPmwmcyucSz+R +K3dVrfNxygMtAcLKM9qS4JNg4EYvUCwH/K6vdBvFUl9qP5MYoqOzmXGo1phU45SI6/y8Z /U3/PSicKRWbm6eZmcVE8R6fJRKTl6g= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jAtjuZ4x; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680718058; a=rsa-sha256; cv=none; b=DdAdq2fntnXkwK8ysuH2vND0Ej5Lco1D90V72tp+TJND00FyJSLssxek6XLgV9mmoG6jaQ du83G1rkhixRXBnuU5642CFYVaKAt4Bv3ljJ/xhHzarp7zyAOFJSNfNvoKc1kraWiLDYAw a/DpbqSpPA7RB3hKLQCDmGwVCZbFyEY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=xSgARidbSrbR51sAvFluXb6jWPhaQNLco18yBBJHCVc=; b=jAtjuZ4xXNLvq/2JGDp6JgMaoj gAIoMFyE/X0Luo1gp4xQwfMCbfXXYJqs9KJFpC/JPosJaOSEEGBfP7XCFxnSlrdvWabT+1URapyAY Ge81vkvk+tffke1MO4pzti1k1kK2frr3IYnRnvhpdWoSdKsUxxe0KJ0oi+/O0MyVJ6wuuC6Wl9G5a 48O9+qRBJqfsCZyUdsRw8vhrs5DpF6Rp2YgmO8mPl9yHp+2/NjNlQFUTxCMEe8Girj0WbIskqD2N3 98desdq3Sy/t+WLE1UIxIjbP2WCF8vURjMybpg2N0OsD/gvefWtJkoIy3s6uWUv4iIvYgNVyVKon4 B8VONlNg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pk7XN-00GcaF-Hs; Wed, 05 Apr 2023 18:07:13 +0000 Date: Wed, 5 Apr 2023 19:07:13 +0100 From: Matthew Wilcox To: Simon Horman Cc: Sean Anderson , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Geert Uytterhoeven , kernel test robot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Memory Management List , linux-m68k@lists.linux-m68k.org Subject: Re: [PATCH net-next] net: sunhme: move asm includes to below linux includes Message-ID: References: <20230405-sunhme-includes-fix-v1-1-bf17cc5de20d@kernel.org> <082e6ff7-6799-fa80-81e2-6f8092f8bb51@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5CF00100011 X-Stat-Signature: o9q9e6bct737ugk1pmd57cukk7sxa79k X-Rspam-User: X-HE-Tag: 1680718057-546679 X-HE-Meta: U2FsdGVkX1+ChDrrOjCtNGFBhfd2Ji+mesjdyrA1LPSOfM6bSpoHMliaE1ta3L4fpEhdzvSOlXmIAlpYavhgELxOxFJUyzgwLiDiQ/Rn7N696G4q6kS5u/FzDxb0Flneob6+0/no4enTEwVU4GeNzkN5XoY9isVgjjaUx5+xwHbe8rN8KfGYDVqGw+xzZM9KCYmAYpqLhjUFhTUl0bbAAWagvIixNQnWDKags3jb7hxr+8IVbQ/ql4BrGykjBZBiwZ4nDsH2ehYQQORd4iCiQu3oKdNCDmbIfCF8TztGAfE0YZUALY11gCbmxXZcOZy3vaM7Xw0gnhyGKiAcn5WQPhkDlrSTtjhdmK0l9JsnhWtazBYmf7kQ73AaCDpoLczuox6Qm9ov4VAX901L3+j9iDvf/E3CeR/ufoBJz6KwzDi66XaQtt6bK0AtcfMxsHQziMap+KEJ0SSP/a/WD8/GRDzdSWfAxpaG+n5nFfBGA4c7H9K0oQdGLftdY1Y6523AbF3tXU2qzmQlJGejGP9bwVESDSCvaKtMvWzBi+vj6fBkP6J9ZOBH63FnTjPg83kfcnHmoIp5l31vZ1q9p4Lqp0MLQczie/eHXOmt74zgsTAHDESeG/yyEpwzRoEgorYnlVnvBVslygf1ixrYVP0Auyp4ro/oLAXbdWB2xBe8FcVLAHuTJBpv8/mmhL4CKP9HuCeHMpAsghSOgmz3d1jy4KIgytCxJDe9arrXsjBd2UxAeJFKyd3I7acqhsl/HtvkqUGIcqSh/ggQQqH4/YQabIvXxwEXr4UAaQ+kwfVqYS7oiMmZ++baZIEMVTSXYYJrgtAnkiZ1S57oKfz4QIauglKSqyDLmKxV4SSfwhJtwajDMLQnsEiWYGKGKXsl9p+nbxGn9j+O1ZpRo05Ckd1jW/nt7KDh/iLtd3PWDwb83EneEz5xLriJSi9m0pCi9+H7iGc2TbGrGcoARW17wdA O/LUZOze 7624tr8e5P6o0poNYplSJRnn6QebNDyCcy6CjHWPdFKaQvppa5NNOQFEZThB+1bu+s3IHjWvUn7HJ8qyZa9thGLTfeoEDM6jIFq/6p2Q+xK/ZX4IS/dkjAYDby2RFimWDKODyE8zl2N9fVp9PRiTQmqAmkKaL/0x6K6FERt8zJKQMZMFnFFcCJYfk/qkl2Dm5TVohneiIMCX8B6pMy8J4Gfu0BsIrcUOmbwT6R8/yc7udWFY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 08:02:37PM +0200, Simon Horman wrote: > On Wed, Apr 05, 2023 at 01:34:11PM -0400, Sean Anderson wrote: > > On 4/5/23 13:29, Simon Horman wrote: > > > A recent rearrangement of includes has lead to a problem on m68k > > > as flagged by the kernel test robot. > > > > > > Resolve this by moving the block asm includes to below linux includes. > > > A side effect i that non-Sparc asm includes are now immediately > > > before Sparc asm includes, which seems nice. > > > > > > Using sparse v0.6.4 I was able to reproduce this problem as follows > > > using the config provided by the kernel test robot: > > > > > > $ wget https://download.01.org/0day-ci/archive/20230404/202304041748.0sQc4K4l-lkp@intel.com/config > > > $ cp config .config > > > $ make ARCH=m68k oldconfig > > > $ make ARCH=m68k C=2 M=drivers/net/ethernet/sun > > > CC [M] drivers/net/ethernet/sun/sunhme.o > > > In file included from drivers/net/ethernet/sun/sunhme.c:19: > > > ./arch/m68k/include/asm/irq.h:78:11: error: expected ‘;’ before ‘void’ > > > 78 | asmlinkage void do_IRQ(int irq, struct pt_regs *regs); > > > | ^~~~~ > > > | ; > > > ./arch/m68k/include/asm/irq.h:78:40: warning: ‘struct pt_regs’ declared inside parameter list will not be visible outside of this definition or declaration > > > 78 | asmlinkage void do_IRQ(int irq, struct pt_regs *regs); > > > | ^~~~~~~ > > > > This seems like a problem with the header. m68k's asm/irq.h should include linux/interrupt.h before its declarations. > > Hi Sean, > > I do see your point. But TBH I'm unsure which way to go on this one. > Geert, do you have any input? We always include linux/* headers before asm/*. The "sorting" of headers in this way was inappropriate.