From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BDE2C77B6C for ; Wed, 5 Apr 2023 18:02:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D2166B0071; Wed, 5 Apr 2023 14:02:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0831F6B0081; Wed, 5 Apr 2023 14:02:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E653B6B0082; Wed, 5 Apr 2023 14:02:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D20EA6B0071 for ; Wed, 5 Apr 2023 14:02:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 965D5AC870 for ; Wed, 5 Apr 2023 18:02:46 +0000 (UTC) X-FDA: 80648107932.05.4A0197F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id B114A14003B for ; Wed, 5 Apr 2023 18:02:43 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KilFKdOA; spf=pass (imf23.hostedemail.com: domain of horms@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680717763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fXwE0+zHFdl4OMTif9KYAGTXxNF73y0KyIa75fDfMwY=; b=R2GOZhP208y3Kjt3vCEp4Kcc9oH65KyGQL6SfYVYSwY31QkfZkkqyUrV1XE60RlXFdZycw qiDCMlZo2zEDEz02p8PoEl3ZyikcrN/Fn7Q9rHlmfqrqrM1rK0Tnx22Dyw82CkLlZByGXl aElcwiDAUSYGQseAHe0OaZsjNYPmIU0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KilFKdOA; spf=pass (imf23.hostedemail.com: domain of horms@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680717763; a=rsa-sha256; cv=none; b=DsBpRUZ5nT9wTC0zqtBxZmEvDn5w53j5vwM68p7yvLihqMKbnOGcOu4iU5IgdRQJ4batUg s8GYrSQPz9IYztu38PGb6cr8HmIuNywhRap1pRJSZyv7NPQ5uSiCg3UX4fzuABhQJ3E8oY VYieEH9Fq3mZRa1yNCE+zE7stif2QEQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 989A662A85; Wed, 5 Apr 2023 18:02:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F150AC4339B; Wed, 5 Apr 2023 18:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680717762; bh=aT/QSekGZ6qxIVg6oZI+/BJiVR31MMBehvh5nsLZPFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KilFKdOA7T0HZQGoP2XLwDq25p142goZ/oHbpNMBGK9IpA0zYV4Gyf+2kKDtkC/nP Q9zgYC92ZeJpg25z/li0GNKnXn1dWq8qWfYILKLaxgw/bGL1AESipeRQMhFEZPhsjT y4S4XgLmDNbvJdB0saTnL326Waj6PxDTaJXVeUHGO4wFqau0yqpRTuR1mohR4xJbz8 r0GY5a7khnOYg4H4oNnC79QIxeNZZJnHBCO6L2S5QNSDl9nkHF1rScFM/rxluTuV6U fdEIhGZDwmxtBdMrbnYjogBg4YnCwhxmJDmxy9dK7Gl5QPZtbHSpLdfxx3Vrr/IMhT wGnPbfEpS2xpA== Date: Wed, 5 Apr 2023 20:02:37 +0200 From: Simon Horman To: Sean Anderson Cc: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Geert Uytterhoeven , kernel test robot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Memory Management List , linux-m68k@lists.linux-m68k.org Subject: Re: [PATCH net-next] net: sunhme: move asm includes to below linux includes Message-ID: References: <20230405-sunhme-includes-fix-v1-1-bf17cc5de20d@kernel.org> <082e6ff7-6799-fa80-81e2-6f8092f8bb51@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <082e6ff7-6799-fa80-81e2-6f8092f8bb51@gmail.com> X-Stat-Signature: got6hf35crsmqjdodyrgw784kacg99ta X-Rspam-User: X-Rspamd-Queue-Id: B114A14003B X-Rspamd-Server: rspam06 X-HE-Tag: 1680717763-907258 X-HE-Meta: U2FsdGVkX1+8bUOc+Mt8RKXVrFdRRjZzFTJpvDwjf7oooYpCme/1O1zAoWZIqIUIDP/Wf5FYB7zLyXwkmHjbQX7g80eSfqJVGTBGSU7BGeMeDuW3C9E6QYapLLawdrqaRtyXt+U8joWxrEbPwQrUchkOCldsXlBE4pRHcrtJaS320F+I2SO/DYPXjzqML24TvpLfyqA9472dC9VCNDeiO4kfdPDmDPQm/SznVnUk5wdx078SI45jMCshnw3KeoSV8EBMkAIomx7ybK91C42U20EEFfn744MrGtcHTzp1FfCyZw7WkpOhCpY31Sz//3jYOEA6McmwZphyi3mzKzsjpG9qKDqXEl2XT1rD2JRXLysbSOdZMWAfM+U4Mp83RFgUTyN3tzY8Qb2pSgXBfcTraEQGMdC9Tbl4UXHqcnDVuXm6r+LSCEL0Jo8v117pAL2a0rZmSNpQZA9Lk8bIgfZAL7ZcW12JCJDDGoMfFjFf0IU80umQNRr9ZVy6hdgcTjM+/vkDxat0jJ0SNYOJKWqec72o9+sd35shWd8PY4Gigv5sxGhhBoDL5QPH+dkWkE47vX+3qFfoFaVUz2xSoc0pShSSvv1lL0VhF2VS3sVNW7OHB9S6FVoWDl8xT5YtNJTFEycafLIDB5WfToitZBqnePLTbeLJR2/+dKqavpTNtK+SdvrW3Iu78eaPDDyOWNg/1clELlv8/komBQ/6wB96UnWyzyqTBi7zPt/ymnvNl44Xs2n8SV+cxgUfd0bqFDrugWtvG849M9Y74mk88HVeUQ1DuWEQhqE4O028iIfdMadFgWLDnrsj9HQqvjVNfWRNdE0CG6m7sEHLcrEdHhC0q7BPHUBdtZaq+Cu9JsblknnY5PsMoOvhbrzNlzIGuLildDBEVTvjDvwk1GF8WV1U+EwE/Fcfw0az/lRK15NFGX7uuitp6F0vhXsAZrM8ds5uJFpoxYXr5KyQS+rVYwA U2UX5zjG ahLEZH9iP3zmcYqqz9uKV7mZOoFGyQY2qZeZxxaO05UpuqDIu7sKdLmAlPofpis4YEzrK/BeEGDLWwYtWhObmYoEYL8YfBBOa2pa0tSTGo6VRV0SiPKmimvqO2OGX78FbZptC/xjvOW7By8tM2N9OxKA5trE/ZCBwHysiPG1C7TfKZOyfppKC2GRQHfvzeAs2SgQDLADqqUTcsdiF1hDllMgUVef+0dUJIUFruV2LvWhxX7xY+HRPho/hdfDJOAvy/xmDF+Yy3ChstH/w0eZ6SgIR63SzDx88bO5DVT2pBgq5n5SWuLSPR8dipMb6jSPRkpVB6yjcyFWUw+kqbqKF57AKKCB+F/mP/Mps+EURu4moa/V4xZeEDhgkUuEKK1MX1vFqOPKF/rR6Zr4VO+2LoWZbRsfuBxucP75KL0frFBjlYpqKaZ/NtnGOJx2dtyBfleI2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 01:34:11PM -0400, Sean Anderson wrote: > On 4/5/23 13:29, Simon Horman wrote: > > A recent rearrangement of includes has lead to a problem on m68k > > as flagged by the kernel test robot. > > > > Resolve this by moving the block asm includes to below linux includes. > > A side effect i that non-Sparc asm includes are now immediately > > before Sparc asm includes, which seems nice. > > > > Using sparse v0.6.4 I was able to reproduce this problem as follows > > using the config provided by the kernel test robot: > > > > $ wget https://download.01.org/0day-ci/archive/20230404/202304041748.0sQc4K4l-lkp@intel.com/config > > $ cp config .config > > $ make ARCH=m68k oldconfig > > $ make ARCH=m68k C=2 M=drivers/net/ethernet/sun > > CC [M] drivers/net/ethernet/sun/sunhme.o > > In file included from drivers/net/ethernet/sun/sunhme.c:19: > > ./arch/m68k/include/asm/irq.h:78:11: error: expected ‘;’ before ‘void’ > > 78 | asmlinkage void do_IRQ(int irq, struct pt_regs *regs); > > | ^~~~~ > > | ; > > ./arch/m68k/include/asm/irq.h:78:40: warning: ‘struct pt_regs’ declared inside parameter list will not be visible outside of this definition or declaration > > 78 | asmlinkage void do_IRQ(int irq, struct pt_regs *regs); > > | ^~~~~~~ > > This seems like a problem with the header. m68k's asm/irq.h should include linux/interrupt.h before its declarations. Hi Sean, I do see your point. But TBH I'm unsure which way to go on this one. Geert, do you have any input? > --Sean > > > Compile tested only. > > > > Fixes: 1ff4f42aef60 ("net: sunhme: Alphabetize includes") > > Reported-by: kernel test robot > > Link: https://lore.kernel.org/oe-kbuild-all/202304041748.0sQc4K4l-lkp@intel.com/ > > Signed-off-by: Simon Horman > > --- > > drivers/net/ethernet/sun/sunhme.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c > > index ec85aef35bf9..b93613cd1994 100644 > > --- a/drivers/net/ethernet/sun/sunhme.c > > +++ b/drivers/net/ethernet/sun/sunhme.c > > @@ -14,9 +14,6 @@ > > * argument : macaddr=0x00,0x10,0x20,0x30,0x40,0x50 > > */ > > -#include > > -#include > > -#include > > #include > > #include > > #include > > @@ -45,6 +42,10 @@ > > #include > > #include > > +#include > > +#include > > +#include > > + > > #ifdef CONFIG_SPARC > > #include > > #include > > >