From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69885C76188 for ; Wed, 5 Apr 2023 18:34:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA3F76B0071; Wed, 5 Apr 2023 14:34:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A560F6B0074; Wed, 5 Apr 2023 14:34:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 944466B0075; Wed, 5 Apr 2023 14:34:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 834CE6B0071 for ; Wed, 5 Apr 2023 14:34:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 31CA71603ED for ; Wed, 5 Apr 2023 18:34:54 +0000 (UTC) X-FDA: 80648188908.17.06E31F5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 513EB1C000D for ; Wed, 5 Apr 2023 18:34:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DCyahPlM; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680719692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zLDE4ZoYguVkZUfopXXegQvmwG/VwUXglnq6HHV+P+Y=; b=XdoMSnZkUauMfnENXa3nwk5CeIia1LBuVCPHbMxuLpxf8bOGBVZnjMUlyZXoPl47lfeFhv IZR+G47fvfvcMriI/EKQ7XEBCaYsVYhlr7PH7z1Ql7Mhr1COGUeB8nvUhazkLZFKXWZ2m2 3BSfwYh4BDWPVL9/64h2UOJJg4mASHs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DCyahPlM; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680719692; a=rsa-sha256; cv=none; b=SOh8WznX8eUXoPTgT8ytHdBN6BuESXOYLyhSnhRCo63gvBmNyM1VZn1sGkxVHN6qe3cy0G RjRZ//g3ao/aRUeem2zmBj592JZiw2oz4oHitvfpfMYIZnWeGSfOVNYHlQXZ7pCwXFeTDP euzV26yG2NBIZ+D5aJs9K4dr6hC5B/E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zLDE4ZoYguVkZUfopXXegQvmwG/VwUXglnq6HHV+P+Y=; b=DCyahPlMemXXJW9WVuWYyPNpuZ gq9+mZoYQ8kzqpkZsxYwfZOpVGgUEyiVE8z5DDNoHSXJCA3P5Hzag31o5dtv7S0muavNpZG8ZePct AQRMxm1qTzYuC0YAN0ZChu7+yunRJWs2j8mvHqSUFaQWW80I1rCzRdolJCLMhLmrW5h9RJEfRR/E5 uhNKecmk6BgGgmjTnQBiK97HITys87I0PCsChOAThm3mu7uOi6cdfc1ohlaO+y49hpPsJNN3/qyIS o55rN5RFSR+33DzpscxbJG0P0Nz4bPScGoUv2koUEC9plMLgGsYxkvAZBn2OMKWUrw9B4ZGHMtNgC L7ceQsog==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pk7xu-00Gds0-AQ; Wed, 05 Apr 2023 18:34:38 +0000 Date: Wed, 5 Apr 2023 19:34:38 +0100 From: Matthew Wilcox To: Sean Anderson Cc: Simon Horman , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Geert Uytterhoeven , kernel test robot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Memory Management List , linux-m68k@lists.linux-m68k.org Subject: Re: [PATCH net-next] net: sunhme: move asm includes to below linux includes Message-ID: References: <20230405-sunhme-includes-fix-v1-1-bf17cc5de20d@kernel.org> <082e6ff7-6799-fa80-81e2-6f8092f8bb51@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 513EB1C000D X-Stat-Signature: b4okwsy74qneduw6wd746dygkt9rwes7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680719692-244233 X-HE-Meta: U2FsdGVkX18Ez9T3f2PXWBRPqRTM9rcQ6/FNE+GSh0FYwsOGNDLEY/I50F/lj84Uzmq6YILoCDzWrMDTDpoAM/Xe2lz/ZBEZKkpxFnk8gV1xSUJVXYNVuY1b+C+lYbglI6p3ZmJNym+p/8lCM1GxSLYEu3q4LPSIw1V0Or8i7ugR2Djhw/0maQSyt7b2firZ82CGhEfzQxnH1sHIGtESRwWpgYjAHlRfqFeaRjNASrsLVQ4DGC+tWNVkbs2EFIVr0jgJjhTVnjD7SOZfoY8wyLJ8hHZ92+AjWkwVSa7iKnHSlM0EhJuKsraPG097379mzUFRIz2zrpoXuecWSZWSbXTiseln8E4jCw3GXeKiNzRxe/a5HC9ULIpNOYjPQc8Cyziqs76L/DGTqR3qiT/d/5m0/iM0VSdB0OZOEM7uiNYC7ZEeuSo01cQ7NmOzfRhGHGIeRE+In04a6LqTC7hIlzA+ohXzijdn160iKN4w+9eBF9tonhuWeeqT9SIvsaTzaKxSCIrw6SMu9rTYWPIY/6vwqR5ONSyORsUBfcfWLLCcHuPEtZXm2hHAG6PHkkcBkqOiKLYAVL9g4GVTkAs6v7NnLcVWQDW1hWcy0bi9JohSpsOe995uDbwCazlW0B0YGoYJgp8VVG1ef3L94iKHVstDD+rirn2yPd0kuTw6LzrsHSssAjklHuPhN2Rq2hSnhtWLxqb29HAz4TMwXVLOf7fUsmJVEECKleKtwEmSozUpoBeM5Aa/mNVpNpiiri51vuhHFXUemMGu7C7gsBOEOZwWYAkvB/ifr63kCwCgpfES1ps/MV8wmtV4Vj6EG7/WhQbvKcx5noc/x6473rlbjIvkllwtrjsCTWFpN6YfOYHQ5ch3v0fEr+1neITyXYS7SJfjIQleObnS3+X7+gEitdQPSwM18T1WNzkfpEzc09m91xLUdItNFeimgTUa3K+2gOHbleSePlIPExIijJU PFbhWoxr Runsc7QD4uQuKbh1ZnObajtfdQiW6vhj+lC8IwUMNsOqZygESPf3CvQnpxqO7UwvJWcKsBUHqZtPrrCKAafTWawgGxTVxilw/IkF+mVVVqsBGmF5hVgJ+wLCoFRbPXTAXiUel8pXS/hRzBdwYaevmmViSzE85AWuu6kpz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 02:09:55PM -0400, Sean Anderson wrote: > On 4/5/23 14:07, Matthew Wilcox wrote: > > We always include linux/* headers before asm/*. The "sorting" of > > headers in this way was inappropriate. > > Is this written down anywhere? I couldn't find it in Documentation/process... Feel free to send a patch. Generally, it should be: #include #include #include #include #include "local.h" Some drivers do this a different way with a single local.h that includes all necessary includes. Also if and both exist, you should include (which almost certainly includes )