From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F71CC76188 for ; Wed, 5 Apr 2023 12:31:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A540C6B0071; Wed, 5 Apr 2023 08:31:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A03AE6B0072; Wed, 5 Apr 2023 08:31:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CB9D6B0074; Wed, 5 Apr 2023 08:31:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7D9766B0071 for ; Wed, 5 Apr 2023 08:31:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5963AAC733 for ; Wed, 5 Apr 2023 12:31:37 +0000 (UTC) X-FDA: 80647273434.06.2DE450F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 77D93100014 for ; Wed, 5 Apr 2023 12:31:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AG+EZgJ3; spf=pass (imf05.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680697895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/cdLGLSnXQvccgnFgG1xJBIrPcVur36OcBlAnxR18Wc=; b=urArh39kPSbAM2p3iWM6cBPN8RkCEOR6f+mB9ks379IKPKDGFq5UU3l+3p62TPO9Vipbt2 MLi/9Zrsk4P4phC6DsFZgj8+/4kSKFE6eF0E/3LmeuRZ1BaSwb9ayd0w/qkdOVSmRP8zec sjlszP1VkWATXbAWfTl3u9DHEb8q4Vo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AG+EZgJ3; spf=pass (imf05.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680697895; a=rsa-sha256; cv=none; b=Btv+k5aqD1/3fxX4UhkMbPJ7hhx+moplEig3sIz7b0R3C5mQCTt/2UaGJgie71EojgqD7b wLlRSiV44B+vw0ogLPChJ4xdBhWYiUq1E+ldJPwLvIRAZCfW2ZabwU3z0CzQOla8DIsDgf /AkeUs3FiZE68zFqvmP3xK4EVr8SRFM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6FFCC623CD; Wed, 5 Apr 2023 12:31:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CD75C433EF; Wed, 5 Apr 2023 12:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680697893; bh=KFVTrjAz+H5bySuyR2Bq1Khen5yOd1Qtme1Bb1mppYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AG+EZgJ3qAQfgY0+ZZZgyJXsxmcSCxUGOlyF3yG6GA/pNNdu3cJbKH2/4xeHtapHU 8KITD4pBhsc5TvHW50iExblXmcjY2LFFYtY2vLuaXrD78Xnny8GPdwCBy3/l3GEDA2 0PcemdB5uk8CF+tIK2n9GOoxJ4g0SiK4BeLKqvDqZngUI+LayhU+0ydmUGOrgi4PTg g7V2GuESOAJHvh1fLlqU24sPxnckxmjiUEpUAkqPBtJKKYTc+VIwvkkgr4DiAlOo/x wtvmjO3VUP13kxL3k0XI7AZyB4y5ZlMS6zceunb6lXJLe9kn6iYpT27bIMlvkR+NyU VDRnFwdwjQlcA== Date: Wed, 5 Apr 2023 14:31:30 +0200 From: Frederic Weisbecker To: Peter Zijlstra Cc: Yair Podemsky , linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, mtosatti@redhat.com, vschneid@redhat.com, dhildenb@redhat.com, alougovs@redhat.com Subject: Re: [PATCH 3/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to CPUs in kernel mode Message-ID: References: <20230404134224.137038-1-ypodemsk@redhat.com> <20230404134224.137038-4-ypodemsk@redhat.com> <20230405114148.GA351571@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 77D93100014 X-Stat-Signature: kgjboxyyyo597thqb1zmd4ddjnz7teub X-HE-Tag: 1680697895-533197 X-HE-Meta: U2FsdGVkX1/TE28U3Zx8iSjgT+vJ8xDIg2EuGX8k691glpDbPCx44Op1YU1hAGkaZai968cR+Zgp6Ez9N5IsGlG2yGX5EL0vYBaiwHGhlfVVH9N/7iEZfs1QPE2kC6c4tC5V+euq4NDMsDlkFehy4d2JqbRG0uB6Y9bCoAZZJ7FmeWHIFTBSduWWmUlBITdeQOSgwjZVW9CMrHL6zcpdtn/hEQGz7htat8Ht48HKdPjkBQkrPjR5oTPCa8bI7b4v44Ldb678eEqHrgK4U0e723rCu1jY9lS6nePIDMuARwBeL0FUqvT8/whk7Z5q5eJHrV2e9aeHJPjxrYwDBAdeGj4xgWMeEtD79+H+KlNl28wnfShPLaJlfHpWMISiVP1XbCHXVtGBlPCcFM9U/jxfQzobXBbfXVTEaDxN46V1AjkpgGUa13iEMPrJMWc5kwx/soT3kHtKYwviUk0xl0Z9ymHVPwG/0UOy+nBSujSruoKSDUPNeuwhp7nh+KbxG+hXJux7KoYacgCV59Tq32HtDCR8mibgfsmXkulQ694e7XPJVIAXjD5KmI475PpVxlVDPSvz58W5CYRgczw9+QZMigSPrrYlb2GhllaBUD5ZeOhNGdmTK2cAsYuiquRE+3MvwR2AIaNStYJqAl/KOj8TAkUlTB3tOQ02DTkDQfbuZ4/KX89DcwPEc3PxYm9IxpBGOSrhbSQZvFZS+YbmIHr3xTInYXHqz9PwC9HhLffKZylakbdZwPFPKTztPfPdXoDJG+XFC8Mb4QOFQPOf3i27sxcUuuydA/pZcHWd80iGUsytvxvd0tCWAe9U+hsozTZvHvACyboBBIf37TpZmx/Q2fDNNqC9CdIDjjVFaPL9XVtcCrc3Uuf0VNEYCAC8b3eZaWxH+Guk0Jk9ytt8FZRT/JyENCoktGEY/SdZLzFfMA2kZ5qL0zfXC0Hf2KvN7G33xFDxj5UJhcyQBvYdpxQ kaE+8YdE yGu2nAzb8psfPjJbHj7laylVPUTQ6VSWXHXJj7GL8aM+LBvbtXEl5KaB8s3kSJYd/epGpIOiDv4b+lbpMZVIOvSpV0XjbE2rT5xCLNE/RDtqlsb3CCbV8yF3axefo1q3bEnTP9CmTfGuOixhPlsyDu6ihy+QGuTNj/Vqd05eCyqC6I6altl4dbV7DIZf2PR46Gkrx9sgHbyA4sYUqREEzn4pFiwhxw8WQlNT9mSQeell6AYgEeSBPc5h3aE3HUPx68AeuYOQLqocEYcYrY06MAu2bX9FeucLPSsJIF9FTgF+hH3kg0jf/5fGj70v5mHLXWAenvzSAvaq42cHec2yxccxj0Bely1knoZaDrtJSArUssYmFKTmJPzKKvvHqYpb2V4U99yV3xh51YjtyLrTh28teiS10K4FMxzYqw41iDUflyoEbL17UYWrEVWdqARAzWk8R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 02:05:13PM +0200, Frederic Weisbecker wrote: > On Wed, Apr 05, 2023 at 01:41:48PM +0200, Peter Zijlstra wrote: > 1) It has the advantage to check context tracking _after_ the llist_add(), so > it really can't be misused ordering-wise. > > 2) The IPI callback is always enqueued and then executed upon return > from userland. The ordering makes sure it will either IPI or execute > upon return to userspace. *from userspace