From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 650B2C76196 for ; Fri, 7 Apr 2023 10:11:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A9D1900003; Fri, 7 Apr 2023 06:11:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 959B4900002; Fri, 7 Apr 2023 06:11:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82336900003; Fri, 7 Apr 2023 06:11:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 75118900002 for ; Fri, 7 Apr 2023 06:11:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 445FD4129F for ; Fri, 7 Apr 2023 10:11:06 +0000 (UTC) X-FDA: 80654176932.19.C5F3177 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf25.hostedemail.com (Postfix) with ESMTP id AAED8A0006 for ; Fri, 7 Apr 2023 10:11:03 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Wf4r6pJ0; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf25.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680862264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G51SlimsysdJU5GnlmLLgt2RhClRMkcc8o6TRS4K/0E=; b=Bnc31sbLDRKRnBzq1jfM+lhUBAmgaBU0um7i0uOlqrNM9qTmgxQkjCh73K0y5Bv2CKKSsm BvxgwTUzZRZbiGkJn85pQySIwDqICh4z6+jZr0PAMpAdQVgonieU453LTPYMLpfYSj92Tg QQBVju/ReieYnuRJ1srkWJGTex+1+gQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Wf4r6pJ0; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf25.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680862264; a=rsa-sha256; cv=none; b=wwu1DFobZMsR1uYirgh5mzeAUMkipGCYLUuh8Eha0QQEvzozmdU7NFdJqalbART3JLU74U afbojxgqV8pNxF9iClNB6Shr+vVCi3Bu8h/NbVFNz3JZhIClOuZv+E4Hk6Gbx1HT9ZHD0e ZUcpM5vYbjw+D4tQsOx4FJOQvdeSgs0= Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3379AmLD011830; Fri, 7 Apr 2023 10:11:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=G51SlimsysdJU5GnlmLLgt2RhClRMkcc8o6TRS4K/0E=; b=Wf4r6pJ0jIn3cQTTxf9eciZawRfTUu2d1bhUWpU4idiyl13qnis8BpGy7+A0qlQRF6ze MpGoGV8TTUl4XpADYmeWjoJzpgwZ1AgmawxYvJ7dVNgr8MSgcJvK9dOYcwz5QO6E2/2U WQ4Evzi/9I7xQCMDl+nu2paWu66bY4sgj2A1kSDSM1zVeRkv6fXpvlzVOGgMNFEYWlo6 GN5HJf9oXHqlwNh6hBQmJJmkxkj9aVCDle6ed6Q3/Gki+0Uj7kL9R7y4USbmvpbeP4z1 GGKi+Ggvd/3stdl6kGjFoJUHcVARLQRoFbJSUyQG3N+caNrewZuVROCIw+nOFmZo6YRN BA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ptcagdtj7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Apr 2023 10:11:02 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 337A8050007466; Fri, 7 Apr 2023 10:11:01 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ptcagdthc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Apr 2023 10:11:01 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 336FTlia015703; Fri, 7 Apr 2023 10:10:59 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3ppc874w2b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Apr 2023 10:10:59 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 337AAuiA3998388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Apr 2023 10:10:56 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A0ED720067; Fri, 7 Apr 2023 10:10:56 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6E46E20065; Fri, 7 Apr 2023 10:10:55 +0000 (GMT) Received: from linux.ibm.com (unknown [9.171.71.120]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 7 Apr 2023 10:10:55 +0000 (GMT) Date: Fri, 7 Apr 2023 13:10:53 +0300 From: Mike Rapoport To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Andrea Arcangeli , Axel Rasmussen , Mike Kravetz , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit Subject: Re: [PATCH 12/29] selftests/mm: Create uffd-common.[ch] Message-ID: References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160720.3107021-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330160720.3107021-1-peterx@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: kMnuP4zdJ8EnDMbXVgIxC9oFHN25ebHe X-Proofpoint-GUID: 4956bpKZ-3Krxj87g6M5TiY4T-adVsv4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-07_06,2023-04-06_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxlogscore=840 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304070093 X-Rspamd-Queue-Id: AAED8A0006 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: kmw4jqekk99jxinimj51sif56erse99u X-HE-Tag: 1680862263-662875 X-HE-Meta: U2FsdGVkX1+diQ8P2ylE77eS31RlvBizifQmotqsgFapFxHpC6Az6mstap2GMBsWQcgaXfbBxFjRLm8CnKG6sEwhl44d+TAr3ybGtGK1hpOMH5bhybqfV139IbCENyL1DYWPkFPuyfzFQ923IEPeh6hjqIUfVAvh3XxiDgq0RoxwBCiYeVWwvuUkz54g7thWis3MBZErQf9QD57pzhCehhtbHeTCABPH3gxH15BtpYiNdLgS2CGIMLCREhtldiz1C0Ew9bIsV11g8k6MmfqzFouSLohTnNqsTj0jB5glxtEInqxKaCKUZOUehnc1D2MBN7xTH4xRizcrULgWZPdUQIsF2E2U1ArYdLn4N7OKowKbL6gVNjalRrAYpYKsd3Kk85tYs5P61AHSdUBV+Wd8JXC4Jh2VKRURi+yiFpSaRmWN8ZyEijE7XpleGcjA3bqnt1HrNiNN6g1lLiZ3g/5ktzTzcVH4Ehnqv/dp8MHovO+4g6y/hfzs5WJeZMDbpjbNqUmWe0tQere2PIDRF937r8rnrMfLGeKoktMNGoKAkUo2OD8bHRAbDYrXR+GiE5/hJ73Jmao4+gj2W9PCEvo/YNw/3vrf0KILuZvaQf7Ynq90GSLvKFlFHGDylS02kgmmsOdgrK3VbYuVTBtHJsTPIOeCD3ilWBLvEIBVezw7p6PlTaZQICp/zZuDeN51+xTMYUvOj9uGAAtxz7hYvQz6j0oVKVj3zK9j14vQgsmD/c8BNv66jetCXS3qGujEgQ/VD0I38tJU2G6twICWDM0+GuehBu02WZtRG4lGNS5ax3js3FieXlusT/owQv+b5NVeK0C67Ut0OoFCh0EDFbQECu0C5FUk/br6CIN26bzKcJNAv3ZjaQEwDQfYUeAN4OyzdjpMDQB2AXLd8XjI+3H63vn92EF6QnLay8+Xnwh0Oe+18jS8q7E/VxjXyFz6HdG6Di95QJdw4JbZKW0vpi2 SUq3S/AO kdNlIcyKZ4LyrZqqXKebO4GuVgps5US3qHB/SYXYP+SdqP7cvDzusJa6UD6XL21HA5xT8TKZxrL2W0Pkab4YLtmHmp5AxZPRPhPxjnxZN7xzkfO3MH+GFI5QtIVEianvqdSReMHA7jCweAqkBRf9KEkkIrCXqgvMVADSwtg8SwqWVwYwEa9LQrPs4puKKC5Zqif/mnKBCVTTOFdjHnlHLH+ihwZ9gBqh20s7XDnNQCW7jYSl9nbqoYPO7aZy/qu9YlhwtUwC94FY54qboN+xYRL025OMTNJ5ZTQZ0ZA6Kad9bXkc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 12:07:20PM -0400, Peter Xu wrote: > Move common utility functions into uffd-common.[ch] files from the original > userfaultfd.c. This prepares for a split of userfaultfd.c into two tests: > one to only cover the old but powerful stress test, the other one covers > all the functional tests. > > This movement is kind of a brute-force effort for now, with light touch-ups > but nothing should really change. There's chances to optimize more, but > let's leave that for later. > > Signed-off-by: Peter Xu Reviewed-by: Mike Rapoport (IBM) > --- > tools/testing/selftests/mm/Makefile | 2 + > tools/testing/selftests/mm/uffd-common.c | 611 ++++++++++++++++++++ > tools/testing/selftests/mm/uffd-common.h | 117 ++++ > tools/testing/selftests/mm/userfaultfd.c | 694 +---------------------- > 4 files changed, 731 insertions(+), 693 deletions(-) > create mode 100644 tools/testing/selftests/mm/uffd-common.c > create mode 100644 tools/testing/selftests/mm/uffd-common.h > -- Sincerely yours, Mike.