From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBFBCC74A5B for ; Thu, 23 Mar 2023 15:33:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52A516B0078; Thu, 23 Mar 2023 11:33:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D9646B007B; Thu, 23 Mar 2023 11:33:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C7EF6B007D; Thu, 23 Mar 2023 11:33:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2C0936B0078 for ; Thu, 23 Mar 2023 11:33:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F22211A06F2 for ; Thu, 23 Mar 2023 15:33:36 +0000 (UTC) X-FDA: 80600557632.18.73D4045 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 42A55140022 for ; Thu, 23 Mar 2023 15:33:32 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YmTajRSE; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679585613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hi678RG+egR/ohgFkrrnz97rFnnIU7oN844J5N2rULQ=; b=4slHIyuThMP12EAMXxGDOK0h3/dbReooBI/KgWBMGoLliFXQntT9/sWJrYyO9xuZuxPw4h 3BUqyp8fUDj3cLuXJnNZJIJlArIyM5YOWYpWkzw3KHEuZTRxAFRSypKt9h64TWccxqiXAO W1HrLU+CnOu0Ms+RYpdvZghRG/hnjFw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YmTajRSE; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679585613; a=rsa-sha256; cv=none; b=eq2SMvtQFReBZ9AvFEKQCncfd8sxMOGssMWcadLSkHnTGFkWqgDXjMhZJsV2xQ3Fousfyx 1get/aFhKVeIg7UTIDFOtqT4BxXhWgmV/ITkbgBvmLaXFZfR91i+dH4LbYOrsJwuyw9baq 6lsZFX6fPe/FfeJ+r9Gc/zeU8Dcm/NM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hi678RG+egR/ohgFkrrnz97rFnnIU7oN844J5N2rULQ=; b=YmTajRSERctVdDqthoUzk8V1y5 JcXUqGfOrW0uvT2auwRy+Z2MmEoW0In7FSEHQRJgt0bvf7Q3tCok1ZKq2pDmq2U97c/0tltJaxwbC 2aGLHCuAGuY3SPkVcxxp9bnm26fMEdA2JRXCE+lyumGZfi5ycDfcHj+wi+a4CbLYuWjJrLd2piPyy VBj0caG5Ainp0pOxP8pKeTJLVQpzm8DRD2cLbALRn+mEiuYDMIJUr7VcsdxbbazF9Rwh+hIZ2QwCv BF3B32nf5/UtTpuotoi1dQ5nFpqTcinuGimhxlVY5TQ0MuwXj8rtoOpZHe7GZ9FpM6PoQf4gk46Tc OxEUTDXg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pfMwJ-0042qM-6r; Thu, 23 Mar 2023 15:33:19 +0000 Date: Thu, 23 Mar 2023 15:33:19 +0000 From: Matthew Wilcox To: Pankaj Raghav Cc: senozhatsky@chromium.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, brauner@kernel.org, akpm@linux-foundation.org, minchan@kernel.org, hubcap@omnibond.com, martin@omnibond.com, mcgrof@kernel.org, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com Subject: Re: [RFC v2 0/5] remove page_endio() Message-ID: References: <20230322135013.197076-1-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 42A55140022 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: zj7dab8nc5pj6eba9h58xarp3adgomnt X-HE-Tag: 1679585612-850690 X-HE-Meta: U2FsdGVkX19Rp/dfRtqDMO0IrsxpemETM5XcoA1PwkFDlbOtnWuf6EZ6KPxJPfvjSXivKeipHWPXYzROv8oRFIrTrI6/w1VOyyYNi25z2c0uzdAiGdMPJvc9KmCUnI0YZEXJCkcEBWMxtwfNXPJpeB7Hm18/FPGU3uDMAUCUVLuTpmBOIbkO7Pj/svteqTjz0O+7sP8hle8IB6tjGnw8HydSAtSu5C7DpRyqA89m2V9AyuoPxZ7YR0IgJxy3JEpg+k5oV/3n2VpTMbrLuttd09zfUq4fgOpdNXf2CcDX+Ioowd1tlVunhupXxrcZtW9bHH1u965EIQnj6fqNTFPWZlRSmd7LhsxWYNrN35Bk5OtlTuhlDIn+VBf0kaMi9jgi6ByM5+fwNwogGD7u4yYCg9KALE4wKP8aPjc3vZDjVg7qPF+ic4r7I4nWrxKXYNsF7oAmpJ/qJdmcKyNpYAIFJtCJr91wus97pcro8bqGpuWVt8tVeqF78O8/vzanCnxZd5mEigfg8KQmOzRspFtc5qGL9WerGvj1O659Wn4g7ZDx1QsA4ybdpco1RuKdcSoJi+djJgwghZTJQ3d1KKQfvBCw6j7Bf/ETg/Fh/7MvUBJ056y4lzuFxvjfx+v2dNJaAVh84rpUCD1VKYX83U5WflBsvbJ+7CHbcUOFP1BUyVF3XMRtAtbpLpeEuOo3KQV5ngpFR3uuhIEVs8VN/XjY8iTGjdVgTopBzFCr6MOyxc0+AP46Siy9Pq5PuaNPnrgmR6Bi/0NARgJfCNZeAcya+5Fc8skbLBQe8Zhk3Tmzo/Wlv/QJkcatmR7B7JvP/eXVoEkaveoSWh1JI0Z+/8l7LEvDmfnbpBtQ4b/f/tVMl1KsBtuBzt9hYIKj48o8JuciQfs+rrQieDLUt7xhjzq6EK9/Xobp/nLH48a6Fgp2P3rAhNS+s3JeDHNtkXGlkQZhN+hXI5hcx7OCkzqzbRr IZUFySoE 1oCpVcSKlSD7pk9fWnm/o6hEVkbDgRGZei2IUjhu4IJF7oTx3gdCR5+giewZ/sDfu82GnkHzvd4BDUTjb++I2CZ9eCVeYwVLxCQWyZvSoq3lCKVoSHnOTQeWp/E10Yh/IYt/OTNz4DkvCkmY3OfOHQUpFDsg1TC/Akr+wVEr9y1Ipni+DCsyZ56dE0H875zi2/CxV/nXl6cTYdxTKsmyDu7wGr3TEbiJ/qlUB2752sATbvwuJN+S6ClDjfcFShSycPrFqeE5lfXE9d/RqD0IUaCgWnlPdAweTg66WWn04eqwMmS1HDi4akNY8uj5GOqnWVRfz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 23, 2023 at 04:00:37PM +0100, Pankaj Raghav wrote: > > We don't need to set the error flag. Only some filesystems still use > > the error flag, and orangefs isn't one of them. I'd like to get rid > > of the error flag altogether, and I've sent patches in the past which > > get us a lot closer to that desired outcome. Not sure we're there yet. > > Regardless, generic code doesn't check the error flag. > > Thanks for the explanation. I think found the series you are referring here. > > https://lore.kernel.org/linux-mm/20220527155036.524743-1-willy@infradead.org/#t > > I see orangefs is still setting the error flag in orangefs_read_folio(), so > it should be removed at some point? Yes, OrangeFS only sets the error flag, it never checks it, so it never needs to set it. > I also changed mpage to **not set** the error flag in the read path. It does beg > the question whether block_read_full_folio() and iomap_finish_folio_read() should > also follow the suit. Wrong. mpage is used by filesystems which *DO* check the error flag. You can't remove it being set until they're fixed to not check it.