From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 314DCC6FD1C for ; Thu, 23 Mar 2023 10:37:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A96C26B008A; Thu, 23 Mar 2023 06:37:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A46F66B0092; Thu, 23 Mar 2023 06:37:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90F766B0093; Thu, 23 Mar 2023 06:37:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 82BF06B008A for ; Thu, 23 Mar 2023 06:37:27 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4BE6FAB096 for ; Thu, 23 Mar 2023 10:37:27 +0000 (UTC) X-FDA: 80599811334.05.0992789 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 9653D1A001A for ; Thu, 23 Mar 2023 10:37:25 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sPKSP02i; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679567845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8ZNfO5dvrp7J7cTlHB6ZnONex+DPfAa6IFxjZomT6i4=; b=rgTAqQopknqYVXivt48DmHT6zZUTBlxuYnOdIMayIHKLfo1a52OFYKQFtwUlh4eA8bw0SK M0mmEwXzWCYFGY6aIHcT9XMqMfG9rJ2s7qeC7C0txxeVxYxDAlp+SsgHiNccR9DW1Ag5Lj f+3zj473o9oTV4/U4XFaaMuLyfXODFU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sPKSP02i; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679567845; a=rsa-sha256; cv=none; b=tibun6xsWS41JMma36rhGSoVbMD2wHvq+eL40gpwO9gvqDtoYH9CSRBcE5U8WdEiP7TXDB CcRsZJRZom8XwzYZ5NdYdvNrJXvsCvEYGFdvBR1nO4tAz4iCWqKfowW6f/95O3qjvxVEjJ PY856koIOieWpXPNwGVVJeWabF7XOAs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 98F7D62100; Thu, 23 Mar 2023 10:37:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0F9CC4339B; Thu, 23 Mar 2023 10:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679567844; bh=7HVmHyHcaSnCmEQ9wvlGS5D2gJIf2hovuJXSyaCaqdA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sPKSP02iJA6KAFPv7bGM4/Se81vulHnHqt8qfWTUhZFZfE1s7yfVR1WI2haHPg+A3 jWzVvRFZzkglSwote3myrlA5TUDE+Mjiy60hA/JC5FTriwEUlR/LYSMkz7fsTaldFc oMQlw0WTXs+ktUIZkgxUF4A7BhNREJZy9IC+pPvHI8Vsp+m2dbErDE2naZmB571znT Fxiq15cRjtHrw73FO6Y3VXmv90htiJ2rNj1RicLa12inWDP9wSpUycX7R7yd2Kgx+7 vrbS8fMpVelSjMFK/gnOL3tvAHj3UliwBTODwab575ZgUsXBaJnqCJoJygIlhUcZOE OSTuDUXtdmoRA== Date: Thu, 23 Mar 2023 12:37:05 +0200 From: Mike Rapoport To: Catalin Marinas Cc: Andrew Morton , Arnd Bergmann , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , John Paul Adrian Glaubitz , "Kirill A. Shutemov" , Max Filippov , Michael Ellerman , Rich Felker , Russell King , Will Deacon , Yoshinori Sato , Zi Yan , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: Re: [PATCH 02/14] arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER Message-ID: References: <20230323092156.2545741-1-rppt@kernel.org> <20230323092156.2545741-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9653D1A001A X-Stat-Signature: wmyx1znsajdxu9dup8ycd1xhjist9m6n X-HE-Tag: 1679567845-566200 X-HE-Meta: U2FsdGVkX1+4M5ckCX5sr73p5YdwLY0rbOyOv2+ptrs/h5o+ZXD0dDgLs0PGsahymxzqt8aG8oP9MJYuaz6Fok5Fqf7QLP+FEMnOAlwdm+bRGJ0JTETIp3+Vt1pxdaCMKNHYyCtUhqlKY9KIdKrRgE1s4Z3FlLCDR920bUHI8QtfLESlKjG8JE4aPsel/jVxmGUlMkmnw5YABhZdGz2GFh/KlUu/PCu4H8jbWUUeEuJ7YJ0nT4/IaSaGrcq/phfxC1TFl3injbrYY2m0aQ55kera4bGn+vt7vtxV430+wrZ1RbanHGg4bTBno35SU/97G7y1UhcaZlruVNMu55CXqWpnPmLvUfheir+ND0gKGpsNPeC4sMvFmsLYI6cr+v0AIUMKaG57eVuCTIt76hGHJWg4ZXhpiAY9ZGkSQaIN1Xtbq4AXjqfz8vPVcDspsHKGeYytO99pqMunM0cjrKrieDbdY8rfV2tWYX5mNjeIx6wFSJR7EcbP96/ElLUWuwcwsXFTeOmVTwSTebyEgKpJJbU5VYLo2AVNWaJlXRlPHNQX4eKrJ7fmeer8T5JJt45OTLwiEuQAHRbRKPDVAkoG1yWtxl/9b6vf7FxJ5ReKPgy1CAVa3ci1gzFkJ/pvzOy4B5SW1aT+RvNdQdIv/MGOC4yGUOYArcu1WNsVkow4SSZvThe0OLhb3CESwIGZjyMpzqqZODLL6kTKPUB4DMQG7U4KIodMQuZi8fu8MH+rxrr8ZVHU4ZlRE7I/tcyx7k8CaW0eQBRs5X4brd872nVq9xTnwpFnJJUlje42XexqE1nihBoq8vfm8+p9BOCIAbsdZfgvs3c8DMzomSjSrrR+VFlAno0u45Y+dLrtcvG2V3vKWYOF7ZvNKoShs+3/5GOulVa0m/gO3ofECcB+R08FJRM28M0e5orJ+b+QHMbbY3WWC2XUge07jaPULzu3qikxVsi0OREpaz/5wG7v5bv 7jZpHREo qRz36JjTfXdHR0AWT3wHU3AM8uSn5MLmF0UjVcDy4c/uApqd7tF23BspNFlpAExK3fnDUg3s70ZFU+RfZzUQCLUGqduFQ0gGXWoq5nIYSl69zSwSxHhVS4/p8KQQrT0DoCLvU9iRZKjEk/WvRN/G/JttFjg4AOSLrUpHZMwinpk1TGG/pdMzqjKbg3bH/RRHc4RYMLySwDooE+BN9ucy90UeGdnN8WArtEPX23emkQXccY+YUHozrQJBSfq+E4e59b2szn9rtiYspw01hq42201BG8GQBPKN7AKiGuc6j6kXDdxtM5BPfOgX6VrggK+dbtS5vXWNYzm+9xnllcDIi5qGvFimIr+T1DB2UMhYJvLFWMCOyxMGam3HJMvM62nLv8jjk/S7XNtU4E7fwEgslkX+vh+gdtjgi+xlgJOoXZjhZ6nvg0Ies7cXaYpDemx2KaJMwJYnlDcBx5G8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 23, 2023 at 10:15:33AM +0000, Catalin Marinas wrote: > On Thu, Mar 23, 2023 at 11:21:44AM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > It is not a good idea to change fundamental parameters of core memory > > management. Having predefined ranges suggests that the values within > > those ranges are sensible, but one has to *really* understand > > implications of changing MAX_ORDER before actually amending it and > > ranges don't help here. > > > > Drop ranges in definition of ARCH_FORCE_MAX_ORDER > > > > Signed-off-by: Mike Rapoport (IBM) > > --- > > arch/arm64/Kconfig | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index e60baf7859d1..bab6483e4317 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -1489,9 +1489,7 @@ config XEN > > config ARCH_FORCE_MAX_ORDER > > int "Maximum zone order" if ARM64_4K_PAGES || ARM64_16K_PAGES > > default "13" if ARM64_64K_PAGES > > - range 11 13 if ARM64_16K_PAGES > > default "11" if ARM64_16K_PAGES > > - range 10 15 if ARM64_4K_PAGES > > default "10" > > I don't mind rewriting the help text as in the subsequent patch but I'd > keep the ranges as a safety measure. It's less wasted time explaining to > people why some random max order doesn't work. Alternatively, we can > drop the ranges but make this option configurable only if EXPERT. I like the EXPERT alternative more. I'll add it in v2. > -- > Catalin -- Sincerely yours, Mike.