From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5696C6FD1C for ; Wed, 22 Mar 2023 19:10:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 567776B0071; Wed, 22 Mar 2023 15:10:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EFD86B0072; Wed, 22 Mar 2023 15:10:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3909D6B0075; Wed, 22 Mar 2023 15:10:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 25D256B0071 for ; Wed, 22 Mar 2023 15:10:01 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D9BAEA057C for ; Wed, 22 Mar 2023 19:10:00 +0000 (UTC) X-FDA: 80597474160.01.814BE66 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 12869100004 for ; Wed, 22 Mar 2023 19:09:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m6Drqk5n; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679512199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zT4Z2FZu+6Ql6/R+LRqO3MtZ3q6XuLAuf5XIiRjZ61Q=; b=sJtqvFCH8Dr/jjieLp2sBTjQAPyoudMUsDdkNdHXGYoZ1iNqziw1rIyiRcyYmeVY8oxKzc mgMqodh/tN5m+Uu/dYMMcPEdlxSW8ACsAzh1KNOx76CgV0Wrm+IZLu0uoS+hOBwH+5VtDv WT4wxw5rme9Oz1zhUl1yUp3sgHqJgrY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m6Drqk5n; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679512199; a=rsa-sha256; cv=none; b=SHYn0zpj09Hhv65coylchzyF7vtU0weY5gu1amduG8E8hc8WXWtaLt+lGL5sRjJBwLGcym s++DImzJ/V1oyssD8Srm5mh1Jl0UxAw8g9b84z52CbRggd/g3OzHC2/8w/6YpI2kE2pLMn upZdynXaFCZs7Yb+7q12dV1KSXC5HpE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zT4Z2FZu+6Ql6/R+LRqO3MtZ3q6XuLAuf5XIiRjZ61Q=; b=m6Drqk5niIKGUNGVcTAFXs/Lgh MqxegHXmu8VXR13ByAoNnd/K6Aa4o+zE6CtCkoxUN8JbAsqBkv8zpJ0jN7SxuPz5yfll+636mVTEw lIyvB9aQMc37vJ1RvfipcZ3jwG8LTIBEu2zTJrnkvWVKjaDD933JGA4mCYPBh2F71e/GtmBmDMi+D oXbk+n6zvMkTf70nRnb4U+NdZEpA3unSz3aRHW/VvAqhl30Betp4MrCvCRwH7YtoBHwQY0gdKTaHI rlYtf4rZ0Kq9MYPv4tkLMkRDNCZVaVtrXrkIk677QYlbS+u90jMM3rek8xsarrZc+DsBUsD5Yjakx AtvvFqKQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pf3qE-003GWB-Fr; Wed, 22 Mar 2023 19:09:46 +0000 Date: Wed, 22 Mar 2023 19:09:46 +0000 From: Matthew Wilcox To: Pankaj Raghav Cc: senozhatsky@chromium.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, brauner@kernel.org, akpm@linux-foundation.org, minchan@kernel.org, hubcap@omnibond.com, martin@omnibond.com, mcgrof@kernel.org, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com Subject: Re: [RFC v2 0/5] remove page_endio() Message-ID: References: <20230322135013.197076-1-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230322135013.197076-1-p.raghav@samsung.com> X-Rspamd-Queue-Id: 12869100004 X-Stat-Signature: 6h173qntetxdo5sxzqg5mkhg9q83cgmu X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679512198-908143 X-HE-Meta: U2FsdGVkX18PDLVJcnmrhTas90cMz4Iqs7dGXyDGtAvPg6fhQqpcNnjewTS2qBca+haqxw1jSJ7V4lFa8e4gOYNLzxpsZ+ZCABXnxzEq031/gA/gvPG6nngpa8Ju89vXafMmXD8CiW7+B3Wx/LbcFUFxms39ySuJtVZHmAEDHwd0lv7c6sHnAcSrdw4E5svukbeNwPtUlyJMs23UQ751xUWzqAqdAq5SNBhUF4AEqB1k/kEEHot3KECtUUZAMKLezA56pNTE5bMtASi36MvherF2lRC4tcY1oSGIRv4S3XyaRlmWifIdOHPRqAxgeD1z3AzmzlCnWoAMGk2MTzazyr2WUvZKbaMuYU9WJYZ8ZL3vPn/7FZOx+wmASh4S2MJiZACmAAYQRq7Y3a/xxO6o93/yStCCedxx2pZIHJhhWHCc3fRKNoCQRClDIdB8JJnqAhO/U2A9xymvNyY6kS8vfYDqd8ofAAgGfogtXP+L+K5rv/+IRDUlYMpR5f/3LF1YP6AmDum4XKh0RCY1JkiDrhX0o4ZHBJQzeww6FfLX6+yvmF9SiZTEL6F6Vo8nKuFhLTHSPQKewa3b9nxcjg/lfWELEmhEBXU1hxXLfRhx9IGrCl8ChGq0UCnxttmzwg45qqhiMpNQSE1lcSSNTJQcatVdjAV/X8WG8RmIsMmy51sIq7G6b1HwjOzSpCxoftStL4W4WEGBRu7x/D+EyRaKB0fTS9jyPCq/niaWo6hszBFavzBAchejDaBqkAqFb4WaMN6f/aDFQFveqXmRb3LZRoBdSK1o3Tli39CNqk/0GACLpWN8QK9QfOS3LEDhsIuNBIrsRD59A9RbusoJIvaq0N4b+5MICYKjSH18J7PmlNmMT/XmXgxBT3qaRHIldqvKHXaf4Cj47Dy8fMV6Qwy3t8/Ul0V4GrOo+9xwqzFDTBj+/F8a8O7zd6d04fj0FYsN0vR8fVqE+0GguwDnBU8 EosMLlag tSgMuorxsujH3H8+qx8On2ZzIXfS55C0hj5Mzv412avUD8ZmjV+U4agNLgUYxp+YL/X4Y3a7CRv3fPpQ6alUGnQcrQmrYDFAjuJid9c/eN9UgjDF0kVJxgTEPdUFBeXXrG3cLu/ur6/c2ZZLKp3F9v2ux2D8di0bX6sNgi2cTZ+itB6NpCjwR+DA/Fnxi9pwjpAeFUXDs9cvh+Z0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 22, 2023 at 02:50:08PM +0100, Pankaj Raghav wrote: > It was decided to remove the page_endio() as per the previous RFC > discussion[1] of this series and move that functionality into the caller > itself. One of the side benefit of doing that is the callers have been > modified to directly work on folios as page_endio() already worked on > folios. > > mpage changes were tested with a simple boot testing. zram and orangefs is > only build tested. No functional changes were introduced as a part of > this AFAIK. > > Open questions: > - Willy pointed out that the calls to folio_set_error() and > folio_clear_uptodate() are not needed anymore in the read path when an > error happens[2]. I still don't understand 100% why they aren't needed > anymore as I see those functions are still called in iomap. It will be > good to put that rationale as a part of the commit message. page_endio() was generic. It needed to handle a lot of cases. When it's being inlined into various completion routines, we know which cases we need to handle and can omit all the cases which we don't. We know the uptodate flag is clear. If the uptodate flag is set, we don't call the filesystem's read path. Since we know it's clear, we don't need to clear it. We don't need to set the error flag. Only some filesystems still use the error flag, and orangefs isn't one of them. I'd like to get rid of the error flag altogether, and I've sent patches in the past which get us a lot closer to that desired outcome. Not sure we're there yet. Regardless, generic code doesn't check the error flag.