From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A59A3C6FD1F for ; Wed, 22 Mar 2023 15:01:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38EF86B0071; Wed, 22 Mar 2023 11:01:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33DAA6B0072; Wed, 22 Mar 2023 11:01:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2039F6B0075; Wed, 22 Mar 2023 11:01:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0F1AB6B0071 for ; Wed, 22 Mar 2023 11:01:10 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A2A471A041A for ; Wed, 22 Mar 2023 15:01:09 +0000 (UTC) X-FDA: 80596847058.02.A5FB387 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 419BF20020 for ; Wed, 22 Mar 2023 15:01:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JYwOpSXl; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679497266; a=rsa-sha256; cv=none; b=y1ciWZbBC2p3Kdgkc8QPWVeUqCVfDs1ubQDhIXmwGrXrp31O9uyitDDKFy6JcXuXkCqc9a QMyJmWaL7wgWtV3t49jorMqN90NojH3tG+GlauG5PJ1m4gByVnMnXLDb3h7XEXhdODjxDo yFsljmFZ7Gv5AOnX64HzG5yEb4vpA9I= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JYwOpSXl; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679497266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kp5fPX1gvPPIeFHLmOsFNjTNnp1Uka4KqxRqvru50Tc=; b=NLCKy1kvoVeYLqX6+8d3/gLCb1+tcvuNBKUOycNmXcKwBMobKaCjaxAT1PKYgkjjUZZ0au Emv1UsgDkD46Eov0i1tFCUB8npK2ZTC7QS2il8lSk6/rig0k+tWMzoJTM9ZELUOnw8kKZE tPjXpyizgFk3iW9XnzPUDxCtbBfHaR4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E5D556212D; Wed, 22 Mar 2023 15:01:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7036AC433EF; Wed, 22 Mar 2023 15:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679497264; bh=rK4fyj+3bFI3UORG7apfsrTb82JTbZ64Z4g0fMI2vnw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JYwOpSXlIN5RJomg9drFUx2vQ9A1FIwpMJJj+jIZJnC0cpiClSkUb30pJZARvG9NS +wvSQkt0iZp/xLOWqCihJUOjCuNpug1wTHldt2eCzEOZ7WaaQO2Tew4SJCWAm/xA+1 d7ZpLgkCz91H/cmsBzNIEXGLbsOZ/XIg2DdQjLHo5uhaiP6C5XoqkynRV+t02OKvqU ylGiRXI83yigTTWx3DJBU/IvKwUiFIE0AH/rcCqtuP4S8FWRX74PGUvg+PnBqLNAIi OM7KaY0l4ep0U2crJqPBDnDnc/16og4esog0Co2NoXnH1tlBf+F/OXVIp/Px4Gmgwe JQLPAnw8c/6qA== Date: Wed, 22 Mar 2023 17:00:49 +0200 From: Mike Rapoport To: Vlastimil Babka Cc: Andrew Morton , David Hildenbrand , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 04/14] mm: handle hashdist initialization in mm/mm_init.c Message-ID: References: <20230321170513.2401534-1-rppt@kernel.org> <20230321170513.2401534-5-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 419BF20020 X-Rspamd-Server: rspam01 X-Stat-Signature: t6ws6jz66i76etzyatgz9ajoy7d3q8ei X-HE-Tag: 1679497265-490067 X-HE-Meta: U2FsdGVkX1/ulMsrO4zq11hMrUQY5o1Eo+BakoIf3AlQI5SjZUT5gf7XEJnbYzCdPbEE/eZ0nk84tq7xEqmcmK/Yfdx42stdaw0d7TFLY+KJRsFz5uOH+O20thN5rLRwn6j2ncdBKufJtGvgYEe4h08poQXFZQLDUbiQ/2Vey/TUGkYZ354YoiyMXqT3xJBmkfCAzOu6G+hLzlX9gxLw5XeZiwQIg6esrYZc+kpYuUHfcgoWjh7X2mzfXK2+qzQC9/Lpq0qpdUgTqH6teMTO4utjbatrs6GF6DVBaPrzKqhFlQB3yMudZi9S5dsrjkjtxFnKXZSKluQl6ca3JlK20SncX7smH/O7qCXzf9/4848V1CkpPxX7HAXBo86aDYYXCA9k0448fdtas91YL+wf+R2LpC3G9POEt3evsw9E87kGmuyQgUagAo0OF+UEnMMlX9QR7DippfJib1+nXNXpmbq14rGYZ4UPZvamwiwG00IOCnEEQGgEu+bZ6ZNbX8gIqb7G5kIFSeeFW7xGVztQ5hdCwr+yvlR1MjeuNicy8peYOgQes7m3EziSIMP75fSPR14Sl5IOY5n69bvj2+QxsnFljtkmmoA/nLRoizau5Gu6oCbNhopLMABhTHgT+FsbAFZc/zzH5DVJBxBcEqQmRHg9ed00HQAJtttNtZZ0NBHGCS83iT8whQuMAihtLhfOqei1MPggXOw4KqKbmfRCEgYNyoShv5UvSuXilKQoK7vpKtTjYpcm/t4vvY5ypw68uoULyWnygwWx9xlQJlaUf7Ug1mf3xmPfBztikuRecbfsuifDVFcDwA11yd4Mbz5fqaC10mVAzJwk8FHPiJbYTqhtkbgPXQV0xTCn4TVPENJFFZELty6qro0JXNKxAhxAAmezksIRgft/cv4lbr2L498al3VArRwr2aZxgBsZuHR2uS4Vr3IdgvH5xkEsw62Aflyo1e2lXeMhA6t556W O/YSr0h/ c/HZRy4XzqzdO/Lut8WDA5m8JbarfK6w1YrofgRhYR4CRQ9+QC1aITreQLMtrJr820TBF+MkZZJPlRBBlBqnBu9qCU/mF33JZZku21gLqFwZoTCpz7q5AY5ccWKxcqXoPeKamdM0szk143q9ZSZIIKjjesB+dEoZS23JH9TieRDq4tZnPE0598yksyfZ6Yx6mMGq27ejFCm2XBodhmQNWRelxn5vEVRfiDbaQBSVPPWvOd3MzZGgaK7pHWF9kllkDLdBiZRTyqDI8BIMVC5A5CjryINGXDOswoFmazm9QNaiew4LqRxDx53j/SHyLy7TzPxLHu6uMVpEHFLAFCtxt2w6aJs9Hn9xJ6reoOQzXcpKAkvUQ+IigDYfMUD0sw1wfxLkkiBNnm01IMqo7gr62QY4AGc2womE6tDaD+SUHkwjugChK5s//e4hmyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 22, 2023 at 03:49:24PM +0100, Vlastimil Babka wrote: > On 3/21/23 18:05, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > The hashdist variable must be initialized before the first call to > > alloc_large_system_hash() and free_area_init() looks like a better place > > for it than page_alloc_init(). > > > > Move hashdist handling to mm/mm_init.c > > > > Signed-off-by: Mike Rapoport (IBM) > > Acked-by: David Hildenbrand > > Reviewed-by: Vlastimil Babka > > Looks like this will move the fixup_hashdist() call earlier, but can't > result in seeing less N_MEMORY nodes than before, right? hashdist must be set before the first call to alloc_large_system_hash() and after the nodes present at boot time are initialized, so setting it in the end of free_area_init() is Ok. > I wonder if the whole thing lacks hotplug support anyway, what if system > boots with one node and more are added later? Hmm. alloc_large_system_hash() is called really early even for !HASH_EARLY cases. Not sure it's feasible to redistribute the hashes allocated with it when new node is added. > > --- > > mm/mm_init.c | 22 ++++++++++++++++++++++ > > mm/page_alloc.c | 18 ------------------ > > 2 files changed, 22 insertions(+), 18 deletions(-) > > > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > index 68d0187c7886..2e60c7186132 100644 > > --- a/mm/mm_init.c > > +++ b/mm/mm_init.c > > @@ -607,6 +607,25 @@ int __meminit early_pfn_to_nid(unsigned long pfn) > > > > return nid; > > } > > + > > +int hashdist = HASHDIST_DEFAULT; > > + > > +static int __init set_hashdist(char *str) > > +{ > > + if (!str) > > + return 0; > > + hashdist = simple_strtoul(str, &str, 0); > > + return 1; > > +} > > +__setup("hashdist=", set_hashdist); > > + > > +static inline void fixup_hashdist(void) > > +{ > > + if (num_node_state(N_MEMORY) == 1) > > + hashdist = 0; > > +} > > +#else > > +static inline void fixup_hashdist(void) {} > > #endif /* CONFIG_NUMA */ > > > > #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > > @@ -1855,6 +1874,9 @@ void __init free_area_init(unsigned long *max_zone_pfn) > > } > > > > memmap_init(); > > + > > + /* disable hash distribution for systems with a single node */ > > + fixup_hashdist(); > > } > > > > /** > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index c56c147bdf27..ff6a2fff2880 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -6383,28 +6383,10 @@ static int page_alloc_cpu_online(unsigned int cpu) > > return 0; > > } > > > > -#ifdef CONFIG_NUMA > > -int hashdist = HASHDIST_DEFAULT; > > - > > -static int __init set_hashdist(char *str) > > -{ > > - if (!str) > > - return 0; > > - hashdist = simple_strtoul(str, &str, 0); > > - return 1; > > -} > > -__setup("hashdist=", set_hashdist); > > -#endif > > - > > void __init page_alloc_init(void) > > { > > int ret; > > > > -#ifdef CONFIG_NUMA > > - if (num_node_state(N_MEMORY) == 1) > > - hashdist = 0; > > -#endif > > - > > ret = cpuhp_setup_state_nocalls(CPUHP_PAGE_ALLOC, > > "mm/page_alloc:pcp", > > page_alloc_cpu_online, > -- Sincerely yours, Mike.