From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38EA7C6FD1C for ; Wed, 22 Mar 2023 10:09:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B60EC6B0075; Wed, 22 Mar 2023 06:09:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEA476B0078; Wed, 22 Mar 2023 06:09:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98B026B007B; Wed, 22 Mar 2023 06:09:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 84FCA6B0075 for ; Wed, 22 Mar 2023 06:09:11 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 52113140340 for ; Wed, 22 Mar 2023 10:09:11 +0000 (UTC) X-FDA: 80596111302.25.557CBCC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 98EA74000B for ; Wed, 22 Mar 2023 10:09:09 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mBldOBrr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679479749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xlneObjkkCdJZrzS+wZNiLjAe4aUk4X1puUjb1Rc0HQ=; b=MNWol1PAsbA1NHlj0qGZ6W0vqXvMS0sDUO2nPMf2s9B/CZ3MHOZyWw2G4obwbz8mjo8I8s rfWiOqv1/1qxOtdYXcS0zWlDI1yHY6zrTr3jLV+hqQo+TGZyIxJE/ZVDgFdsiXfHS2ORJr MDXYF4RqGWwMJwog3KQf3imtp100+rY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mBldOBrr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679479749; a=rsa-sha256; cv=none; b=A/4Y8ZBr4S0f+thdUVQoYoeQ2wFxuj0yyfFnLPF4omYnTK+zg29xc0I6w+O/Dc8PpxWiRg UFv9LlSau07F/qnsSMKxEUh3nji3HHnibOh2i5gKZW7hC4N5zMYJRDmGL8pDA7+tkurQbd FA+/ZUOLjUAHDSOY5uEIySs3nDyY1JE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A60760A39; Wed, 22 Mar 2023 10:09:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09DA9C433EF; Wed, 22 Mar 2023 10:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679479748; bh=zgcC6CFHZEkI+Y2u0uiAz37vl2FpD8zXEz7zQwJ3YgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mBldOBrrjEJQyxaaZp7OQNB1SSqzEmP3LPBASeMLFq0NxHJmyy8pb62xgPTuT2rrl 6K8u9Y1zqQsnpQNjWOjqedrMPvF8Ypo1JOQyHcV3iZmDCTNcgSenm66S3/vV/eZCe5 NO8+Sg8q0OXzMRCkokx03NpJ38tNXVfmxv4EyRljot5UFqB3fTTN/zABBuocnmCFUO 48I7P+cBAHwLRO0bfnYpe8HnrTETSbOT6/UUrcOQ1MiJgQsljMY/ULuROdwFH/Uy7o f+DA0TznZBkO3xGTPxfNMjQCylCW0GGRUysXlecbKAq2nUlUo0tzBF2nc5vWiaraJ2 MBpKTrjx2sUtg== Date: Wed, 22 Mar 2023 12:08:53 +0200 From: Mike Rapoport To: Sergei Shtylyov Cc: Andrew Morton , David Hildenbrand , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 08/14] mm: call {ptlock,pgtable}_cache_init() directly from mm_core_init() Message-ID: References: <20230321170513.2401534-1-rppt@kernel.org> <20230321170513.2401534-9-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 98EA74000B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: xiwkt3osu6t77n79aucx4iiwu77afcao X-HE-Tag: 1679479749-153892 X-HE-Meta: U2FsdGVkX1/NMxu2gxMmTN6KDVz9/UAxKMHu+fHG6OtNfDOI+PinfHOq7SFZC+mg54X1mMbCVWH/L82wb4afEmNiy94+iqsYgy95JuKH9/nsAzj/bBUAU2cNW/WFjdUy0U4U2c8WmozMTOfOCUwNkJXZ77iGFvCh01MuKA/drRvthHm/cYNz5LEfaDiU+bHhCPS602NarRBbOjreb21oYuuZmvzHE1QECr+5ejJuSgp575Kjh1G9Ncb+QNPbFKOPpKjA1WYftwGtffNHeZbW9CX4VvYPBvZTChhJnDy75Vbk+uim24/CJ3bziW2H9UnFfd89C43QbJUc8fbKagyNLJ5+clZZtCDczecyDoxlc6ghylOY5JD1hIPh2VLrff18b/0oehwSU8M8uIa54efJ5hhUJS42Dgw5/rSmcWmyD/qlAQsXmqO7GNeHbHyVgu/VtMzP7CwR2NFaWQEZyh3P8sBfpIvPiT08Zvu2mzwjpI1nDOiEIM5SSxragc5dtdsAonO+KANY9dvJ/A1xnU69enUERZcAIWaGVpAbeFM/cWgh/ONMp8L5kFm+/xmhpKxMVncGoH3g7l83XVWnl6pS1FKD1fFgjVQ2GofTRyzEdiSMTQZD87L+WzRiwDaAQkaBou18cF5/XM4kHc8/W4aPGf7Op19Uqu096zbpvYEHL7cpeLMsMxrqzlDb73kHqSmDSdYBY2G5HTOgbYXlaTLZWJj8sE0m5Y23vR8GwhpuLl7ykux1fDa+3pHBZyKSdow1/uJt2mSfbyS8cV84Uf404+CDzBWcquKmQUwudkq2Xb+fHHi1Wbu4gKJK23PDlgPjKPSbDg1bSFOaVcS7TNk/pfDoik0c1s4Z8xTx/ECfKuAUr6P8agSJFt5WpvS04HCjEBNncI1SPYO3J5hys0ZwYS6/MUBd8Yu6T+cElrhvY+I14DMNIo1PjMYkmszXYQQumTzDGQXlhNBMLtlQbi9 ZunE4fge yAPEQ5vBtR9NW+bv3Dnj3kTW4B4ITq9EYAw0AcWWg/Maz3Fyh3qvvdvQrhwl/BVksk4fUHeU7yZ9ne+LVAN+QX83929U8/UmuDj75xhPFyXAv7bL1rf0bLzzTlagTpen4L7JQHRH06WiGXmiX1ABdAJcPS0UaboZRUnLwAF1YMOF1GpyZo9Tp3L8lvzptlo9uO7vwaU/5dGovqFS8xrVEev8w/JyRYoHt5YGJGLCg3yN9b1+MbffFj9Ai3e+QVHHVvG66PPIhbwyUg9bZ2iPVNmRw60WGMwqIH87RYvda1EYrKe/ZVs+lbQe5gUCgcTgNWovyD+H72oqUFHVeu5Zeq8oHe3BufzBTFQns7EqDCgTWKU/AIT0yXa1giZk6Yl0/FzTmOl2LQc/Eezz+aPQ1r2OWflf41qdOrTJwl/Nhk28wcjMKmL96qj+QqRO0ew1KA/oa3UVzsunW6+cn2i+8VrMRdMBCZwR7efChN4J0I2Ap8OA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 22, 2023 at 12:06:18PM +0300, Sergei Shtylyov wrote: > On 3/21/23 8:05 PM, Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > and drop pgtable_init() as it has no real value and it's name is > > Its name. oops :) Andrew, can you replace this patch with the updated version, please? >From 52420723c9bfa84aa48f666330e96f9e5b2f3248 Mon Sep 17 00:00:00 2001 From: "Mike Rapoport (IBM)" Date: Sat, 18 Mar 2023 13:55:28 +0200 Subject: [PATCH v3] mm: call {ptlock,pgtable}_cache_init() directly from mm_core_init() and drop pgtable_init() as it has no real value and its name is misleading. Signed-off-by: Mike Rapoport (IBM) --- include/linux/mm.h | 6 ------ mm/mm_init.c | 3 ++- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 2d7f095136fc..c3c67d8bc833 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2782,12 +2782,6 @@ static inline bool ptlock_init(struct page *page) { return true; } static inline void ptlock_free(struct page *page) {} #endif /* USE_SPLIT_PTE_PTLOCKS */ -static inline void pgtable_init(void) -{ - ptlock_cache_init(); - pgtable_cache_init(); -} - static inline bool pgtable_pte_page_ctor(struct page *page) { if (!ptlock_init(page)) diff --git a/mm/mm_init.c b/mm/mm_init.c index bba73f1fb277..f1475413394d 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -2584,7 +2584,8 @@ void __init mm_core_init(void) */ page_ext_init_flatmem_late(); kmemleak_init(); - pgtable_init(); + ptlock_cache_init(); + pgtable_cache_init(); debug_objects_mem_init(); vmalloc_init(); /* If no deferred init page_ext now, as vmap is fully initialized */ -- 2.35.1 -- Sincerely yours, Mike.