From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30818C6FD1C for ; Wed, 22 Mar 2023 08:35:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 931186B007B; Wed, 22 Mar 2023 04:35:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E1096B007D; Wed, 22 Mar 2023 04:35:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A8C96B007E; Wed, 22 Mar 2023 04:35:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 67DF26B007B for ; Wed, 22 Mar 2023 04:35:22 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 07A0B16038C for ; Wed, 22 Mar 2023 08:35:21 +0000 (UTC) X-FDA: 80595874884.20.11D0A08 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id AE1F6180017 for ; Wed, 22 Mar 2023 08:35:17 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NZpopG0w; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+4f74086d64a42785eb88+7150+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4f74086d64a42785eb88+7150+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679474119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=scGQwlZSm2am6XcIFMQR5FAyHspPLWT/pphajCsVLAM=; b=PJIVtb7iysPuIKaXC6DyfcefNSbDVcgGyceonx5jGwKc46tLp8Q2MlzHV6Ou5Hm2OwgCpa 1Qnd9lCKWt4FyJy1wpnvHBNDe3SeNT/Z9QxT0VlNCFoD+kTjebpNZNHzAQa6hpu07ig0ZA I7yVbFNAYzSM8ZYs+RLf9cteHw5obGU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NZpopG0w; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+4f74086d64a42785eb88+7150+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4f74086d64a42785eb88+7150+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679474119; a=rsa-sha256; cv=none; b=Af7t44HfPdF3bp1M4xxr1nn/xhvy52gyvIdNLbR5VcjYPmjYSiMSJasWshSgtiRkrfWWZj Bt1oD+jqqNtCNsJ+SKYaxBXW0quT3qYzmvAnfFxq6ZxdFZe+lN7LLI7eXmN+i6WNUEprfv kLk2bsHAmO29KaL0uQn9MsmyxRMDwFs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=scGQwlZSm2am6XcIFMQR5FAyHspPLWT/pphajCsVLAM=; b=NZpopG0ww/9PG2arH/g8svd+su MkHAA6xnjEz8GvbL4kxv0uBXV0VhiVpROSp+2jUDYy5e+EwUwe9ENwghNvrohKZJ1ENHudSNjOg9I C2OuaWzfhP2vZXkpmvZKizy5PzN+oVn2FTnWfjsZFSmJ8Zga/lt5TTQVzbwhL2lkGEkbNnVYdhUc2 +dxz5m+UDuzxc4Tmclsmt2cWltp7KHWlX9PUs4nw6fHGXJBYsulB8xOUs1RAqsmZYR90pMBI2423/ 8aWjWrMsbbcM6WyQFTRBEFNxMZmzgrF1EaBSz7sM66vEUK+BnYsPh6IDMv/gjFx5LH8V93T9LHbeZ flUJ7Dug==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1petw1-00FCw8-03; Wed, 22 Mar 2023 08:35:05 +0000 Date: Wed, 22 Mar 2023 01:35:04 -0700 From: Christoph Hellwig To: ye.xingchen@zte.com.cn Cc: mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linmiaohe@huawei.com, chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file Message-ID: References: <202303221046286197958@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303221046286197958@zte.com.cn> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: AE1F6180017 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: a8a36mkq1nh6qf3toybb1dh56t81mikc X-HE-Tag: 1679474117-209444 X-HE-Meta: U2FsdGVkX1/Ngx8UpUJZn3b/5B4aiFTAXLMhrcM6+Y9UTH9uPMGzTiTdl1Pc6ZHdcaEiaKCPXVgdgZDM66dp5MIODM8AIafCNsA/EjHGKu3oB5NuKlMqeO5EnsJnL28k/CHcAEDCT+rQPFW/evdmW0ZI4MmImbJGIrhojKkGcFipxUQ6ej90ug4qEo/ef9/GoWTw+vJfWbP31nqTWQHLTL92yGw6xCJ9jOM/ylFeMhNWXKyF5PFWUqiPcMgS2IEPonVWTV1EDtIJmT/Vgq7ek6nEXt4jphLLQdH+90PogQtuWnJUco1y49sbei3SH39dnhV55AQihelgyvBmMG/bkZNWb0JuQDdvLvWeBQwZ9evkvRTEGz0Aiqnk23jg2MIsztxtIwahx0JsdKU0LJ8qfv1qXc7fgYGw2DF/2Zc6+5D9bEVVvvx/j4RRu3ctWumjYKcRUeoo0GJfH1G7kGW9yX164z+7CfoolG+s5n2Rl94G+y7ADBgxoNV/bEzYENqRCOn9YvwnHCKdW2e5fsmm2JQjpq4E3xCK7xpMrbJcVdM5HNJyleylSiDUcsR4fxyDFveiG13LZrmN73ipjA5+fpHGm8V4Dj+kSx/44Eqaxqe/3ttp7GsSriupqDeJ9CgEQf6jIdR9tnUjZ+pQXGVjNo46z69JXXhQtmMWALK/W+lwKuzElh+OQAPtKCqVHstjEJRWna+1HuNVkEPPkm/DYcme4n06pcnPpP/hPKysq2YpFekFIQvA8/PZ0FO7UBy6ve2FhgYLneGQltZmBC4g4EYcJrPtBPZl16w83EWQr51qN2y6ZmnuJWo2Z7tP2y7KhpnyVrdAv2LEmmA+Q5124zviRXq4h5FjAV2QeW7xeO/sTKS3tchjyB9rY3TSoSFovmnAhOC6bIusH8TYdKMFjy0B23Ltg3Hr1Wvf62JM7q1vUdu4mdeWp9Hi2kK2ANqr3FQVeof33+03FKZXLub HaXbZjIY ruT9sCScF/IWLeY10EubrZoXyaeMcZWOHXiBAGWbGiaddqJ59Eb8/HkeiRIaUVhZi4hxT7rnBE1ldf/Wi0LwONGCyUkmVrSh9Sta+Z3V0MTlUNYs5V028882tx6O72t1Y+KFJ66Dq+ECSSBWIyt/iKBeovcSW1ut1gFERPYHQAA5XoVe6tXh1J61Xt//9lxAJewDzuTSZv2+xhiqBAEYX3iAOpQkNbZzkUVYaUeNJ/5q7pDBCuShQDzghLQ33O7dqMa1/XX+2rltcmNMawTg0n9Ps/pL6U6hRPHFJ7uI4UwKajMrIBTYcq1QzDtcCVzNvy90SRnIsz8ClQ4Gn6Wl43I11eXtLnJGhg2Hng0y0nNCbnyA5eNirz229dTnp3eTw3eIInJEh1ILKu1TvZm8Y5Aq3wD8WkQ59AgfymPc8OTW99m1O43T1FysUBa4xAKEKu69I9Kq34/2P+vywkEA+aXnrSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 22, 2023 at 10:46:28AM +0800, ye.xingchen@zte.com.cn wrote: > From: Minghao Chi > > This moves all compaction sysctls to its own file. So there's a whole lot of these 'move sysctrls to their own file' patches, but no actual explanation of why that is desirable. Please explain why we'd want to split code that is closely related, and now requires marking symbols non-static just to create a new tiny source file.