From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71801C6FD20 for ; Wed, 22 Mar 2023 01:24:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCD956B0081; Tue, 21 Mar 2023 21:24:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7D9B6B0082; Tue, 21 Mar 2023 21:24:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6D7A900002; Tue, 21 Mar 2023 21:24:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B940C6B0081 for ; Tue, 21 Mar 2023 21:24:20 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7E9C0A0255 for ; Wed, 22 Mar 2023 01:24:20 +0000 (UTC) X-FDA: 80594788680.21.D7FA064 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id A3C5C180004 for ; Wed, 22 Mar 2023 01:24:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VE53FMB4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679448258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z/QQf3QVrjt4nRAI9fy69GpEwFN8RRRA87OipQJ+EW8=; b=rYLctufGniSr4bSg8yZAcmbNEamQx5ICXteATBrrmMWTV+c2JysOtjthAfYqpVliLQSP64 jMMMFDPBErn9jOAOOWNX6OvdFh96uEagFdvHSALaDRl9SNOKGUkO2d8HuP6IJhCst6WbHE LmodbY+IOcqiDfX46NNNARvQ1kWBwcM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VE53FMB4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679448258; a=rsa-sha256; cv=none; b=Qb63pp3PM09Wv/26hkFQpeaTFeHUXuK/SFkW8uB6nzDlQU0twJA9Z1/vNzwVgVy59lHFcQ A+Tqpu8B+3yYgZiGVR/7cdHKKxBXfFKUP6JLjWcOg63UScjrdOtCd523clz7IVvTv67qQ9 DKJ14S7SdRdajUo9skH55HOVR0zFbMI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679448257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z/QQf3QVrjt4nRAI9fy69GpEwFN8RRRA87OipQJ+EW8=; b=VE53FMB4dDZ7LE5Lc0j415caT4hHOGz0wS8EcT9EUoZa65Td7cjCCt9bnPrQxbmAvTXE1R 5j9BmxzjZGHttcRDwCqmZcsix1QlK2XtlQJFb4R4BFK4fzrqIAVeSCNQaDYf3a7VzSETpO qsVUWoJTvRghc/TSPkFQqR9WNZgOmQk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-392-HE3xuRZAOSCC6xDr7MBnqw-1; Tue, 21 Mar 2023 21:24:14 -0400 X-MC-Unique: HE3xuRZAOSCC6xDr7MBnqw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B71A585C064; Wed, 22 Mar 2023 01:24:13 +0000 (UTC) Received: from tpad.localdomain (ovpn-112-2.gru2.redhat.com [10.97.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5375F492C14; Wed, 22 Mar 2023 01:24:13 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id 521144038A1EC; Tue, 21 Mar 2023 22:20:24 -0300 (-03) Date: Tue, 21 Mar 2023 22:20:24 -0300 From: Marcelo Tosatti To: Tim Chen Cc: Christoph Lameter , Aaron Tomlin , Frederic Weisbecker , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Russell King , Huacai Chen , Heiko Carstens , x86@kernel.org, Vlastimil Babka , Michal Hocko Subject: Re: [PATCH v7 13/13] vmstat: add pcp remote node draining via cpu_vm_stats_fold Message-ID: References: <20230320180332.102837832@redhat.com> <20230320180745.858515310@redhat.com> <93b293341866a4366b2f2a614f8742ca94ff4e3c.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93b293341866a4366b2f2a614f8742ca94ff4e3c.camel@linux.intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A3C5C180004 X-Stat-Signature: uzwmd431twgwppcbcyri57qfknbfhked X-HE-Tag: 1679448258-99105 X-HE-Meta: U2FsdGVkX1/Ie51xCFNagPZ/43Nns0Os2+y3f6bGmD/qvRL+RcSJb7o6JictjDePpzzv+YbgYEB3ea4BTXFsWo4ItnD9v2J0b30CvDKCaEPmGjw10++1KHdxsM43sJDvxDahqkoG2lZszSUfTaYSnuM8spVBbbKeHF+fS7maNtidNKhVsrZdh41riYT1wFclEOBwp9VnUZBFjK6V7gEoL5Mjn9nVPJYe0MBh2++NKyGrnNzjlUPDWWA2Sl4Hsa3JBxoentEHPH6b+44Cg8DfSMk91+Jy+bxgWfv0jlxS9iAvKCRSq09StjLe6BNXFCQYotC0M/OGj83x6fKh+chE0YBJzS5ndel8NRc3NNMb0MBmHDJNOW7b7fZ8SuICjoCjZcrLOBlq9Pqkt7IvSzDOUYbPxQrUjVney82b9QDttD4NNI6J0me4i4IpNWNQ9wn+ZLWeJiv9I9mieSmkIIZ9YLorHoCu1RkIoZHD9DIFphOdGHh4nZqV/ds2MVP3h8bcN+A8OpezIp7dxZjoPG0TlFj3gekentEmQTQbDCnChRX1dMdbnBIrGb9vVs4rrmH1iT7hpMNVDYNeaUVfuhyAavCV3Vymn5mGHrJINpRzWOOdPv3apnsfKL5AQrcl8EY9MEwvBMucNL7/t1gmGgqQFg2oTSrrPLUvVRO4lejk56wZWPIScGmg6pQHaCZcMBe7oIOzN2Onxh8Im0T/03jjAuTZRxpXHNZM5m2zb4uw59+q+zLfRzvzvjEihDtRnfWc7ekwV6MnC9z1ZxbUMWdM/zhxfTC1y0Ztx41Ha2JbsVeKQZE7x0Bu/KozROt1VcKIiIr+RZ0w7uEASX9vCoh7g8eum+8OOkD5wsO4gR2RIwPukjLPzlp3qCspyXZ66ilUHqwOB4Qsvj/zsKXTAxyp4Bf+NoMdZxh1DblYZA504oc7GeHJh2MLTMVlfISETYM5OBX4BaTnxXW7Dz30Bkt DnR7+fbp 2eQfAi4Qp2+Ugm8NuIoDfcdYlnbnvxU2/akEaxu97V94FJhoFrhuPe6OFsKTcLba3ecP96nIZ/XMY+3OtfBsxrc+hl8rxdsUQXjkctULgMCGysy66YcZxOMWWuT3v6TzM3EHaA080XyXywgxlVLhaQxSYV6mdQTKNiA8+RLtWv88wCb9dcFQBnatnlw/GoM4ZQy1RyKhQepjz9FeobAv9biwMHzU+S/1Bzp3h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 20, 2023 at 01:43:09PM -0700, Tim Chen wrote: > On Mon, 2023-03-20 at 15:03 -0300, Marcelo Tosatti wrote: > > > > + > > + if (do_pagesets) { > > + cond_resched(); > > + /* > > + * Deal with draining the remote pageset of a > > + * processor > > + * > > + * Check if there are pages remaining in this pageset > > + * if not then there is nothing to expire. > > + */ > > + if (!pcp->expire || !pcp->count) > > + continue;refresh_cpu_vm_stats > > + > > + /* > > + * We never drain zones local to this processor. > > + */ > > + if (zone_to_nid(zone) == cpu_to_node(cpu)) { > > + pcp->expire = 0; > > + continue; > > + } > > + > > + WARN_ON(pcp->expire < 0); > > + /* > > + * pcp->expire is only accessed from vmstat_shepherd context, > > + * therefore no locking is required. > > + */ > > + if (--pcp->expire) > > + continue; > > + > > + if (pcp->count) > > + drain_zone_pages(zone, pcp); > > + } > > This logic is the same to that for the do_pagesets portion of code in refresh_cpu_vm_stats(). > Is it possible to consolidate to avoid replicating the logic across two functions? > > Tim Tim, One of the versions is for remote access, the other version is for local access (thats why merging the two is not so simple). I suppose the next logical step would be ensure that the current !CONFIG_HAVE_CMPXCHG_LOCAL also uses the cmpxchg remotely (then refresh_cpu_vm_stats can be removed).