From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4B3C6FD20 for ; Tue, 21 Mar 2023 21:42:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 669AD6B0075; Tue, 21 Mar 2023 17:42:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6196D6B0078; Tue, 21 Mar 2023 17:42:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E1A96B007B; Tue, 21 Mar 2023 17:42:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3D8D36B0075 for ; Tue, 21 Mar 2023 17:42:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DA698AAAC7 for ; Tue, 21 Mar 2023 21:42:00 +0000 (UTC) X-FDA: 80594228400.30.A7FBBA1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id DD7821A0010 for ; Tue, 21 Mar 2023 21:41:58 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FAZsJy7S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679434918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eO1WQnfoG/w/cSj2CfnriSK9imFQpojF1RgSiHWE/RM=; b=4mmW76lDoWbkrsABHqahYrOCLOomVGsL9onFqGOnWe+bLX6qBdPO8d3jcCa3xwCN/pyEAA /DMSz+QTIPriM3pU0B9JTgOLp3lC/e9NsjFuPBWyeQe0e+CEI6xBfFlasScajtsvIoJPYs /zdCr4RPvsX/di7RWvGckB+5dCW/+AY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FAZsJy7S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679434918; a=rsa-sha256; cv=none; b=lpfICUI/zooWxJsJxGenlLoLD45tiUK5blZ5kzVfmTSY52IVL117LxKLjwPBL+n1zsC3XI eC3VsU2vhytu5/ADPWRFqMvw59c5SanYBO0s1jqR0mJ67K5ur1rwlS/JTQRId8WgO+L+8W a9GKsaXoZonnDLBI/mymwwd1VgieH/w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679434918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eO1WQnfoG/w/cSj2CfnriSK9imFQpojF1RgSiHWE/RM=; b=FAZsJy7SCZYyW0z9mqG52l+IKtRaB79oWaKjlqvlJiMRpXlGUfxFURze5ptoB5Y0+4r0vP ZJsrecQ+XwCcACWCx6e6SuvdMAUjMwpVYK98ldyKynQ/P/U0+m369VCDnZ8W11P6AG7mRS 5/iBfzliilTd5V/LKKwVOPbJThum/UE= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-0XAwGP7YMXWzSKNA3FH9BQ-1; Tue, 21 Mar 2023 17:41:56 -0400 X-MC-Unique: 0XAwGP7YMXWzSKNA3FH9BQ-1 Received: by mail-qv1-f70.google.com with SMTP id w2-20020a0cc242000000b00583d8e55181so8344262qvh.23 for ; Tue, 21 Mar 2023 14:41:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679434916; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eO1WQnfoG/w/cSj2CfnriSK9imFQpojF1RgSiHWE/RM=; b=Y3QQN9udXW5odrX3i/451mIk5/l8yvML75I35gAx5mJP1cERQcK8687f+e3hAREuvq 2UQlz3iZdc7RXtGrjnldm41w1ojNeg/16yWYN/6kFOm/mOvV6afVJAozkmSiSNfqdYen G8H87swonSVrWEJ84bQVOXRSVwEy2hzg5cXWbkolyFz5jtG19sTzxQQwt/9njdpFd7ui 9KxcZL99D//0gosGNLSXgyOzQ2jTCv6u8icqqgLPsECAedSlDmweBG6qrOpOzi5iCe6S CDM93zEpjwF+p0n+rhzwhq8hpFZl5ghornB4/jEp+y0OMmCMBXHZfvPvVuF/VbrgndQH l83Q== X-Gm-Message-State: AO0yUKU7+2lhaguO9SUUMBi8lOS271b2c4EA14PeaPO25NFfAZf944SA x7Q+r64cmER0pEw7/E4HtUaASqjk2S1hr58WG79RCWte5uz+2Meq7A/oHeLkXRkUpoXKHrCUG9h KSYtuzZ3jucI= X-Received: by 2002:a05:622a:1a86:b0:3e3:7e6b:50ce with SMTP id s6-20020a05622a1a8600b003e37e6b50cemr7071753qtc.4.1679434916345; Tue, 21 Mar 2023 14:41:56 -0700 (PDT) X-Google-Smtp-Source: AK7set/FfoX5c7VWU9K3jawrQuSLuzVqT6mE6nk6j1okuCz1TJRQKy9DJBmpGALs3rdztZmrd62Ggg== X-Received: by 2002:a05:622a:1a86:b0:3e3:7e6b:50ce with SMTP id s6-20020a05622a1a8600b003e37e6b50cemr7071715qtc.4.1679434916056; Tue, 21 Mar 2023 14:41:56 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id c9-20020ac853c9000000b003e37dac7eb5sm2720074qtq.87.2023.03.21.14.41.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 14:41:55 -0700 (PDT) Date: Tue, 21 Mar 2023 17:41:54 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Andrew Morton , Axel Rasmussen , Mike Rapoport , Nadav Amit , David Hildenbrand , Muhammad Usama Anjum , linux-stable Subject: Re: [PATCH] mm/hugetlb: Fix uffd wr-protection for CoW optimization path Message-ID: References: <20230321191840.1897940-1-peterx@redhat.com> <20230321205719.GA6030@monkey> MIME-Version: 1.0 In-Reply-To: <20230321205719.GA6030@monkey> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: DD7821A0010 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: e8qsjbxqpfekugb8cd6jbax5gwos86an X-HE-Tag: 1679434918-502840 X-HE-Meta: U2FsdGVkX1+N/rZ+Rz+hZJYTPKML6+baiXaLoh6rtn/p8nNP7GHG1A9NSIxCrhA4HbHERqL060X+yJXtHaxQ0YMnvvqspYF/GA55RmPtiKkVKoGPks/sfz2LZJ1hR5RXRHx4McctIbuPDu7L19uaS3uoSDqnqHJqoBn62rFRd3FJMKSehFNMe7MQUa3IoKEEGbY83S8iczNd+5dg17RXx7Setr/qQh/211hlUx19yOH9414hIW3rHITTB5dz6ka9qEybQBjVE9KJHVEFg6HrodKYIRi9Yh7GZMU7nKzI0D1/XG/Qd+/2O5YJz0bYsLvGXEprbXHRTlOxeZi+bvMeihDuO1vLyUaxN1mSVwWniyjs/IrMNwh+Nb7B6WUnRAD/sjhLW6fS/D7K1paIea+BAZh5E3GJP+3ULavTJPFYI2Ftry+M90wexjHPgk1UC1ooTuTqE4Wn24fjSMLhPC9qOdZYwjQwhJcevuW4+NGP5obHsIX47r5sBf2uI5lJP985gJw9McGmykP2zSevIh7L6KJcJgI+LMbBN77SZCxjY6kKY/cJWDaZLHIydyGMTpLYDRnH219ULqhS7eGz3vIPfGQtQbiG0c2BbyN7wr/zrhXXae3yqbUqXYuTjUdSbpAkBDvgtwhQFOf+FpO5Jr+2pCO8e2+r+Sj47FVuMILHOt2K5ZGkKo4m7y38AL/nzBzMVgHDsKESK5RhlDonZngwYIA6Qg6ZfoV2BPzYp38UIEqnM5wRcb1dBX56MrJbuIyFjFSjjVh3LK6R722V/4VlCLS6PAz1hYLe8jAmswI/UeQR74qnlzUsFZDYqy2zUwxWuggK8rxw+vIJuLlF4f3xq+TN3mN/q1C2es+dH87qRPKBnAtriozz2ptZCWwvAkLAfjTh+ErSAzhB/gnGNWjf9csxa3JQeMF8j4ny7eWj74lWBfiJijZ+TBKTiQtBuIQmNCg/MddbPSPNZlJEpo7 auOoMQ3v KPAuoavSlKQ0u2oJdFJmW8XhP8KiVwGH6IEQ67B62greUDnTbRFJ/a4xkVk7IkRdzdKvgi2eY+2OQ3SpRE4mimZ6tp6aROdnPmXw4nCHKZ/zHL6AlRqfVHEaM+0Ci8CiwspRzTI2IwHBnwpJ/0sA6hZhX6oBbSn+IXJ0nKWmATzHHkXYfmfKbZEOJbWbLLfoYDXb4fzVW0uOhALpmtDYa28jCp1q+K/RSTprISKnURJZCSO3g1izt7I1YTDzwsP4GxZ3Xp+kZCzTnF0eag68kBopgfQbwkNtfAegohsKAOv6mMxkdQPTNkhBxaG55Wo/4Vu257p8KB5QE+BHsx2ADjupCGJZIy4dHYCo28ygfu53X0hM5vRL+5b5I96Muql0JIcbRQLKp+vAiUrPno7DSaA1mh0CDcvfDSFv0ezYkWaz3LSiAX3oy2RAuRbJ6scfiURd97r8x+Di6GqsdHLrep1AEV2JTEvDLdp++ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 21, 2023 at 01:57:19PM -0700, Mike Kravetz wrote: > > This patch fixes an issue that a hugetlb uffd-wr-protected mapping can be > > writable even with uffd-wp bit set. It only happens with all these > > conditions met: (1) hugetlb memory (2) private mapping (3) original mapping > > was missing, then (4) being wr-protected (IOW, pte marker installed). Then > ^^^^ > Nit, but is the word "then" intended to be there? Almost makes it sound as > if wr-protected was a result of the previous 3 conditions being met. Not intended.. Since this is not fixup-able, I'll reword here when I'll need to repost. [...] > Reviewed-by: Mike Kravetz Thanks! -- Peter Xu