From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C589AC6FD1D for ; Tue, 21 Mar 2023 17:05:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36BF76B007D; Tue, 21 Mar 2023 13:05:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31C5C6B007E; Tue, 21 Mar 2023 13:05:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E4B7900002; Tue, 21 Mar 2023 13:05:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0E9316B007D for ; Tue, 21 Mar 2023 13:05:27 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A4C264016A for ; Tue, 21 Mar 2023 17:05:26 +0000 (UTC) X-FDA: 80593531452.05.6D04B49 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 4A58F1C002F for ; Tue, 21 Mar 2023 17:05:24 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oL42GHvf; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679418324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mlZ22BzkHcBAxERgE3Uqdjrp+hoTQvXKPk+c9ywVxAo=; b=WBxZXRW+9cK9Tn7302pX+/Njm+d52TCY1VqL1KnILRShW9ppXMnFLpQyJ/izJRDK8CIKRF c9Aov63UPHX3TjT6tgmYIqnQBVLoPL8Ot3yUkAV7rPs7wHplHoXwqnmbnTCm3Rbct9pk5t OQHt9v2/CJV0+zUv0ARbAhnTxWXWP8I= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oL42GHvf; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679418324; a=rsa-sha256; cv=none; b=h1HdF5xJqbokA+mDL8TEJSlArfoOQS+uJcPaVBmaM2W0ftAmOSnUOs0Y8GxhuvHldr1XnL rWH8lurDj4857KCTlRkIdlN2QDF80RlDRKEmIdt3SWv5nz+QO/QlQhnvvxVpgENcQ61A0O dGcIMigGLMgMCCCNAGqR7d8GeUnlf9M= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7D484B818F3; Tue, 21 Mar 2023 17:05:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA37AC433EF; Tue, 21 Mar 2023 17:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679418321; bh=Ryw9NYRw0nuNy8NwEf/bKxispBgwhvwn0lTPeZyjXcY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oL42GHvfEsWUzRKNG87NgkvhI1PET29tURiRCoi3ZogYqnWbm/hu/pS6qDRFQsRTF IrwlH3ccAEJZMWzv8IwEwDrfvOg+Sw1pvqvOF0tZ2uHu4KKf4eUdop3LURETFosEST 5J9QmmdKijrNm8eeerFyujJqss1jIbNT6VbeeS9zhc44B5wf5i3Z2fkCQzV+Uq6kI0 Fe5HLROINgDk2gZciIRpZ0oRboIQyR3jOWJ27m+4Clat0MC97n8X03WpiMU/u4e0j6 zS9JjQ/dkqJuFbc7p1AXc9meplxY89qJKy3XH7IKpBeyi2UwkZr8tCYzAayzf1zDgz FVPh29N1B6NDg== Date: Tue, 21 Mar 2023 19:05:01 +0200 From: Mike Rapoport To: Andrew Morton Cc: David Hildenbrand , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 00/14] mm: move core MM initialization to mm/mm_init.c Message-ID: References: <20230321141907.2401089-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230321141907.2401089-1-rppt@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 6wqfuprrtjwiyemwdtziysq7mcokmmp1 X-Rspamd-Queue-Id: 4A58F1C002F X-HE-Tag: 1679418324-821247 X-HE-Meta: U2FsdGVkX1+onNsFBZIMcPEKmFodDN5kg5GqFViKrS//E5OBL7rNPpcg+rvn12aDZP3Y6xQwf9lXhVw2cAyB0r13nhZMmEi0JX7wVuqgUbp4BANTXUIkNwFqlgoVaJtCaFW2hdcdLISoWULrCl0KfxN/KB6ySLW0KES8SzjndIOO7zhV4LBPaS7CkcXT+hjLdRxXEMvHKzYNtBfFQjtx8Pn/4m+X4522/x8Q6BMl5fpLbDaqphg7M0N4lloT5Djdzye3g4de6MiSNfHSnyPbb5ayEM17K6w5aVDbkqbeLQLzjAZMatrXhBQmbwZI9uMUatvcMp85eQfius0B6nnZSmFtgR7Jpshn+MYrdZ3hV0qL9XQ9jyazSuddSG1EjCya0QAA0WHdlXEdbrRB7HBCDO8ar9FdFVhW7kozR63GPVvPwZFZgcVDTBySLfto/C3UnbB58INEne9HBzd84rrJCdijZvDYc4cJyMsW6wDnpR0izxGzt3BE+ntx4pp+xezl+u0iHSLzQl7dPl4f/zqNYn1oqCLI0pIlwC2otEE3blGlqJj/5PBOdvNW6TxPtU+KPPGPWXn1K+LTFfy1WtW3jFF0c7LVsVZLsoZ41VLe2lz+9cu4loDu59M4UGMNylvy/aMc2zT0kE16K62Qdls1aaLMHANivo6fEdZZt77h0/vHMN+oqtkAZzdcJNGg0dZV+LILLqtJd6hy3YUdaWi2jMquTwo3w4EAzYMPKxC6jbHGe4yIy7H2Z7xBUOu4SB/Ujxds/T13ht9mgFgn2PyF7eLo9G4G/C0nKY1Ghv8dAQqkixPoahPxo5ScmvgLJXHlEKjv9PBx1Kmz14QJPPSjP63cCRPaPGJZ6HmFor9iaObwWBCE/n/J6RNl9mTtESl2ZLUQ5SKfrZ0D3FbYr3PJX5uRJ6oRAAc78PqEa2m9bdIThoTuA8AdeiEc0Ycvwl1es5At/DVlYjKntSuVS9+ 28ALC8gm rBe8o67yZ3k2IEwMfoC4zZsqb7gNASiCHnpKQPcApJZ5vHyJIAYNJsow1yUcRESBzhol0oRp7uYDBQoBYT63FPG6lRj7Mhe8cMTLyDo/Pb6vCfBh0iKvjZbvgAhh8N+nXvOr0S05179/FJHOZN+QLnykCCnqBfetOM1xWfHyg27tAV7c1A97IygFfk1XDlojpHALYhVBZXQNEvcvoVLb4YoZq9MGqvWD9b5R1Hw4i/DUcXv8fAep7wq3Agn3Bj1uAM8ll5czRTeBluO43G5XMzMqSEAY4UvpJds37dCwa3uW9LYLwDp0Rxuvvo1U3Rr8ivy/+Lu3AsBcKv2zuKAL+8tQvM7J+tAAhDv35GXvh1dL/RB75cZAJ6sZwqKWvKDq1SMCx89laouCnSHN8L0sOxRPz6T+hiJzc2CIq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Something went wrong, I'll resend the whole set. On Tue, Mar 21, 2023 at 04:19:07PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Also in git: > https://git.kernel.org/rppt/h/mm-init/v2 > > v2: > * move init_cma_reserved_pageblock() from cma.c to mm_init.c > * rename init_mem_debugging_and_hardening() to > mem_debugging_and_hardening_init() > * inline pgtable_init() into mem_core_init() > * add Acked and Reviewed tags (thanks David, hopefully I've picked them > right) > > v1: https://lore.kernel.org/all/20230319220008.2138576-1-rppt@kernel.org > This set moves most of the core MM initialization to mm/mm_init.c. > > This largely includes free_area_init() and its helpers, functions used at > boot time, mm_init() from init/main.c and some of the functions it calls. > > Aside from gaining some more space before mm/page_alloc.c hits 10k lines, > this makes mm/page_alloc.c to be mostly about buddy allocator and moves the > init code out of the way, which IMO improves maintainability. > > Besides, this allows to move a couple of declarations out of include/linux > and make them private to mm/. > > And as an added bonus there a slight decrease in vmlinux size. > For tinyconfig and defconfig on x86 I've got > > tinyconfig: > text data bss dec hex filename > 853206 289376 1200128 2342710 23bf36 a/vmlinux > 853198 289344 1200128 2342670 23bf0e b/vmlinux > > defconfig: > text data bss dec hex filename > 26152959 9730634 2170884 38054477 244aa4d a/vmlinux > 26152945 9730602 2170884 38054431 244aa1f b/vmlinux > > > Mike Rapoport (IBM) (14): > mips: fix comment about pgtable_init() > mm/page_alloc: add helper for checking if check_pages_enabled > mm: move most of core MM initialization to mm/mm_init.c > mm: handle hashdist initialization in mm/mm_init.c > mm/page_alloc: rename page_alloc_init() to page_alloc_init_cpuhp() > init: fold build_all_zonelists() and page_alloc_init_cpuhp() to mm_init() > init,mm: move mm_init() to mm/mm_init.c and rename it to mm_core_init() > mm: call {ptlock,pgtable}_cache_init() directly from mm_core_init() > mm: move init_mem_debugging_and_hardening() to mm/mm_init.c > init,mm: fold late call to page_ext_init() to page_alloc_init_late() > mm: move mem_init_print_info() to mm_init.c > mm: move kmem_cache_init() declaration to mm/slab.h > mm: move vmalloc_init() declaration to mm/internal.h > MAINTAINERS: extend memblock entry to include MM initialization > > MAINTAINERS | 3 +- > arch/mips/include/asm/fixmap.h | 2 +- > include/linux/gfp.h | 7 +- > include/linux/mm.h | 9 +- > include/linux/page_ext.h | 2 - > include/linux/slab.h | 1 - > include/linux/vmalloc.h | 4 - > init/main.c | 74 +- > mm/cma.c | 1 + > mm/internal.h | 52 +- > mm/mm_init.c | 2547 +++++++++++++++++++++++++++ > mm/page_alloc.c | 2981 +++----------------------------- > mm/slab.h | 1 + > 13 files changed, 2856 insertions(+), 2828 deletions(-) > > > base-commit: 4018ab1f7cec061b8425737328edefebdc0ab832 > -- > 2.35.1 > -- Sincerely yours, Mike.