From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA7C7C74A5B for ; Tue, 21 Mar 2023 16:59:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A8EB6B007B; Tue, 21 Mar 2023 12:59:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4320F6B007D; Tue, 21 Mar 2023 12:59:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F9BF6B007E; Tue, 21 Mar 2023 12:59:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1BDCE6B007B for ; Tue, 21 Mar 2023 12:59:52 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D98DAC0145 for ; Tue, 21 Mar 2023 16:59:51 +0000 (UTC) X-FDA: 80593517382.22.F6946F2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf08.hostedemail.com (Postfix) with ESMTP id 2D5F616001C for ; Tue, 21 Mar 2023 16:59:49 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GCVTHQez; spf=none (imf08.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679417990; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bsYvFZRC1l1mRKF8zyfpXpF1SJmmtGNcW5sRV3d5hkk=; b=8Kf4aDbUz2U0NYskwO7lWB2sTZ6dCN17QtAEE0plxnio0ocTolq5wANBeXFLE3bAhUjl/P yHkdxSCPO6XjL/TU30z8WoPZ7aaqgw2HAFlJAn1S4c7huNMNbJIB0vSt/jXhZZWB9pNbYL 1iHkjnjYYiCNNG0R6SgUjPohLZcf204= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GCVTHQez; spf=none (imf08.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679417990; a=rsa-sha256; cv=none; b=4PCvpsiC9TKHO/Lqd1Bs2HV/XM3lFP/RtkYpr1bo5697mm35Mu1y4jZYBfBAt36Xk5KYeK v73txSbRhH09bRcM6pJbCLnEyUU+lID4Jex5HgBom9VEhlpzOG1kWJr6vSNS32FGdK+Gpa F3Qac2+Y1UMiJjnL8Tx8/lSUW5UuISw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bsYvFZRC1l1mRKF8zyfpXpF1SJmmtGNcW5sRV3d5hkk=; b=GCVTHQezRqRcsVVVvIrbaTt/yT BJT5jUwrGLClyeLOLq4qr7qev15AItF0zaqWICUSwgCynez7ntPuyHVZWJDuzfd0r6xLRO8pulvXM 5AHStIwpURNTrOmM6cETzQagUM8L5J5Ye/hSEcJrRkP+u+oPRHx42RE5ZaWOYX8dbpJs/3atLbCBe 1YVMNcXsikjPztrMxDQnYBjslv42yo8EO2u2ePPYCMpWScmfzPq9Bu4ns9jyuO1bMfMpuAKBPGz4G O4JrbXFjHC/b9VzPDsLmRGOvwmtepBGeZgaJhar24bk08CdV8FuMGln0lxlfmdRd7VMGaJJwUYtVV swhE+/uA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pefKm-00D9Yk-26; Tue, 21 Mar 2023 16:59:40 +0000 Date: Tue, 21 Mar 2023 09:59:40 -0700 From: Luis Chamberlain To: Nathan Chancellor Cc: Petr Mladek , Naresh Kamboju , open list , Linux-Next Mailing List , lkft-triage@lists.linaro.org, linux-mm , Andrew Morton , Arnd Bergmann , Anders Roxell , Stephen Rothwell , Steven Rostedt , Naoya Horiguchi , Kefeng Wang Subject: Re: next-20230321: arm64: Unable to handle kernel paging request at virtual address Message-ID: References: <20230321155626.GA3765079@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230321155626.GA3765079@dev-arch.thelio-3990X> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2D5F616001C X-Rspam-User: X-Stat-Signature: ua1idfrrshi6m4xbb5b31h7kqzd3zx8x X-HE-Tag: 1679417989-566011 X-HE-Meta: U2FsdGVkX1/G+pNhnTAzeP8C1GG3pYhzuDQooDVlxh/CgtpyVf3h8KBeBS+ykhKi/LnmrMLMtsEqzTemsiozsGOylLpFzqYg3L71dFzkNd9qOkcseTPQw9fKhxCQtzC/NwW1SQgZ0RW5lGRrenBw8bfgcjMQLFgACa0IgBVPuE7Hg1bY3/Y6ljFfmC2GnLRDNIWh3b+yegEtho6YAv+oX0e8q0lKKbX9eirI2RHdr3OG07ZmOYhjAdmkX+GBURacB2jyxP6amgijG98B5XTNGCzueLptmfkxf1RGiYSMIxcLc7oFGiZCnrVJ2DCN2PAHoXfsyK9pNu9SSYvXcaClktEabVTGoBXriTN357jCHZs6j2B/88I6lG6fwYBS67nWkjmpKYQs0JDPXRUX6FeUKdhj8V5CKihMPF0OPfj7R4vIgYkcuS+FaiSDjtfS5DjKMC8yirxEg9zj1bifF37DLmK5hqQOapZSTKVb+RUHEk5a9FTuYrq1RlgfWcPyi0pLwVH0mbhlK5ki6Bi0MY16i+xuZr8eIXEOjv6NfCeaUW0ztIPPKBV5bbuW4cumg9JM0wRslHFgu24dhQ8WzJ+/C75ZnLkyiV3tqxYa3skGDl0X165m9eSpTvcewFvpvMZMe/UBVtHhDKLIMGnjgCzVxON3zIT29iT+nwhIdvfOXD0LUXyC8SbmJEfIK3nki8xcfMokqSoLDooKb891V/rZDEY/m7XEANyrZ48lfloDLvJm5apfEussGI0wSFS7yBM8XLOVsSbv0odPScCayjjS1usOixPUiHQ6hNVILo2cvyU3OHyaFOXWgVVgzFKs9LvCQhjtBlCwmnkCgXukFlVchwx6saYQkiHtxqFebCNxFl3f730k03loN9vxJRw9H2Vta0gc+Ozbg0WR6hO+vYxX3ATQZb0LhrC1pCviMF6at7EU6o8867BZY3xXlxfScEqMam1DLwwiuy6FQQOolw7 QysNfOxb 7j3Oyr525HXqc0mU/BiUAiZSs/D4Qa2SOgVqiXF5lxqxUOPQSTboPpQIT8aUODyCyPL/MpBIwBU7K5sszkIDQFwwS0IZidy3iprX/BqAeNxC0mJFiygfK10Y8irAdWlkxII3DUEnWIBX1R2VZEYnZZxkcygm2KMBIJ6q7yAimm2girrwpHuym/lIFvxp6q2X+FNuCJTxia0yom3dL0lIzNqvW5HWxFKgFafnhp8BNySuCnko3GYINhQa8bgyvm2iO49OpXBlQsGbAzR8io7zdiCyW2bO/kpshqGjUqroXvjzjx9jN/1HEk/NlKxuS6ooUNO3fFVfejiq0+mfGjk0SdS0vQO2aTN9b5IDBfwNlbl2RdKk5Ii0JmlveeruqWmA9JfLkO5ZLeTZteiGA6nHkfCxAHhwlu+16i0g3sJD7X/RBRku9S8Se4ZYoYPUrV7JwweuKmPK9mFvvF98c24VWfoMMFEPAcRtwEraeKcgmf9EFjU3r582U9N69qEeR034ufaJ4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 21, 2023 at 08:56:26AM -0700, Nathan Chancellor wrote: > On Tue, Mar 21, 2023 at 10:27:02AM +0100, Petr Mladek wrote: > > Hi, > > > > I add Luis into Cc. > > > > On Tue 2023-03-21 11:42:56, Naresh Kamboju wrote: > > > The following kernel crash was noticed on arm64 Juno-r2 and Raspberry Pi 4 > > > Model B on Linux next-20230321. > > > > > > Reported-by: Linux Kernel Functional Testing > > > > > > log: > > > ---- > > > [ 3.071500] Unable to handle kernel paging request at virtual > > > address 0000000000001000 > > > > I guess that this is exactly PAGE_SIZE (4k). > > > > > [ 3.079432] Mem abort info: > > > [ 3.082225] ESR = 0x0000000096000004 > > > [ 3.085977] EC = 0x25: DABT (current EL), IL = 32 bits > > > [ 3.091295] SET = 0, FnV = 0 > > > [ 3.094350] EA = 0, S1PTW = 0 > > > [ 3.097491] FSC = 0x04: level 0 translation fault > > > [ 3.102373] Data abort info: > > > [ 3.105252] ISV = 0, ISS = 0x00000004 > > > [ 3.109089] CM = 0, WnR = 0 > > > [ 3.112055] [0000000000001000] user address but active_mm is swapper > > > [ 3.114230] usb 1-1: new high-speed USB device number 2 using ehci-platform > > > [ 3.118418] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP > > > [ 3.118426] Modules linked in: > > > [ 3.134717] CPU: 1 PID: 1 Comm: swapper/0 Not tainted > > > 6.3.0-rc3-next-20230321 #1 > > > [ 3.142126] Hardware name: ARM Juno development board (r2) (DT) > > > [ 3.148052] pstate: 000000c5 (nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > > > [ 3.155027] pc : string (lib/vsprintf.c:644 lib/vsprintf.c:726) > > > [ 3.158443] lr : vsnprintf (lib/vsprintf.c:2817) > > > [ 3.162196] sp : ffff80000b34b8f0 > > > [ 3.165511] x29: ffff80000b34b8f0 x28: ffff800009d7b1ca x27: ffff80000b34bab0 > > > [ 3.172666] x26: ffff800009d7b1ca x25: 0000000000000020 x24: 0000000000000008 > > > [ 3.179820] x23: 00000000ffffffd8 x22: ffff8000099858a0 x21: ffff80000b34bc30 > > > [ 3.186973] x20: ffff80000b34ba90 x19: ffff80000b34ba98 x18: 000000003c98bfdd > > > [ 3.194127] x17: 000000000000001c x16: 00000000eec48da2 x15: 00000000a9dbdd17 > > > [ 3.201280] x14: ffff80000b0242e8 x13: 0000000057a049ef x12: 00000000cfa47237 > > > [ 3.208433] x11: 0000000000000001 x10: 00000000bd5b8780 x9 : ffff80000812cbec > > > [ 3.215586] x8 : 00000000ffffffff x7 : 0000000000000002 x6 : ffff80000b34ba98 > > > [ 3.222739] x5 : ffffffffffffffff x4 : 0000000000000000 x3 : ffff0a00ffffff04 > > > [ 3.229891] x2 : 0000000000001000 x1 : 0000000000000000 x0 : ffff80000b34bab0 > > > [ 3.237044] Call trace: > > > [ 3.239489] string (lib/vsprintf.c:644 lib/vsprintf.c:726) > > > > This is the line where vsprintf() reads a string to be printed: > > > > static char *string_nocheck(char *buf, char *end, const char *s, > > struct printf_spec spec) > > { > > int len = 0; > > int lim = spec.precision; > > > > while (lim--) { > > ----> char c = *s++; > > > > > > > [ 3.242551] vsnprintf (lib/vsprintf.c:2817) > > > [ 3.245954] vprintk_store (kernel/printk/printk.c:2200) > > > [ 3.249712] vprintk_emit (kernel/printk/printk.c:2297) > > > [ 3.253381] vprintk_default (kernel/printk/printk.c:2328) > > > [ 3.257137] vprintk (kernel/printk/printk_safe.c:50) > > > [ 3.260198] _printk (kernel/printk/printk.c:2341) > > > [ 3.263257] sysctl_err (fs/proc/proc_sysctl.c:1109) > > > [ 3.266577] __register_sysctl_table (fs/proc/proc_sysctl.c:1140 > > > fs/proc/proc_sysctl.c:1383) > > > [ 3.271202] __register_sysctl_init (fs/proc/proc_sysctl.c:1462) > > > > The has been done some reractoring/modification of this code > > by the patchset ("[PATCH 00/11] sysctl: deprecate > > register_sysctl_paths()"), see > > https://lore.kernel.org/lkml/20230302202826.776286-1-mcgrof@kernel.org/ > > > > Luis, does it trigger any bell, please? > > Do you have an idea where this code could pass a pointer PAGE_SIZE > > as string to printk("%s")? > > My bisect actually landed on commit cfe7e6ea5ee2 ("mm: memory-failure: > Move memory failure sysctls to its own file"). The new sysctl table is > missing a sentinel. The following diff resolves it for me. > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 6367714af61d..b2377f12f062 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -143,6 +143,7 @@ static struct ctl_table memory_failure_table[] = { > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE, > }, > + { } > }; Thanks pushed this fix in to sysctl-next. Luis