From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3952BC761A6 for ; Tue, 21 Mar 2023 16:56:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98DF76B007B; Tue, 21 Mar 2023 12:56:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93D636B007D; Tue, 21 Mar 2023 12:56:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DF716B007E; Tue, 21 Mar 2023 12:56:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6B9316B007B for ; Tue, 21 Mar 2023 12:56:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 342EE80120 for ; Tue, 21 Mar 2023 16:56:13 +0000 (UTC) X-FDA: 80593508226.09.E4F7BDE Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 36ECC180017 for ; Tue, 21 Mar 2023 16:56:10 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=EcvwQ4+r; spf=none (imf06.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679417771; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aWRXn4qd7nGpPUiNMqqImVVM3mu78Lrs3TrOsbvgJcA=; b=uzy+0YvJyqT1gVdHcR/a/e0MhcWHKrldO9GCrn2ERjDlVgQXiApyWscJUR1Z5duDC9fs0X XbIq8khoGLBxFgT0lAj2/+rEGLczpjF0jseT4myppHXlMoDyGgDia/wjIwHq473dAWeT/X Q62u/7XXsjpQLKtrf3K3owN8zuZbTeE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=EcvwQ4+r; spf=none (imf06.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679417771; a=rsa-sha256; cv=none; b=xVEdzk/xojNDkM1bnOBILetaV/JbKGYbPgZGhDYttwlt/VHpsHAeVldmsWAD9iGJ0J1ESa HUb5kCXjHMF/bJqk2mponJqSbcb9ivDxz7g3EqlGyGQbGkZ30VuHKKqlDq7bWesv94pN/z JlZhKYI/4rLc0y5qZY0tT6yP/b+phng= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aWRXn4qd7nGpPUiNMqqImVVM3mu78Lrs3TrOsbvgJcA=; b=EcvwQ4+rTdqMikqp4h6IbYe7eq x+/vaeND8+Pnbide5qsQEu7wYbE4sWV7+0lhEEDCDYRV2P022yybUtLmdd5MufQcMXYw1RJ8r16sF sAOns7KcD48sCnMH+KouTPnh2hmZgMDxgUyVMFsNbvgWHWALUWu85iGi2ZUycA8MQWG7U4/aaEjdk fQYCMKCnePPcW9WTTpKSu0A+LWQfKQapAWjYxKLn49WjpJZqxZeSMcsWMxpnWhnJqnuabZ6LBwkp3 YJf7QMmkf3Ash6d1yn/7K7EpJYmaIz3Remo7y74HflrHb7rGRZkPNsJo3E1QkOU9Vk+FU1OxRjjvk Braj4VWQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pefHH-00D91D-2j; Tue, 21 Mar 2023 16:56:03 +0000 Date: Tue, 21 Mar 2023 09:56:03 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: Yangtao Li , Alexander Viro , Christian Brauner , Andrew Morton , Kees Cook , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file Message-ID: References: <20230321130908.6972-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 36ECC180017 X-Stat-Signature: ccdd4fffaqdi6biejbkpwc3g8j9iosea X-Rspam-User: X-HE-Tag: 1679417770-271262 X-HE-Meta: U2FsdGVkX18FvDbwvRVyMnuCW1Ih+RkBWQvU2ABveZ+Itk94DFBzabvCQDAxyP9ykNq6MLwQe8NphVtcwYVU4mq0A2dn9lKY3pCHhhE6ptrAQpiqfZlukn8wdBTYzvrCdZemf8b2SwHoYeohx828yBmrGeTA3WRvfYGiQKpN9NvsOKlHfTYt9u8zMyz10LjaQ6Stj/dOZ7vGdOxN2sNRDxwDmOYr0AGl3BnkXPcetf9V5sbgITbxn/Y/5ZYyShuR6k9lvPE/hp1Jr2bJoSr2zGkNeAdd+KV+QR2sbUYTGBWeiLmwAobcLKctvXoj/KWRX9r0rY4Y/gASd9tariODnc/yUVHlo2OKod1Tb6gdCHR2Ym34fE2/R0f4tpE7AaQIjj/GacE8EHCxRwKbAbWlECMA3NTNnmwUrlWRxejpHvIQrc3ikD18t99gaLgIiNdeZ1YsqAS+xFc1HsDpAlhp4HRso52Nmeup+wwiX1SneAHhLRN76uBnS4R5lVsKNiLMDtiOePFgQqrhq3Sbz19zIsXNTAw477UFPLWeYY10kwdSgymrkJTfdighwBpOCy+zbrm6ntXT7cNpMxIyyfv9lWXD6F2DNyWNcPPeoMw8nCChO3Bw/1J4xGXbcgHRR/EK2Igtb0QL0X/S4vtEWVKs3haNKRm20Or3EEdLdcFnQXqgL6vm6/sHUoZGPPTvo7aUG+WS//OOqsxShn+M+gvKOS3aT74516Hfc0bqXk74fJtuBaoCmnLkHU2fGX74dSCSUVOUetzIgA8P2fve1Ww0/Laanv6Jz6DBAp13ZhSb12NcOouAA/qS2meg9mB/wEqmv3CzHZmMZtRJRM6NPuv5Sogoi2dEoicqgkTYD8B3JHvotMwf/M8aCp2vBWXb/FmyT/PcSY+yEBZYh3CmywcHIWMeXZO0D55OIKguXzN3J0LOBbO0JiPDpJzCIhALELSBH3bgQbZWs1CAG6etUai XZ76lUZ7 4O0sqtZxXvY239tbtliAJJ6Jhzs6f3nd9mTTg4baxuWJJg33HpMArViznkv2FVCSD7d4vl5Rg4CVfhY/CEcBpKMEVkcdwTk3030pZBE+glC/BAUejkyvwufTQyfelH+SaIQm8p+B+UNqk+Qv/HBxE36Ooe/f7MBCZY3/0H9kvWhOjDVNA70scU+AgQraTvsSiR5JQyoJ0v7gXL0x5Nd0bpd8rTJO/tihBmdRzX3Ar/R8/FTZtpAf2I+hPh3I4cWP9N3yRZAsjuu+elXDoqed0OL96P63SIvzvX43QJPUJ3o+yt33w2He9T2yapILPPJzFxGV6PgQSzjo3kZuYpPRRccpmEDC5MNSc4g4ENjLIK8ttjCELPGAINT5rdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 21, 2023 at 04:42:32PM +0000, Matthew Wilcox wrote: > On Tue, Mar 21, 2023 at 09:09:07PM +0800, Yangtao Li wrote: > > +static struct ctl_table drop_caches_table[] = { > > + { > > + .procname = "drop_caches", > > + .data = &sysctl_drop_caches, > > + .maxlen = sizeof(int), > > + .mode = 0200, > > + .proc_handler = drop_caches_sysctl_handler, > > + .extra1 = SYSCTL_ONE, > > + .extra2 = SYSCTL_FOUR, > > + }, > > + {} > > +}; > > Could we avoid doing this until we no longer need an entire zero entry > after the last one? That may be 2-3 kernel release from now. The way to use ARRAY_SIZE() really is to deprecate the crap APIs that allow messy directory sysctl structures. > Also, please post scripts/bloat-o-meter results > for before-and-after. It should be one extry ~ ctl_table per move. Luis