From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814E9C761A6 for ; Tue, 21 Mar 2023 16:42:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F6616B007D; Tue, 21 Mar 2023 12:42:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A6EB6B007E; Tue, 21 Mar 2023 12:42:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 048026B0080; Tue, 21 Mar 2023 12:42:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E4E8B6B007D for ; Tue, 21 Mar 2023 12:42:43 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B610F12018E for ; Tue, 21 Mar 2023 16:42:43 +0000 (UTC) X-FDA: 80593474206.04.ECE80F6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 163BA14000A for ; Tue, 21 Mar 2023 16:42:41 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FhnEeA6H; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679416962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jsbGFAPDCCg1dpVP/wNsQmBc5RaDf7+l5JCSc8t9iVo=; b=KB4UMyt89BbWJocT8mD743DA/0g4nR1cbiOsopgCPHAOU/zLDi48WlTlE20JQqRN9MLd21 Y49yQ6MFztik8z8ahSuUNILIQTmFixm/mNNrngVEnpKY7ZUHtexwN131dYEFTB5i8sktlK puh/8T5dg9LMsXbsyoerXr1yjUaiyf8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FhnEeA6H; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679416962; a=rsa-sha256; cv=none; b=HgqXuHRZpf1UCALuz/rXj/dV6KfNaBGbo4CmbKvPPoeuGMRq02ZLBxNx11db/oDAGk+QRT Dl+K7P3CysH8eODZgOrVgbNYDqS8vX3yVW5ZwKFF3Y5Jzs01tEd0fqC+hlp6OXnKjrxuA6 hFh8CYx1uxziUmCsUPSA46mBW2MopBw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jsbGFAPDCCg1dpVP/wNsQmBc5RaDf7+l5JCSc8t9iVo=; b=FhnEeA6H4LtXOaucATPKvixKkl RYM9VcfEKEv1zcsXDwbruTgihnGwu/d/9AAISum2o32B2CZYg0W//xM1V4aoWZ0u4aPOiYRd+AwJV RTSLEVcH1DLOpMhrHMvFBrk1hmSbgkWGUFD094FO5gTCnQyHxDh9GIg0m95lnWMzk/dQodobrYNKk xMAU9eMId00FGTiOlziX10V0R1leDkMXedb0oyrIE08frrnG1gHxZMQKJAPhnA5WBPuijWS3Yb1Cj fxFgXB10JU2hjdg8AzhphoLvW2D6/bbB5yC2JPDPOgRtWhIxxdvRGAx1a6QX364L05SExMP7BUTol Hqx1+ZZQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pef4C-002CVB-I5; Tue, 21 Mar 2023 16:42:32 +0000 Date: Tue, 21 Mar 2023 16:42:32 +0000 From: Matthew Wilcox To: Yangtao Li Cc: Alexander Viro , Christian Brauner , Andrew Morton , Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file Message-ID: References: <20230321130908.6972-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230321130908.6972-1-frank.li@vivo.com> X-Rspamd-Queue-Id: 163BA14000A X-Stat-Signature: fcsqzb33gzkuhfxpqfpi4zucif3ht7wk X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679416961-138669 X-HE-Meta: U2FsdGVkX18CbnyQunV4ZNOoIZQW/lBLY2tkGT6RqoxDG9g3BmaCUUE3pqI2biGtmyoPUsQ2wCgEBFOFieXcZ1aYqlVQaX4ldpPukrlZmXN4e6oLcJG7/RZ5NMX0rNqFmKGcVbrGWIE/OhXoPqqFnB1oe/x4rfwKR/CmcKN/+cGINXdzbkQ9B7hzvocFIo3iqaWSV/5Gjc2Up5gn+ClHYfZ3p3IO1hegwOw7J1aMUYmWX/R1wgRovDjpuiq7zkjGiNrkgBpakXEeQ8h5Ailwen+uD8xbVUnJfSleR9LxqMQs+wRe8EWrY6XY/GvqIhR4MFmX+c+bZXF5LuDfeQ0F1us/Jn6CaT5+/GcLFHQZyGHYUnHU73BFvecuz3hHyQjAvtnLKmVQo1nT1VAn8USMh5Mfsyw6xcuXQpRx31Ha6qxHyzvUPAbWnzI0/MUcaTFAf+5Kt7Le9q6Q04dBpokxS5kVLgzyWcqowPy4PN/ZJj4IiN0sDh/C9CrGgmAd0rG+BFg2zP1qkoZPLN3oDBr4rw6GwxBXt9PqJIVzzR2TDADnpgBMg/XfKBmUJSJTl5R+PAsNLQt9WKaq7b3JP4efMCnYweknfLtivZxCcFQX5wzFj2xbDX2HQBvZeG/ebOINPbOeuWUEyKiqQ3feKx228ydhXj1gzaq1KFN5Emcjynh1OtltO33phyQyczHpBZtXI4s3+Oyvz7LkAvuaDgZxd10hm6rO6j+DwsH8mBM4M+CD4ION4hwArwpt7/6tlER2Sqr8iYgmRi+uEQlxGOmqUsH6VfLpIeewezUndwvmM8oZkO4k183S2L7MTjDVJMBxli6gwUoLYgYr2PytfK5igMO5omVHiBeude8ttTAW+2wGoeOdbOqIpSP7vwrnpQ/+4ydMxyV1h4xS3lCA7wMmeCYjNmBMbBzD6wS+Mb6k73xYwVltYQqJyMPxBK8Vn1UR9cvok9qRYGQskOJ6Jrs ZKWqsvnA Iacwu6VnfV2HdIt965gzxqAZ2rusGBvMwwBf79xrq9nlf9bdii33SJhxvTx6tXza/Ai+Q9LPJ/VvXHLXoqp4EWMZA9n6IrurzSqe0I0tA64uAvAMoChrF2sEIKq2W+OLFRgmBvruUh/ib4u1poza6NynqIu9bNzn9/LxBEjv9Ynqd0Bhn8nrwBruxeb/mNDgJnjv1BcNqEb/vIb4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 21, 2023 at 09:09:07PM +0800, Yangtao Li wrote: > +static struct ctl_table drop_caches_table[] = { > + { > + .procname = "drop_caches", > + .data = &sysctl_drop_caches, > + .maxlen = sizeof(int), > + .mode = 0200, > + .proc_handler = drop_caches_sysctl_handler, > + .extra1 = SYSCTL_ONE, > + .extra2 = SYSCTL_FOUR, > + }, > + {} > +}; Could we avoid doing this until we no longer need an entire zero entry after the last one? Also, please post scripts/bloat-o-meter results for before-and-after.