From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D897C6FD1D for ; Tue, 21 Mar 2023 16:42:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB6A36B007B; Tue, 21 Mar 2023 12:42:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3FBB6B007D; Tue, 21 Mar 2023 12:42:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C07D06B007E; Tue, 21 Mar 2023 12:42:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AC13E6B007B for ; Tue, 21 Mar 2023 12:42:16 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7E27F40152 for ; Tue, 21 Mar 2023 16:42:16 +0000 (UTC) X-FDA: 80593473072.01.6413019 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 9C13E20003 for ; Tue, 21 Mar 2023 16:42:14 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RBr90U8d; spf=none (imf13.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679416934; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ZSrO5HfUDDvVDUVlIZHkBuyCCML2UkxvJRJ9KEJLhk=; b=1c+/MRWmnSOz5/uc23RUpBI2UNclQ0LvuJxYWGDUkUddV7c00nkC2bxyW1zUYayaSjxMWh VNJ6XAbcjev9Rf+EYalfUz1ZSf/Za6jv/r/n2pzzsd5SImoW0pYDvbYQKdWwjyAKD/BuHZ qvZc9HsyU0UnfJzjlYmqIuOax5pmcdE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RBr90U8d; spf=none (imf13.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679416934; a=rsa-sha256; cv=none; b=tSh+xFmSRDT4GyOw3VHHsc/ywuU1iP0euRa8BV14ORitew202x75ZL+r4YRV2AmCEGdOVz svOukrk2V0KkbIX616q+ZpCEhbvmIPxNCpLdPGAc6NVVrwWPx/2FAedtYdb9UTPGMl5ov9 hHPsrVbO7hxMfYVeAQMNIvAryPA2mls= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1ZSrO5HfUDDvVDUVlIZHkBuyCCML2UkxvJRJ9KEJLhk=; b=RBr90U8d8R2//lzQVrs2XIOu06 wm/t0hKvw5A8K/IeZy630OjGmr9hFVHf9yEBF+ctPwqdJE/+ac1K2octWNtoLB+7rEtxrvMZ8+tI2 QakA8J0aCrCWs/z+5UkmFP3ephpfhctIoAhxp5oCgCgMoAh9/AT4mCkY0tTVrIz117uxPa7uF1SzD 14h+7U2GM0IharEp7v6H05zdTEaZCxdzQK9jxVGxqErSABu75Fu6dNpKa8q3FeUiJzNGn2P3/OEti e1XVTfYs+IAobW/R3uizHNVwrXOwJsvHJ+hxYiSFKq3f1h9vMHEnspfZrfa7y5rS3rJfMfQXXcACs mIjbVy4Q==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pef3k-00D6kx-2P; Tue, 21 Mar 2023 16:42:04 +0000 Date: Tue, 21 Mar 2023 09:42:04 -0700 From: Luis Chamberlain To: Alexey Dobriyan Cc: brauner@kernel.org, frank.li@vivo.com, Alexander Viro , Andrew Morton , Kees Cook , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file Message-ID: References: <226a6fc1-f6f4-4972-b76e-774094ffb821@p183> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <226a6fc1-f6f4-4972-b76e-774094ffb821@p183> X-Rspamd-Queue-Id: 9C13E20003 X-Stat-Signature: qy3ufzuruqgzneb4m44xodkb1rf87fse X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679416934-261224 X-HE-Meta: U2FsdGVkX1/cRTnXcx/azl6P4ii0hmWLyN2Zda717H0YAW6+UOtZy5eVOzf1ktmgs9AdPBp3LGFM5ZuT/TVIUQBabq9YLjfCn5HGB4oEtqMZE6U8SwcfzZNBVHBdiSqsxDp9lCD3oczEgo7Eq9X4QkeoN6lxLRkChF3xIXy+UE8642h7umkXCYwTpI3Tyy+nRbNjK6cv2ojpHIfutZh9y5Or8iMRsJePNmmj1mLiUolDwnmGHNXLht6X6ZNUxc9ERCXXsbBrEocvqNG0MIalj/rHXjRm++F1knRnnIUsrE7hF/BF8UoHaJlgnYAHehq68szmHG0ZzzDZERmFNK6FW1TE5zigN5dNjn7JffNmcTVJhEJVXJLOfLR21u8rcO3uIi0NaSRRvr1YnNlfBvZ7tidnHaKAPMp/Qa0luQOXqvFJq4HqBwRY/8HurTMHrPfnkwfNGbA9IMrta4vXhThWZnKruxxU5TmoEk9KdOAatscbhRCzbJcIDUSP565JjkFfNbvlTK4UWtStPvmG8c1DYUkyCjHj6xIT9j6HwZGuOuBXtGdknoZtzCkWmw2SpY8kZCCdPkrbOBLfSwWgvxp0kgUdTkpflUkanl3D+iSaNvPtbFjcEl+f2L92g/S/2pKj4Z5twa1XEFIF+ljzZ4hLFspL75w1oGF4iBCy5fdvWvH9JeTf0TgKBzLHBZhPhau1cEUYnV3Ff3R/v0g2FQV+3D0Z6gYYwKCx6uugzwN+uij0WKqgpcpG8ZNetNGujrumUhuQPkonK9f6+x/SAKIfKlvQQbdAThnVeb797MSfGWRqgg3bD9RZLFbvyDmlQIWkeDZoeq401BCqV1ddKlXxyQm53vo+SGUVzXGOBIgMSwV1obIrIEvKes8suYENlbQi46uYXzfgEEvhWqrZ2pK/eqshopzYGHk5sUoM/oS9LSeocaBsUhE9oAjxPaepUMLFtMmJdi+x6AEAw5ELEWa icfgL+nI I0Kr3sXlQCJGxJq7f++MiHzew4gl+7SB2SpgIx4AqJN8daUwjMxSRLLIOH3vnFr3nlEmBpR8L+Ez9B8aYj/UtbJjCIIh0Ru0dmWHaImnXEEyXoZMjFR+ZABPI3oZoDd9qeVrQz9QgC6UyZ7D7PahMzmVvO+YE2d64xvF05/cjoFVQf4Ka2tXlp1jfak5AhqouFjN57NvBOar1DZS25hxw0GuLFXmub54ipKzQGjeIkENCyD5fZOYHskMbZ2j9xjpwJE4CZW/GgSv4KO90EN/O4HxHpkgx0muMEn2dozepj/33fIbX253MCaCtBbZZA7Qz2zGY1D2992o7MJuTpni8idsD/G2YOCLE47LL0T5ipnV2p3fJ8U4zVeXOgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 21, 2023 at 05:37:10PM +0300, Alexey Dobriyan wrote: > > > +static struct ctl_table drop_caches_table[] = { > > > + { > > > + .procname = "drop_caches", > > > + .data = &sysctl_drop_caches, > > > + .maxlen = sizeof(int), > > > + .mode = 0200, > > > + .proc_handler = drop_caches_sysctl_handler, > > > + .extra1 = SYSCTL_ONE, > > > + .extra2 = SYSCTL_FOUR, > > > + }, > > > + {} > > > +}; > > > + > > > +static int __init drop_cache_init(void) > > > +{ > > > + register_sysctl_init("vm", drop_caches_table); > > > > Does this belong under mm/ or fs/? > > And is it intended to be moved into a completely separate file? > > Feels abit wasteful for 20 lines of code... > > It is better to keep all sysctls in one preallocated structure > for memory reasons: > > header = kzalloc(sizeof(struct ctl_table_header) + > sizeof(struct ctl_node)*nr_entries, GFP_KERNEL_ACCOUNT); For memory reasons we are actually phasing out the older APIs which required an empty array at the end, which we then kmalloc for, and in the future will just use ARRAY_SIZE(). In the end that will save us an entry per each sysctl registered. The rationate for this commit log sucks. It should be fixed to take into consideration other moves as can be seen in older git log kernel/sysclt.c moves. Luis