From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6ACC6FD1D for ; Mon, 20 Mar 2023 11:45:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 841C86B0074; Mon, 20 Mar 2023 07:45:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CA9F6B0075; Mon, 20 Mar 2023 07:45:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 643F56B0078; Mon, 20 Mar 2023 07:45:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4F1E06B0074 for ; Mon, 20 Mar 2023 07:45:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0B72DA0BDA for ; Mon, 20 Mar 2023 11:45:38 +0000 (UTC) X-FDA: 80589096756.11.99A7617 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf18.hostedemail.com (Postfix) with ESMTP id 3DC7A1C0005 for ; Mon, 20 Mar 2023 11:45:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FtT0atWM; spf=pass (imf18.hostedemail.com: domain of minwoo.im.dev@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=minwoo.im.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679312736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9i+gqxdM/y5BZO9g7s9aqMmU36osNc941oAXaTE2IFc=; b=edAWdnWR45Dh8tYvrF+s5GbMFq50T8+zU3m+dl8jdNNOBiVdKVdbh86Rr1DV0hGGkSoxj3 BF8yqWvYkAqDB6jMv4gWfggwNPDKo7qGWQgu51WUhI7M2egvnBnAqTJdKBcYYSqWvPzaa4 NRtdtYIhqyf6Sf9he2dhDCjRzOEc5q8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FtT0atWM; spf=pass (imf18.hostedemail.com: domain of minwoo.im.dev@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=minwoo.im.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679312736; a=rsa-sha256; cv=none; b=2NpPwCFqrVhjYFCu3xuN31C3kKwPkf1do7uI+U9pQt8igBV4KRm/SWBq1kLqSQxUpWfyYf hji89M8u17ez2pJLSVSoqCDizcBuO93U5ssOwF0yeqRyZgx9W43Y3gCKkbVKsj22IlLlfi zAYWPkpxP9AH0OVRjlTLxEJETRpGysI= Received: by mail-pj1-f51.google.com with SMTP id p3-20020a17090a74c300b0023f69bc7a68so7591950pjl.4 for ; Mon, 20 Mar 2023 04:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679312735; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9i+gqxdM/y5BZO9g7s9aqMmU36osNc941oAXaTE2IFc=; b=FtT0atWMoBZ2Zmxoi0UplcYMfcOPvZB8ve7hACQTBebHSoYhsrMIvwaVUBIIqaquu3 SEOR1+O6+bUwCTuAHDhRFj0Uj18Go+qY/yTtGxup7qyRq/1Liwa7WLU5Z3f/+Ur9+zpd ceKEULxJfYgYbQTaRTleVtHifUf7Glw7vSwINHaTKEKi5ZTQvD21lPZ9Uh6n7RGqja7j qoL4wrhlaK15hpZAR+2anK22lfZRTgxjjVFw0/soyys9WGEeIx8IGkWWztRWdgQArSU0 FrY07hcbDP+OKhiXgPbdftrnA3xSWQ+OqqTyQ7mBxE4pvEiQ4pZ0ul4kXLv2GL85CdEG WO9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679312735; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9i+gqxdM/y5BZO9g7s9aqMmU36osNc941oAXaTE2IFc=; b=cpMPfeX3MgCx4Tqca3pjmNYjpcV53sJCjxd/LtkQicXKtLJz7zCf+VHzEM7sGpDBSJ OH9x9I9GbkkEDTK7IpIZU+OBTYrdmPzNjN5WIOJE7bhXhfsqWmCbzWxv30AA5jvnjhgx 9Txhg270mB40G1d36rcWIGhp5OIGsMXm+oKjOpE7Pjm17ZPPTGI9h5VzNFjKYxkQK0Ox PtxbMrXbXF/IKZUwUI7/JIQbFSQWQJA/fsZ5F6CdLeZ+RQr2TmJZPZjv8mzT1RY/zOKr n+PKfowfLyjIwFoisNC7xTBjfeeW+9DM4J13FInfYxn1pCSqodPsMpx898vtIntAvab7 DSRw== X-Gm-Message-State: AO0yUKWV/T089cmRGzrV5946xiRxV0e0324L/u0Vi+nfiyRN+fzTopGM uuVgRezEOoPmxChf7ISYtM9G4RXYe3M= X-Google-Smtp-Source: AK7set8azzlqz4uSwPpReCQKh/IjgkSweHSc7ScO5sPQkjTEURyTKyHR4Yz69DeJn5iA1VkI+D9p0w== X-Received: by 2002:a17:902:c713:b0:1a1:8d4e:a71d with SMTP id p19-20020a170902c71300b001a18d4ea71dmr14373775plp.46.1679312734669; Mon, 20 Mar 2023 04:45:34 -0700 (PDT) Received: from minwoo-desktop ([1.237.94.73]) by smtp.gmail.com with ESMTPSA id r8-20020a1709028bc800b0019cad2de863sm6506109plo.176.2023.03.20.04.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 04:45:34 -0700 (PDT) Date: Mon, 20 Mar 2023 20:45:02 +0900 From: Minwoo Im To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Steven Rostedt , Masami Hiramatsu , "Matthew Wilcox (Oracle)" , Andrew Morton Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Stat-Signature: xbjg8f4xb8hpy4i6xekouuyikf5ktzj6 X-Rspam-User: X-Rspamd-Queue-Id: 3DC7A1C0005 X-Rspamd-Server: rspam06 X-HE-Tag: 1679312736-948478 X-HE-Meta: U2FsdGVkX18s52mDhPUQDNlP+X6dvHneqS/2oVO4vDhgKTsGvGMDmikKAubO2b5/D1/WJiyu7LCdmUSA6GRN8egJRfmG5lFw6BkCpgihDOPDlzl7oRncWTbwy81EmrjkEwtjTfu9l7PPf11eOoX2MHcsY11Og8bJVHn7Fay8eATWw6mkmV7q2Kkif0FlIRaTTrBbJ8GUZYZzx+2V21Td6qDMtygAFqr9H+LEVNjtn79yYt30OJKGu7QtyMX+O5LXyEs84WQdw1iu04DliABL25NOl1Xx5zD7/x4D8lSau3pDyg0ZPRgK9cVPxGUuKyfyNpBzhN4EbJNUK3fCqGrqze/szfNO4e/qtekPvVy7TlrvnWaua8AnMOGu+2MaIC9jXrhnR354zIhqMxigrOvA5EculZMYPNAgOf6pH/G+gsR2UzOu/NmNT84/wSmbedpbV9xImsiM/bWtOVJdj/hZAf3TiA1+UGITwear0nsSY+N0LDyNlc61I4CqlX0ZYoIsR0UJMgf66G8D+cEheGULgPWHP85KdyUSabbSHrB6fBaSEegNEzv1JlzG2DBxT/UN02ws2QvIL+wmuxQ3MTDfUtNE8w4SM0rmvg5Hn3VG17pCLeeZ7A8rypJSZBbrms0uSX5EFKYRSAQQfSKhdSMj9ute1pVEzBNvPkoODUs+C+yWPs5xu2vFFr+ha3CFMWYeL/soeW2at1vOWt2xEMMtWjPdV66TqSa+1eKuSysl+UL9RkbJbih2t/1kKV+RyuB8hHOBpLnu0u06/FY1QaaWqNI7fquEEmWhiDaRATjFDnMfV8qN5GXHwNmsiaSl2rds5p4wc2QC6BgfAdVvHic3SPvdJBk51iUn+srWFpvSYo+TNvCzLEKfo7RVNfRMaI29eVTmMPuY3ZVqUhnr+mF7HREPbq0ARcJy01HjKhYnylBSOsntp7W8vrnOa5XTEwkQtEeSNY8+bg1KlnoZtqA t/pANWaY ld6sXlKv5LruRaORdr6SP/Wzgvg2o9vDSfLuSOFofjAD+E6kUwrbXWLBXN7b75P/Ey8GNv/K3j6pfsw7RDzczVyz6pKRUJMS3JTeKD3s3KYn8cs36Snxhf/MCTPtbw6bPb7w24lFImC2Hz5cK5Nta1T7NNZWF1fKyudTNvwI/DarKo/yWhyXi7y3ZanRmUbvsU7fTerUSaOIDSl1sF2zkVQ+J/UwCsc/LzrP2q2c58PBwDlH3r0F5Haix5IpdgXUmv5nk7c2TKlfrtuykFPcWHIoFDby7PgSd5ykGmYt/9nf9P9cZPn4mHhHnkGKgz3iTu8UuntYqTk8rdruT5FOQxAzlHj86RiTSjJlF4+WE0dB7iF/wKHK4iKPpkBwSAletoUH6PtczDT1BTpzyFuLFwH+GBx35s3HbkAfbLWLgEavAQ5KU/0vyrQN0keKKU79VvRsRDpin8JjORva560UB1vkrz3D87QnZ5Nc+eJyKyGcqyWLzt7axN0mkSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Ping :) On 23-03-11 08:18:00, Minwoo Im wrote: > We already have newline in TP_printk so remove the redundant newline > character at the end of the mmap trace. > > <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ... > > <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=... > > to > > <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ... > <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=... > > Signed-off-by: Minwoo Im > --- > include/trace/events/mmap.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h > index 216de5f03621..f8d61485de16 100644 > --- a/include/trace/events/mmap.h > +++ b/include/trace/events/mmap.h > @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area, > __entry->align_offset = info->align_offset; > ), > > - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n", > + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx", > IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr, > IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0, > __entry->total_vm, __entry->flags, __entry->length, > @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap, > __entry->mt = &mm->mm_mt; > ), > > - TP_printk("mt_mod %p, DESTROY\n", > + TP_printk("mt_mod %p, DESTROY", > __entry->mt > ) > ); > -- > 2.34.1 >