From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B6FC7618D for ; Mon, 20 Mar 2023 11:11:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FCC66B0074; Mon, 20 Mar 2023 07:11:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 685DF6B0075; Mon, 20 Mar 2023 07:11:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54C636B0078; Mon, 20 Mar 2023 07:11:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 40F846B0074 for ; Mon, 20 Mar 2023 07:11:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0E3338077D for ; Mon, 20 Mar 2023 11:11:24 +0000 (UTC) X-FDA: 80589010488.09.D452F99 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 4952BC0009 for ; Mon, 20 Mar 2023 11:11:22 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GViCCd5b; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679310682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EHp6xgN3HflFYePchmsfbBaV+U+BhTDeYJ4ZyDE6n68=; b=OauNvnbrClTvhoeikd/09YrqMBZTurfpe7Q2Y3h+FzbuMw2JduFnOVl+XSG4biuNZqHHMX sBUZhRFjVL+5Gi5VltSDMHfNXXFU7WxDmMyp2ZSpI5bc/vi0+ArSUlDsnmSCwHgedaQAKQ GPHniS5Oy0QCRttOjkzQx3ganAKwWj4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GViCCd5b; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679310682; a=rsa-sha256; cv=none; b=7+MGIbtkFH8YdefdJGN1FfJkz8JMQyYRLU0UtAC+ZeOKQHSwXxCgzNUpY6kgcKMt+RPwPi QtJqUtBoz0kdKgzMM3hxE3EEi/r3w0QuY0VZlIoD46VGw9/kB/mH0cAHXvtQZmI4rnLrRf mcB/0Nx8DiKwrUiBbQIGEuQwgw3BlmE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 501B9B80E43; Mon, 20 Mar 2023 11:11:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC3B3C433EF; Mon, 20 Mar 2023 11:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679310679; bh=6AY7P5Fx7A+yFHSErX2MDPUYaVasPAcdDOGMev+gmjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GViCCd5boJ4qQpbAS8kXK/2PJJbqX9jON3FCAckuEkFU9lqTmc5xW1ib8HhZtt95o WsgEJaFz0zi2hrWzHZjlvxH0OCxohNxGDlb8hnmDRICCRIs2xdrhZjDRXB6vZ8EiBv m0Su2i+97dJWYQo26JBWQifLVdNE+G4PraqEvj0TY1i49nydtVYC1TMn7l1lILzTCK xktIR+q30KLbG0QZYtt1bHS9HPwp1tRSN8Gz6PkTsGKS4gD8jtq8kv0d7LyNERWZ+L w8kTVeaRvdkoASjoEgKpXp5ToyD5bhn+85sl1ofjEz4N62HDv1VA4d/K2VTiuAu8iR lIrwG1KURaVVQ== Date: Mon, 20 Mar 2023 13:11:04 +0200 From: Mike Rapoport To: David Hildenbrand Cc: Andrew Morton , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 02/15] mm/cma: move init_cma_reserved_pages() to cma.c and make it static Message-ID: References: <20230319220008.2138576-1-rppt@kernel.org> <20230319220008.2138576-3-rppt@kernel.org> <8a461e44-7d24-5b5d-db04-e7fa85beeaa7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a461e44-7d24-5b5d-db04-e7fa85beeaa7@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: sgotp9pmugnxwqsm74agsnd6cbgjps6g X-Rspamd-Queue-Id: 4952BC0009 X-HE-Tag: 1679310682-16290 X-HE-Meta: U2FsdGVkX1/iMp16LAPaembJqbOSPddx+hSrXyuC6FTp4hP4Qp6YZJkGHPQrIK03Jc7U6UkQ6skhkUik3Z/BVHhc6LFepqZGnmNpMLfOUA294Zx78c1sK3/GsaQXOa8wFLbNXe0uGDOQ+NZdY7Nrf1bUIj09XGde8dw7dfc/EIWEsQwEBMQDGyCNFppj/4Wgfv7cXXljoeC/LhtqbO+7rg+PBa8B9Fit1jI6cLa+B9z+RrtwPCOkDEiqxpL3B0QoUP8rCW99kdytYKVVadCxyZLkRIGyyK6lUNxfvmonpGlDl/XAIMzogd+4eWHmgr0eVp93KIiuIAHSaBcegIQAjXEAoegyZwewXii1nV3dekakX+qu1f5U8rHDsvVx7iSEvJZvQwSyXVkNAfLpQAHOa5wP4JHD+AlB8w3UyyfFhhfquF3WWTyCon9zp6votSZG3oVFuey1bjyY8RutFvSAaYG6yHLZAVyAuGhDAyeuytC5IW9IbbDHGjDsw2+kEwEIF0QkIRo7bp99Mnz5uPzQY5SiZw7Ym5PmUkmc4JHmRdWC+OKaSgTIwKOd6ByloBNarTR1UbRTDR51bfyMQAxA6Wtco+yQ9b6BTgycFqzgdMuZ5TVW3WEUYhnnoPucLEh0Vovs0CT92prH+4ePcDIeodJMIofhNI6SPPeX4zo3RLXjHVT9rrIckGq+UMyUtTuz8wQKaE1+vHHIdnNSny+/60E+8yoWqxUJVxHS5ws5+Y5DVLl8lqp48p8Zenc5JiHvEWQUmn1U9JWRCK85DTNxRkJCWw11o6od/2jryT0G3SZvydn6t+jjOD8d/9BVRkMuvQEpF8rYFv1+AqZG2xo49kwlRvEKWTgUXBZYSElS/HVvwGKXhIPac8oeANNJnEe1vsYxAsab2OlP34T1a8sOyU1f/rSlJ43jmpfP62C8zagKRNNaGZD0UGlR/uTdWglz8oV6f45TJnLOypffQr2 c4ScVLI/ 6hs2rj3i0emHhvpB2/dR6LNvGONEGMV9u+UqxgLsbNZ82pcACe2pqGtQ7Boe0nC17cu06XE1Ya2DScOfjV68CLSf8kaI+RLXqXANsB3HUt9jMroLCGEmZVXqm5dMvBJQU40rfUV0+YLeg13pg6sDR7dxYaiRtrqOmI6jPV396SzHsRJDcxYLHjirSpRW+ltjpi4g7CsgCbi6MlBJpYXT/w9LTddD7Svnn3+/9bWctlQ7WztIzPa/JR7W3pNHWS6awGx6Gm9LYXbAVsdArg14DZsntp0qv7gLpXhDCWjaLoPUzE0P2ipz5jYP1SeJyGHYQqp+2dmEjj5Kn4gKhztPTDe1WVxhelM+ldJFDrGTgNL80SDDk1SEbkpsNNn4Z5XON/foWAplmU3BSKw6aQKXF3169U2mQYfNyDJoz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 20, 2023 at 11:30:20AM +0100, David Hildenbrand wrote: > On 19.03.23 22:59, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > init_cma_reserved_pages() only used in cma.c, no point of having it in > > page_alloc.c. > > > > Move init_cma_reserved_pages() to cma.c and make it static. > > I guess the motivation is to avoid letting too many subsystems mess with > pageblock migratetypes, managed pages, PG_reserved ... Judging by the git log it just ended up in page_alloc.c because set_pageblock_migratetype() was static back then ;) > So it kind of makes sense to have these low-level details out of common CMA > code, no? I don't mind keeping it out of cma and folding this into "grand move" patch. > -- > Thanks, > > David / dhildenb > -- Sincerely yours, Mike.