From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD26AC6FD1F for ; Sun, 19 Mar 2023 20:22:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3511F6B0075; Sun, 19 Mar 2023 16:22:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 301876B0078; Sun, 19 Mar 2023 16:22:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C91C6B007B; Sun, 19 Mar 2023 16:22:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0AD646B0075 for ; Sun, 19 Mar 2023 16:22:21 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D2D7D803E5 for ; Sun, 19 Mar 2023 20:22:20 +0000 (UTC) X-FDA: 80586770040.21.B45C9AE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 40DC31C000D for ; Sun, 19 Mar 2023 20:22:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=n1bw0KCG; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679257339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pdlv0SXNtbmdh3hXQkVCBEF8uhLOIx9WAai4fYXSUCY=; b=WIVUp5vgSp8iCshiBbLf5JGNeSMwzKDsBiv3PqjU3d2BuF+2fA+JqO3Gcf1uBSrUqY77b5 Sysj7kSE6zZKJov6ujulvXmC1Mk42rZmaeJipPxgf/R68SeyhLQ7gduCjzw8ZqbluEuXyF MYp4oh+Cm4/0cAxjRVPkC72VAFCN+aQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=n1bw0KCG; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679257339; a=rsa-sha256; cv=none; b=ZldTdI+WF/KdtU5e03H2MnixnSsdO06MH8cLh4Y0HTW7ONAihSlIHtN5COy+BYPJWP3W76 ojfI5ThHhwJiCCCbUiiYWkZl4ABzN7pM/PxKB9NoXDFrJfLBz5N1Vz0CR4bZ9dDpkjOL14 cBhw5RvqzLhEUxwc0X44uHR/B1JtGzc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pdlv0SXNtbmdh3hXQkVCBEF8uhLOIx9WAai4fYXSUCY=; b=n1bw0KCGCKvHvpqISlp0l5vJ5U fckwZDWujN1QUxuKmXI+tJmWx9PtMkvAdhYcsuo3WCRj/CbatUCZIE/LzsAF77miL1KSLTFXS7mss XxwOFXGxrrH841R0nwAKarGBtRRK4XAxDAmUaAZ2GGasOn6T8JG2XNjqocnZQTC/slrnYmVEOv3Lk 9o72SBYL27YOh/FmHSzkU0aXbhrdKld+djZmSna8q5dej9euJWvAG/bT2ree73ix04ASA8vgtZ1d4 6m+TKxPnvU16f47daf6dQ2s+/sK99WBcVedYyGk++xJ9ecyUB/23ZY1m28jb2gsIJswKltUvRav/I dbsGrTLg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pdzXi-000MkM-Dt; Sun, 19 Mar 2023 20:22:14 +0000 Date: Sun, 19 Mar 2023 20:22:14 +0000 From: Matthew Wilcox To: Lorenzo Stoakes Cc: Mike Rapoport , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: move get_page_from_free_area() to mm/page_alloc.c Message-ID: References: <20230319114214.2133332-1-rppt@kernel.org> <0020b728-724d-4206-8768-ec94d5628b34@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0020b728-724d-4206-8768-ec94d5628b34@lucifer.local> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 40DC31C000D X-Stat-Signature: w18xzfgjg3hjtwcpzpus4djx4spksz9c X-Rspam-User: X-HE-Tag: 1679257339-674361 X-HE-Meta: U2FsdGVkX1/2VhhpW14iYn5sZnIhy71A/Iu35P1n31vNAjOV6lmNq7oEwX7GUiafUnN64PcK3xyB8wHh2ngcHTeWZIHCbrqWapjVT4b7xz5VEjSrSuiBc45JA6zebIGWynbu6+MM/+JyNCm1VcApPwPI2lvOQoVesaWfaOCFXDceOJVG5GVac+knWmeCAQ9Vof6w0LiCaBxwrjbflQ5hVkf+cb74zhTy9eGeQaE6aQckLEXoTbqtTWWLRW5756pqh5N6xKn0yBmWJbsdWstn/rHEpwvB8SyqLRP7R5HNyZERrjg3ow5b4H61UuDVlEemjQgI9gIGhw5YCRMA6gNUUlvf173Ka9mBh0D14UyG0sWhWOgNN+BE1l6xpmbOlUZWkB7ywMDMfUbx2XNxNYyoItVLRM/Kt/UX+XgV/v4lLl0Xv1/c75hUDyimRfNBYP8+B2+tbW+uRSSSye6EaYRW6XgHJTafXop3OIcRBY92OBcp1gcUt2ehaXawrGMCH2LsEEit9lmsESbF0oqivzxHej2SNddRDlZdeHT2st2Bz90a7z8KNdeKE1bzZ25tHvnCOFkRWf6RnAAvYk8aM31ciYj9ih+N/L3iv5kHrd8DZQv7kNQvDqAJAYbe3ZeSFwiq/MAf3EoeBD66JWD5zvVs1xplDidsGpK/SW8vgGnTJ5UtbFcT92l5Dofs7ns/kYl4pkaJ4KqjcK4YG6E6098kEqTLPgVPsJZAv8LvFroGAGSetvBcjv//d3lJAqNySSC9nKTbZ3IJEPzCU1T6KJMWLQNRyaC017msKfRnmi2WI2arpeEYmBzIZhaPfIIiv14t9GTJ0i6I7dV0j7be4UT/pyevwetqGqSVtlyv8HTICqXMPYYiCNtEWZZq4jXePisEEyf8YFKcrh3h23rJ7ob4gI4pktI1HUZUH5U2hadndcEuUNoSVnHERNDyPGcXMuDUaPPtm7Cp38iVTY0c2oD ptBM9VbQ snp0r2UFuKlJM+6JujmPzPQKXn/TD2HfT4zBFDwoAUmPoPrVidfaJV+xKX3Z6QOwpKZG2apCIJp7lqd2fbIkOAs23/5hejxaMCwTONdpKIcxK/4CTO6Fsy7DU72eGV2Bti7monY+lODra5W6jwmBsZJi8tHlJgR8VUlU0STILUP/ADDagC4sZRqFfi5u1wiiP4fMR5ZVWfDxFRZUqAMvemCOfFJ5PKQ/hHWbjqbV4hjQBE0s7k7YtBxJN1NUOaU/pYKPMGKByxd4UgDVuZGW0du58+peue0Wu0ReIaJM0zN5YvinQ4grGZ0pOvsXOljRAvGad X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 19, 2023 at 12:07:43PM +0000, Lorenzo Stoakes wrote: > On Sun, Mar 19, 2023 at 01:42:14PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > The get_page_from_free_area() helper is only used in mm/page_alloc.c so > > move it there to reduce noise in include/linux/mmzone.h Reviewed-by: Matthew Wilcox (Oracle) > Good catch, I wonder if there are more functions like this that can be dropped > from headers? I don't think anything outside mm/ has any reason to see 'struct free_area'. Unfortunately, it's a field in struct zone, so moving it out of mmzone.h will be hard (unless we can move struct zone out of mmzone.h?) free_area_empty() can move to mm/internal.h though