From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66575C6FD1F for ; Sun, 19 Mar 2023 19:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87B526B0075; Sun, 19 Mar 2023 15:42:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82C896B0078; Sun, 19 Mar 2023 15:42:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71ABF6B007B; Sun, 19 Mar 2023 15:42:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 61F9E6B0075 for ; Sun, 19 Mar 2023 15:42:35 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2E2061C6209 for ; Sun, 19 Mar 2023 19:42:35 +0000 (UTC) X-FDA: 80586669870.28.DCBAAB4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 16C4780002 for ; Sun, 19 Mar 2023 19:42:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=keiJjIFn; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679254953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dckGfQg6kn3B8kgvZ3tmjZnRr1vtXFAdWVSiqcNmDYA=; b=58CyOo2fvYd5WqH88YWv7rcsNWakAQBIvNgNDxESAK8A4G6PtRrqz5rxgsKh7w/THHxwq2 OyJY6iSsJG8Y6ZnbTFBcukapR9YwJHXeIlK91Tvsb13Hqtb38l0CYLReAwjCs7i+sShJdd Udl9xrpdgQIMcriVeCSmEn4KpCc7jUM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=keiJjIFn; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679254953; a=rsa-sha256; cv=none; b=tXUvsJAyNqKmvQUeguWn6LqV/H2jwvB5OJmRBPY70/JBG17UMN+fektiuJUxmw3xalnKlh OLVDpKxJUut83V0utIqxET1AACrnAar7tcnBYwN6VePsTC6IPARJwcJAJ3W3wzoSNlmudT oU4LnVj/kaCjm2Xe0Mah2eVzEtRE5Og= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dckGfQg6kn3B8kgvZ3tmjZnRr1vtXFAdWVSiqcNmDYA=; b=keiJjIFniHCX8fhpO8BrWfQDwc +xwQ+qHC8BCpNgEg2qx+S8wZ+VcnIVxCEOzLW7uu9YnPWXq0b42uh0q3t+eU7qK8lkzHn6h1bRyT4 5fuX4cbxHZOMZUyR6AvPIsD3dPFoIdurzgNlgXrBUlsq7k6omFSHZYKpDgKBubUgtBEtHkU8oL0fI BBC/20GSmImV6rDbfnfvkUcY/6HIZWRchyhtbiBA2Ry2dci/s6gs/skEvxajIz4wn6BadtenowyqF T8FMzdl5mqsVv0Baka5PlwujpKZoITJSPV3nqCJMKLcrkz82RlIk/O5sjH3SQdU2OzhH0x+LLt8/x Uibee0rQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pdyv2-000Ktv-20; Sun, 19 Mar 2023 19:42:16 +0000 Date: Sun, 19 Mar 2023 19:42:16 +0000 From: Matthew Wilcox To: Tom Rix Cc: Liam.Howlett@oracle.com, nathan@kernel.org, ndesaulniers@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] maple_tree: remove unused maple_tree functions Message-ID: References: <20230319132903.1702426-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230319132903.1702426-1-trix@redhat.com> X-Stat-Signature: mxd4apgnfxpf71dq4o18equm6i1oxt1b X-Rspam-User: X-Rspamd-Queue-Id: 16C4780002 X-Rspamd-Server: rspam06 X-HE-Tag: 1679254952-995365 X-HE-Meta: U2FsdGVkX1910rIwpqKlfGqgsKugr+t9rRtyZNuk3WliKfoWhrRD4IptioU3RgQr4z80o5LR50LcYB1fjM9QX+kqVJMBr+fqHT7ggaAvB33kHuMbz+AozT7I1RO7NG0EVeaImUHs9esxX70koe9wbNmTN1atN6UnQYJRz4oZjCHKrvEj/RayHnBEl4RH+9l+3l0MnCh8xscfRNvzPvjPmtEj++wNdOKCInskswRFebigB0XwVBNRr1Q8AY2i/miERPOEWO9jT/vAQhHGT+Fqg7HcrKmPPtUyZBRjRAFiKQr0Y9B1mTpsw4+d/thtGaUHzfWDDHsqhWnztv6n2Cxu6QCSeGobTA6Xu+5qaMc5MdRSVg14gw5Z8EYIMZlVNgr2SsPFHWYZRU5+QIau9OPqxi2W8QFvMa821lkvO3zwsmZMaoxTRuEQ/zHCuL2ymhjDmDW8RH1Xv2V9UU2AXtR6DFQSsn8d2boR8/5oUYq2L9mNlJnbPidtQLR2ulrrJE772T7UmCPJk8JRmtD5Rl0CULvZPep6bZ1/N48e6YNRm6spNwMJxDsW1koT6ncdmGgtZ35Rb5c7hhyxXzmLK4+8fZFMt4kSeN6a71FqpNmrRR0MQo6BjF2jF6HyYO0/M8AT56EvfY29x2kBr/eOfynkcaVnDd2ESMwRGH4eq/f7NVNuDQGShFGwNP2Ke/7KCvwdunQnXeAhyvblyl29E9WnORaBT/9nbLzO6ETs3bS26pXHILEKjRcKZT34co2Ka3ZT4yqq9RpsmAfzayO5g4zh10mc8EyyT2e0GQsdG//UZGVQpx2F3Wv0aHrmZqivB8EBZY0r/8cNFRX0vsTCPlr8HZ7zLqxN8bgBsiiQNO+oJBQhERg1cAMlxleYYXkBkG1ZHbTnehZrGKLiCXA2xO8bnJpBGlsIQy1+wjcgKK1dA0dTNYaR4yAt++YZ47ykPoWbmMeV9qUFCLEKCXX1XMT WQMbOAJ3 tkKNpXbU+5UpGic+iVCBZ1pzGdtANnMg0Htd9XXutikXaFqetjwQSPc0NOLRlzemKfXTcIlzPjVbpLT/KZQY5sxacvW4yaXoUM4cUJpydmHeoHRFzs8vfVdWtfGTX82MzQtD+Gy+dWBvUT7gZT/vax9NaVOqcZEmLDV/RgO878idQpwKw3mocD1LpIh35KByTPwYsh1+DTPjB15I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 19, 2023 at 09:29:03AM -0400, Tom Rix wrote: > clang with W=1 reports > lib/maple_tree.c:331:21: error: unused function > 'mte_set_full' [-Werror,-Wunused-function] > static inline void *mte_set_full(const struct maple_enode *node) > ^ > lib/maple_tree.c:336:21: error: unused function > 'mte_clear_full' [-Werror,-Wunused-function] > static inline void *mte_clear_full(const struct maple_enode *node) > ^ > lib/maple_tree.c:341:20: error: unused function > 'mte_has_null' [-Werror,-Wunused-function] > static inline bool mte_has_null(const struct maple_enode *node) > ^ > These static functions are not used, so remove them. No. They're just not used yet. NACK.