From: Matthew Wilcox <willy@infradead.org>
To: Tom Rix <trix@redhat.com>
Cc: Liam.Howlett@oracle.com, nathan@kernel.org,
ndesaulniers@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] maple_tree: remove unused maple_tree functions
Date: Sun, 19 Mar 2023 19:42:16 +0000 [thread overview]
Message-ID: <ZBdlmDVKdrtM4BXb@casper.infradead.org> (raw)
In-Reply-To: <20230319132903.1702426-1-trix@redhat.com>
On Sun, Mar 19, 2023 at 09:29:03AM -0400, Tom Rix wrote:
> clang with W=1 reports
> lib/maple_tree.c:331:21: error: unused function
> 'mte_set_full' [-Werror,-Wunused-function]
> static inline void *mte_set_full(const struct maple_enode *node)
> ^
> lib/maple_tree.c:336:21: error: unused function
> 'mte_clear_full' [-Werror,-Wunused-function]
> static inline void *mte_clear_full(const struct maple_enode *node)
> ^
> lib/maple_tree.c:341:20: error: unused function
> 'mte_has_null' [-Werror,-Wunused-function]
> static inline bool mte_has_null(const struct maple_enode *node)
> ^
> These static functions are not used, so remove them.
No. They're just not used yet. NACK.
prev parent reply other threads:[~2023-03-19 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 13:29 Tom Rix
2023-03-19 19:42 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBdlmDVKdrtM4BXb@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox