From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524CBC6FD1F for ; Sun, 19 Mar 2023 20:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3A6D6B0075; Sun, 19 Mar 2023 16:54:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC21C6B0078; Sun, 19 Mar 2023 16:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A63956B007B; Sun, 19 Mar 2023 16:54:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 920946B0075 for ; Sun, 19 Mar 2023 16:54:55 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 59FDC4010A for ; Sun, 19 Mar 2023 20:54:55 +0000 (UTC) X-FDA: 80586852150.10.C2BF97E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id B8E584000F for ; Sun, 19 Mar 2023 20:54:53 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=aaMaq0kt; spf=none (imf07.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679259293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pzM7XEyWktl+4erzWcp/dvZf8Yk5D9ydJeEulAkdtcY=; b=Elk6vZa4xmbf0waib6Tn6Wrtq2kELKX+S2GPEe5cBcTl0aCzPUtAan0bZv9WuHLBPS/9ia 4iiMnnx+iFNCOqD2Oova0EPPw5/njRaTodsRQ40dAaEIIi117/AZycsYiACAxx2OMQ/TMH mb7bGWf8shx1BS2g/pcK3SDco60lQzA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=aaMaq0kt; spf=none (imf07.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679259293; a=rsa-sha256; cv=none; b=jYo8OnsSEc+RTDyff8VCvvg7S9qoW0ff87sJAskLtOMZ8yksOh8RW89YEuwsbXDU4XbGpB IsT8bnyD46fD3xZlDqAdkf3zMuxakcyrL1Ji8uQygIrDIwCiV+G7EOGRv7+d7XO4X+/P+l F+O6WBvw4wlpc12CzYgOmuEAjoqM+ic= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pzM7XEyWktl+4erzWcp/dvZf8Yk5D9ydJeEulAkdtcY=; b=aaMaq0ktdc8/eKtK9kgPSMr6nc uLfrSTZhkf6C03goYbPvHDP8L60VeO/YQvPyk7I3I6yfR4JcHFCGEZIPvo8G8fojalL16btYpQzta 2H8DEnLtfQirBad5SCOg6TkFzkLkJ4W8SijzVOlervUOiPUiIu+bIHBObeOQavR2uwwGEZNXOfkxK hGtJ0B33DVWrIuwW7lN9GeyRK+2MVJ47kSgYNWnSYzoagsEoO3ttOxxKeK+Kx08wDLmGRpAcuy2sn VpiqknroJdZjwhL/Tt5eh8H9VO6aDoVPtXXC0BsFLlocRZ7NN/YTwWgjMiFWV2SjXD1dPTeDxhkHJ Gig91M7g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pe03C-007Q0S-0G; Sun, 19 Mar 2023 20:54:46 +0000 Date: Sun, 19 Mar 2023 13:54:46 -0700 From: Luis Chamberlain To: Vlastimil Babka Cc: ye.xingchen@zte.com.cn, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, chi.minghao@zte.com.cn Subject: Re: [PATCH V3 1/2] mm: compaction: move compact_memory sysctl to its own file Message-ID: References: <202303091144483856804@zte.com.cn> <17e2a143-37eb-fb4e-d8a9-2d6dc20f9499@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17e2a143-37eb-fb4e-d8a9-2d6dc20f9499@suse.cz> X-Stat-Signature: npatj4i1bx6sexwosgi1nqtegc7fjg88 X-Rspam-User: X-Rspamd-Queue-Id: B8E584000F X-Rspamd-Server: rspam06 X-HE-Tag: 1679259293-3267 X-HE-Meta: U2FsdGVkX1/TaUF3uZyHkO6mkHT9EZASICJNPubbAuBiAiZ0mq84UsZ4mF1vIQnJ/G3qsg7LJb8MwNmJSkg+wwsL8npsb4eSwCLS04qsyxjAK0r+cVc5uQN6Q4G9EwYnA/k0o2mrGK3qQLkWLldU24Q46urbG+2B7DL5LtH6q9DnOQvdYCp7VXC/z7J7qVZhVXntYzCONEW4DHziPssNcv9PM2Y828ohGcF95NFzSyeA58vrgfVQFJRffuChWTBSnlRPc9vaf1ljznsJX7UUxn3CQNpjxKXoMBWoNBf4Zb5I5zPvlvrr7zZrYXbvEHFEtDW+V5R+EBxAFbol3eb0m3ZjOAoXhm09j9tfA2HhDx9FChPSKx8/FCdINlu7Lf6OYjwgtLX6dmveUkubsR73AxipS6qgGKIRXbmVK0MSwznkjVi2eIwUQu8JexzqZNsR+ctRYVX0OVbw0SLPDcGK7IoiZ8L7iQGog5seSAMEYKeQP1LddWOLcYUNUjMvKJE0CqbvDbVz41ecWdLT9/9UcnaFyQfbKdtS1NgB/ijQKh5OOVQ8HR99C4NnRkHiNl16FkwnX90Tf6wSNNHJ+LxFpgxF6+lYtB381d/Q875++XRhqyZWS9j1CJ/fsu0xBFtMCWj+kHRyspYFtdJVlJMQlguRPhJDYBBiAWPjZzXh1tE7+xCrqz8WamXlYo4yJtZ5ziD7qvSFL29bXK3PGEt8QoRCnbL0HitAA6K7Qi0iXUwL7JBf6k+eTdHSW3gbuuTROLP3yr6+SC1QrMVwYnFAzDy+OK77JdSeN++5569T3XaqX18ODkQSvMDgnSxWmNyH33j4JyITO4Vo1XrdotXBl0c5ot+spw2oG5YxDT+AFFFsWeRTgtcF4q502sTSd9rizFe0gNJpe/Y5gap4EnIahG++mcvqc/rfxNl0GxO2uWJvfepQ3zyu09wW57qCD/nf3BsNF1yaHQz0E53cpSF qZXK8QKs aZBwYbYnlXgnNskKRHTr7nM3W8BzTJO6e/PCoxA9s6PtAvYSLJSfj1HnK1ABv3FlojqG75hcukfwvPNY6GTsEmaYgrhMb2ZI0rsKpMQdUwj3znQjRezeKBUNwNuJfXOcmhgocR0999K+qL0hAxtBhl5w/CuWsOWKYRSSadTFZ2S5QnmGa1TDHxRufwSMO7nlcE2UOJv/kyOHLgkIhhg9QVRHIs0ZyriRjidx/TGiUdcDmQMaq4Apc+iVi1i93X9TlEGUyGFgmLbNXg3r8CFlGo0+/h57jaOE5DwG2I4xZA/04t4j2TE9Eh/i5pPaXrulxS/AfG3ADusdtSK1Xzc9I81MQvmZ8GM9o7P7OlytaeG4eQdGOGCaWnWVHpStxjJP49pybxyturoFQd7f+9WoH4abo8v2jtnO+yWwydgQQ1fbfg89WJCeobV3p0UmWKNsupLVOtAj6q8unSZB+8kMsm9T/0XLEly2PXiqRXmxqnWoSJeIpPbIXsTDmhPKkSxYbBSXpTsmBqQ9CGO8nK7uqKpgWUz0p2Z0ezjScgxjEGITLVM0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 09, 2023 at 10:47:46AM +0100, Vlastimil Babka wrote: > On 3/9/23 04:44, ye.xingchen@zte.com.cn wrote: > > From: Minghao Chi > > > > The compact_memory is part of compaction, move it to its own file. > > > > Link: https://lore.kernel.org/all/ZAJwoXJCzfk1WIBx@bombadil.infradead.org/ > > Signed-off-by: Minghao Chi > > Signed-off-by: Ye Xingchen > > --- > > kernel/sysctl.c | 7 ------- > > mm/compaction.c | 15 +++++++++++++++ > > 2 files changed, 15 insertions(+), 7 deletions(-) > > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > > index c14552a662ae..f574f9985df4 100644 > > --- a/kernel/sysctl.c > > +++ b/kernel/sysctl.c > > @@ -2190,13 +2190,6 @@ static struct ctl_table vm_table[] = { > > .extra2 = SYSCTL_FOUR, > > }, > > #ifdef CONFIG_COMPACTION > > - { > > - .procname = "compact_memory", > > - .data = NULL, > > - .maxlen = sizeof(int), > > - .mode = 0200, > > - .proc_handler = sysctl_compaction_handler, > > - }, > > { > > .procname = "compaction_proactiveness", > > .data = &sysctl_compaction_proactiveness, > > There's also this one, and two more, please move all of them at once? I'll wait for a v4, and if you can rebase on top of this tree that would be appreciated: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next Luis