From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D040AC7618A for ; Sun, 19 Mar 2023 20:52:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33A406B0075; Sun, 19 Mar 2023 16:52:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EA706B0078; Sun, 19 Mar 2023 16:52:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B21F6B007B; Sun, 19 Mar 2023 16:52:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0CB326B0075 for ; Sun, 19 Mar 2023 16:52:21 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C66F81A01F9 for ; Sun, 19 Mar 2023 20:52:20 +0000 (UTC) X-FDA: 80586845640.01.CBFB198 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 2208C40005 for ; Sun, 19 Mar 2023 20:52:18 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="vL+lCRr/"; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679259139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vxHLS6zAzaxm3slOG/84r337lQ1+f5PairrpoOFZfbg=; b=b6x5fwxvBlbeondcu/P2GmpKJILZBpcwZ0rkp8RnIdplKzIjY05U5K9srXRddSX/c6TLnP QA+eYLBsoUv/UNe5DShboNVOFGlpnt/ej/b/olT21lW2bSI196ZXrcYPVooj2IfXxkm5QA XB8uchJ0nqT+GprItXc5PPfBC/XXvrI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="vL+lCRr/"; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679259139; a=rsa-sha256; cv=none; b=nRm/zOa0Oh/2KWxezIS1O0fztNH15ozwvqOnbd7ky58TbzWa6jkN5CAPP3VYUc4PDY3zKp i/Ass3EAKtLvnjVfkWWEWl4avNPO9jUYwLZp2M7WYPgNEGDII1o0j+9ixbYBKE8lUSHmUG gJkpRrItHt/kw6NyRqgC2oV2/5GmZv0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 291B46117E; Sun, 19 Mar 2023 20:52:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D874CC4339B; Sun, 19 Mar 2023 20:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679259137; bh=jnSlMSfVmw1ZnOv7z43vykdjA41NROrY6Ktk8ZZdvgU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vL+lCRr/8yA9n6R335G8ETSlzA+Iya5cMCEPNJvRcqEPiFgqOma3Fh6T0QcN2dxJZ Zrpu9585Uh7pN7mMdnUagUOknvK0kxkP4p9BWpRWLX58fCzyUuWadjkjp7Z9/A30Ct CLJWsZS7ZWkvp/9SvV1uAv54pIq3mjs27hch/WkzEAWFumfE2mZxK8nB1Vu1FtbwkK fH2ebFFKvA4NQgfLBfrXyx5y7tqd2IFLEdW1vyztFVasZFatFGnVACLuAFs2DYPYcI 0aCgnKzpArQIWuyKNHX5daKJ07T5oE4dL8SRQOHU52XJU0P7/iRHXhFoQIx2F8NTmW dfzKZJJbdotjw== Date: Sun, 19 Mar 2023 22:52:05 +0200 From: Mike Rapoport To: Matthew Wilcox Cc: Lorenzo Stoakes , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: move get_page_from_free_area() to mm/page_alloc.c Message-ID: References: <20230319114214.2133332-1-rppt@kernel.org> <0020b728-724d-4206-8768-ec94d5628b34@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2208C40005 X-Rspam-User: X-Stat-Signature: fmkfxepa698xii58hjynkmxfjqh557xr X-HE-Tag: 1679259138-833465 X-HE-Meta: U2FsdGVkX18OmSQN2jJqVxcMsXE26Xzz3GNvNBPHBAeO0XyzO3PqmSn7mpMS5cGR1NgiW85S1AsvaJ+kVCe63OOG8G8Qd9YUYboMKmy982gSbf5WAwwwzHKAMNgIGHRTfHvgW54H5DPXOHtUO5BwY9j/1rsIXznii5qBY0iqYHipCDvOdlhXxiAQQ+DFy12UW5/+2ApUS82hTATmShKA8CsW/BObK38q8nSNe4JgCLy790LCu1WLCfEsxrjblWN14f4mbrsBIILIugLwd5TyIx6UeB0DsnvUGdwhaLoiHTCjCbaimUxBg9kXpyvHiFf+oKWjqp/e4/+Ct1dazpS4WprpeLkE0qzTi1mVQSuVRSQh6ynoH2o1F2PX+i0LzHChGiaCP7vRMDT1QCM1VKODAuCAf4mx8y7Pgvmkh4ozjVavgvo4tKfLFI+qB4GV9F1x8RTE/PtNXBqrT7GyXmX8vzZeD8hP0XfcDqcfTC2ZL0uut+pnlIjYUSc1SpFX3FyIoxk4CBtuuUSMgLgLOr/klGpwUFZHZlWodSFyXPRztd/yu7j6tMd5ugwzFfwiceLmgoqqe7hmaTaUOHFpsGhUFoWrEZw42UHB+LqYxRDtLPlU6n32RDkdOUYI4WmTM/hjg1Y7eUqmRu5x+PoRe+0tcpDsz9bWGwXArMImCB4XSNu82Rp/SUkWo1HYGinLnZ6sZ6Pz7qxYiIqeIDkA6qcbCONLfo4mWwgpSd3PQHrH556q54NsHP771L0+zLfWcCtu8x5ekd9NjoMNZZYImDImWpVmTjF3vKEfEefIN+2vKMds1PQ4k61fJ6HyyfV6EIcc89Mf6oPXuRlNa6VIKFFMdxOR7+kAlYdz4SO5Q3XupyDm0v7fqMzqRfV5nqId2EFEkxWhPI8UR43zfMKNyb1L5BUuI/YVFcVDa6dUPj0sLKblKUHDUdNgp/ehhduDWDvps1c/YYWslSGquSTbEbv m3bBzZOS a+ran4NZRLVNWE+fRGGtsPUOGDD9hiQyaFHPq7dHQOQVV2gsuiZGA1cyH/Tm/fnHb2i+Npe5n7GnJTeI3X1h+ktyl8+jLwjFHLc2K/96L4UyeVIMIXl8K8FUy8VBkwezkOTGtlO4fEBCd2mU7X00AV8umS2qD3OG3aE+3W1ITuRbn/YE0oRpfENJ0+KTAjot08LR1slj/r+ckOkTzfQO6lSovc1Fe2kh3D14UyrQm45aoNDobDAjt3dql6aMdqQUiTxxatnwfqrvqS8zqLVt8kxFHFR2BKazUMyF3os4YuIQBoSsDOUY2FDVBgAVvXxZ5g1CwJJnv3yYsKdk435UIiczDoqdXMGrKYi0irevEvOa3baEngAh9/YmqOHrZu08F0keyywFHgA6ori9by4QF5ZVZwmeWWVpDkC9bpglEPUZqZ69fEvDjxnKSKwrApW6IGgin8MxbnnFQQWObb+fUwKK0gQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 19, 2023 at 08:22:14PM +0000, Matthew Wilcox wrote: > On Sun, Mar 19, 2023 at 12:07:43PM +0000, Lorenzo Stoakes wrote: > > On Sun, Mar 19, 2023 at 01:42:14PM +0200, Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > > > The get_page_from_free_area() helper is only used in mm/page_alloc.c so > > > move it there to reduce noise in include/linux/mmzone.h > > Reviewed-by: Matthew Wilcox (Oracle) > > > Good catch, I wonder if there are more functions like this that can be dropped > > from headers? > > I don't think anything outside mm/ has any reason to see 'struct > free_area'. Unfortunately, it's a field in struct zone, so moving > it out of mmzone.h will be hard (unless we can move struct zone out of > mmzone.h?) Seems possible but not trivial. > free_area_empty() can move to mm/internal.h though Yes. -- Sincerely yours, Mike.