From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 207C8C7618A for ; Sun, 19 Mar 2023 02:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55024900003; Sat, 18 Mar 2023 22:51:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FF75900002; Sat, 18 Mar 2023 22:51:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 415F4900003; Sat, 18 Mar 2023 22:51:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 32CAE900002 for ; Sat, 18 Mar 2023 22:51:07 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E65CBA03A0 for ; Sun, 19 Mar 2023 02:51:06 +0000 (UTC) X-FDA: 80584120932.14.FF48C75 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 806E0C000C for ; Sun, 19 Mar 2023 02:51:04 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="dz3i1li/"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679194265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6cpyNU+RniP9ZGMmV+J7xJUGT6Ip5/sWZ1J+XMeD67c=; b=y4bF1H7382HULCbMFnwP6Ny1bMcEYFWCchPwkoKaEfl1W8Q/UgC4JlsTgWHqJrtK/bXyE9 SI1OOI0GpmjJYjbjD6aXgASZuiCEViqF1dUPs2vMlWG29rUv6eGxu3/MEBDdoiuWG2nzk6 LCUqp4nSqJl4jokEb3Sy+9oRnleraHs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="dz3i1li/"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679194265; a=rsa-sha256; cv=none; b=MjPrGYoGnlb+8VL4IUXiwOv+VXxWTr1EJoBQfnKxyLzrkWZwVi6FIXLGZARNA+vNhj2Bot rqKCuQPVyqlX7gEvlCL3hyNS2Kw7f7Gln3y4dYNqT3xJPL+C1/5Mn5tijByjRHrbUrgu/N EJ7UmzACc42q13Ob4ghmr07WXpjcDg0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6cpyNU+RniP9ZGMmV+J7xJUGT6Ip5/sWZ1J+XMeD67c=; b=dz3i1li/xUe6gX2QgffRPlfRq3 F6q0QczmjWehtRy8nyrto+L62Gk/smNYs7ZmRnDcvP3JxunsmPjfJ0hPV5+1MqeYfEFoehf6MEGlS xgxcoZLb7Kk+lnoYPnZkQGrPS4P6bgpN3VBVEAz4h7WeQASt9E4SCPhNqmNDzWICkggfZxaogmmBt elM6DNMBO1y6T3drlMzYPI/iulYANoGV6hFiCJiUXr2zSKfHol2vIX7Ib4YlC8A48scW9n3+VTPrm 8ntnscGkcELcfoGTBaYFCMzWwOq1Q7PblihH0T7FXroT4AYGNEKzcCiA5GLPgsp2p3ZY4dOea6G0w 3SyZAUog==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pdj8K-00HLWg-I5; Sun, 19 Mar 2023 02:50:56 +0000 Date: Sun, 19 Mar 2023 02:50:56 +0000 From: Matthew Wilcox To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Baoquan He , Uladzislau Rezki , David Hildenbrand , Liu Shixin , Jiri Olsa Subject: Re: [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter() Message-ID: References: <119871ea9507eac7be5d91db38acdb03981e049e.1679183626.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <119871ea9507eac7be5d91db38acdb03981e049e.1679183626.git.lstoakes@gmail.com> X-Stat-Signature: xj4owhfyjacek4dn98wdyn6kjmbfs5pz X-Rspam-User: X-Rspamd-Queue-Id: 806E0C000C X-Rspamd-Server: rspam06 X-HE-Tag: 1679194264-141962 X-HE-Meta: U2FsdGVkX1/W3NPWsv0o5Pn5z6aaujXYemrDDPiwhqFx7cu7GLvO7xElRMeZ7LsEpMAFx6DkVK3GEbwZf5JH4DusgoSMQkdulwyHdePJpHa23lZu4Xi4JRJIreo+UxHT7d+mTt7/acbEn6URojEgWFlADXoHCmRB1n0hjyexC5CMkpDnwDoXvi7tBs9lOvKKnOaX0zKbV7flBQmcNzy2e5UEb1M+Y2LxBZU/Wp3Q+v00+zLZwGjomkJ5Ud+HjxJ2mc/APOE7kFvJKikYiCQwsmzEzgeoigcZxZragz4jmAFcdBzl8vt126US4P0HSRFoL/ddbEC3OG8YIjs3jv4G4AakGywzijJRgpfwuyhGqPksKIPqnAVUKZkn9EBiCS1ZDk+rKP3pQ04pxoPPNPfwKEjI9gnPdXanHoDLT4PHnonrfb78qmILVR49lz38COCzUapmQs+l2MuM05d4vTJSjCMqb37Xyn3/f20DyOqOh9ZtOhRbLI9uBSEuVfaIOAJJIt+skH9l4e7GzA0UzPhQZsQvceyO5iYnJdL5wd+UE+WO/x3LutuDCYa4aEquZR5OsXNesHWph6TxlwhjqHk44SdWQCoWMsJ5bu6VOEn/DSE+Knisi+H3Gb+D+KeeIf4QQ78Ehy/8URsAGwQGT2w/U8XEMKoPHzB43b0Iih4qFTa4sPigfSh3GQq5PMrby8Unv2OT3wBxkXh/sfZLKqllIaB11OCHxLfwsd2A+RuSe0trUHPFfM9xKQqUVBeNFtk9IkX+FAshy83NoNu4oBhw3RXNohhrDjDKHCiQuSyG11uROenA+szJZDIh5pq3lnNSXjFOsx0Z4juKqKkHDIzyjfX1t+yXwxPdl+o4ufSTQ8bz6wvXhkvYp36WgeF89mkfEG9yM0A9HltLq4r/NzHKspOGD7LirV+1nLY/tGWlZv6OfsYh/oTgOKFYL0vf7irbdRXHvVEcHEkfSzxMs0z xAmAVU45 q0gTDTND1kOx8iDlFs2tsYObbZAahZtWqNqtaBvYLXOgJWzqy9n5asxxy/oxNx5tErPUy9Fuj47CK+GU4bRT/cqe5J7tQKcDuyihsixbatuWrka9o+/tuBhCpga8IHoECKto34p819DEbu15pxlIGX7BTK6l/MMKBaXzflVjD1GfypeUwdibo+C0t3Fk8TfUhtoLQr8dXJfwY+Vg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 19, 2023 at 12:20:12AM +0000, Lorenzo Stoakes wrote: > /* for /proc/kcore */ > -extern long vread(char *buf, char *addr, unsigned long count); > +extern long vread_iter(char *addr, size_t count, struct iov_iter *iter); I don't love the order of the arguments here. Usually we follow memcpy() and have (dst, src, len). This sometimes gets a bit more complex when either src or dst need two arguments, but that's not the case here.