From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F04C61DA4 for ; Sat, 18 Mar 2023 15:17:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DCD7900003; Sat, 18 Mar 2023 11:17:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58C5A900002; Sat, 18 Mar 2023 11:17:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45431900003; Sat, 18 Mar 2023 11:17:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 356A0900002 for ; Sat, 18 Mar 2023 11:17:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D549E12129C for ; Sat, 18 Mar 2023 15:17:06 +0000 (UTC) X-FDA: 80582372052.22.96DF016 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 9178014000C for ; Sat, 18 Mar 2023 15:17:03 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d6ccJIc0; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679152624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RQqhoBxESfjz0MrhZuxEnWRoFia7U0MNzcHrY8Fhlv0=; b=cZkfOLVo4v9gKcHN9x/huk1ZDXhWIyvp0nC8Lch9gIoZ5YP3ivcdwerZ98hHNImeRXlZX1 jIQhu9csFn5aK20O7JQJAukSKzRfrKv06SHdeq+zdWPc4uTjqHrFW6ML4XFWYYciQFGa7m dq3V5PvkL+kO/VCIknrMxUrNwC/khEE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d6ccJIc0; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679152624; a=rsa-sha256; cv=none; b=Ou7BDcI7EPtrkxdVtmH/oBWCe/FWw27hEU8RDex8C9/JDA8NO/uqgZQhlKLTX8sqyLcl0G 7jBuEROvjlAmrcdIRb+cixvogUbGqLbLYFAOGslIIWL1cv6XtXF7Hp6xU4q05d840uDe6Q 3kQ/f2olQ7B1u3LgR0E80mhqu+g4AfA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RQqhoBxESfjz0MrhZuxEnWRoFia7U0MNzcHrY8Fhlv0=; b=d6ccJIc0boouKz1RgK4pvpGHi8 4ZkGSh7ToGcaKfREyF2r2iGLEPicussMx8K0l2Li2ra249nXJO7hUZf38itouaruulqS1aOFTKTqN jJMx2gb8RC+xEru4EMEUbXlbziGm+fW8Fml8xSUcNodEmfqS15SK8uCirMJIR9JVRKxZaBwPAD74R K9n/THstFMW9NglqvNtSQmYgeP646r9HesxPdRri63hl3iM8CtBAdvbnwf953h05nlX4Ap9z9DTvP 3+UTf5Zp5V2ZQKQBjwv/jwj26batJCHJXAy8GoUDqoSLOsLOteidAWyQR8ImH4PUgpewvrOdjbLIg 85rR280A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pdYIX-00Gudm-D6; Sat, 18 Mar 2023 15:16:45 +0000 Date: Sat, 18 Mar 2023 15:16:45 +0000 From: Matthew Wilcox To: Jiri Olsa Cc: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann , Namhyung Kim , Dave Chinner Subject: Re: [PATCHv3 bpf-next 0/9] mm/bpf/perf: Store build id in file object Message-ID: References: <20230316170149.4106586-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9178014000C X-Stat-Signature: wnko54im3jfin5ei5ej55zju3fitwwkp X-HE-Tag: 1679152623-614777 X-HE-Meta: U2FsdGVkX19wjRZzANP1Si3p1g3qof9pJdFnwmRC8RsXO+TmVB94tVyUY0OU4k4EvtR7Ug72kPmWu3nJAOiPvWRjyAa4mDXhkLkXsfRm1IXTp3lxrUgXGt34BVBOQu/YMsYx2pogGuNxU0g3ZmpWIWG4hO0qnLrcwEOeidd6QRCiTAGXJ3SvnwFuenMxCkbVCyDURmjxY0qx3iYhjm0RAUIXWie3HVC6hdUqUzGWHqnBwkXN9HbScucTibuyCjCoXXYahGiG+OVD888w2A8MD+m7NOsm4fc5cVbTX8UXX2Kzi3R649Ldhxbta6iJxvkXauKWjCAjUA5GaPBLNUF6chrV79huUpPUrD9eAD2LtLH1MtZJF81U3Pp+zNTdmmHvhZLwbuOxoh8TMRMf6TQjrZHr7WIQJxTNkfQYmFC7wgp4ShfNPgA6Ni1TqmSPPIEOTxcpzXilJQc/7jHE1ytF0n8WWpF66t09WVUgiIq7lFFFj+h+3nSG8yZjouYhR62wkxO/CoYBUMKzA2DpfoMwj9Rc/UmJKJYX+Zt09kjdyrEjwxT9OoJWTvoSJyVlGzGXRVUEq1aEXMkhRR4nOMajXV1sSKMjSzTfHfUia+mqqgG+6PJif2bQxAGvu+KxeIUWw9dm91YvOzmbylqkkvPVCInP7LteOAnlEh75gXj/35Qhxx7CS3wzxTfW882FjQ1qptqYk6Kc9kg7WTOT2V8BmVRag3V7qc2d1JlJ8T+g5g8qcql3qc6hHto5HG7tQWLmLlvmVme/2uw4TcCPDAf6YeEsnIF6i0NbK7BhHC8AzsftbnJ1s5+DLM3mpXuZyrLRxnZOK64QdRYoLjCYyHf25uplc/Uf4jpzI9vOMEwexVJ/c+WOwKtzYFcoDtGe7+rLhtyMk8OoD5U1h7PiZeFUIl2jAq8wwGYfqTrWfQUECt9e97oxZq8nhS4Doclocg9BqaH1/BIb+Zf58/fF/PD YKbHcroy O2JAS2p896zcXR8evh6UBKaxDiL/d7THJQHzz9yleOm2+Ht4bh1dPqtoBNdRE4MSX/a9QQ9iuOYOIAhlhuaL44XqqjKY+StHBM1CpzEibIRrUsWin2Ha0UoIqjWyexbDW46x0FCDtnsB298tFCugxTHMcCSZY64/Expzq7axOtu3ZexPP0N1vRKkjjJUCrtSzDv09EmHYpslD78rFu7Ln/FeUm8QjqlJoufsN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 18, 2023 at 09:33:49AM +0100, Jiri Olsa wrote: > On Thu, Mar 16, 2023 at 05:34:41PM +0000, Matthew Wilcox wrote: > > On Thu, Mar 16, 2023 at 06:01:40PM +0100, Jiri Olsa wrote: > > > hi, > > > this patchset adds build id object pointer to struct file object. > > > > > > We have several use cases for build id to be used in BPF programs > > > [2][3]. > > > > Yes, you have use cases, but you never answered the question I asked: > > > > Is this going to be enabled by every distro kernel, or is it for special > > use-cases where only people doing a very specialised thing who are > > willing to build their own kernels will use it? > > I hope so, but I guess only time tell.. given the response by Ian and Andrii > there are 3 big users already So the whole "There's a config option to turn it off" shtick is just a fig-leaf. I won't ever see it turned off. You're imposing the cost of this on EVERYONE who runs a distro kernel. And almost nobody will see any benefits from it. Thanks for admitting that.