From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04EA5C61DA4 for ; Sat, 18 Mar 2023 17:40:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D0C7900003; Sat, 18 Mar 2023 13:40:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A7B2900002; Sat, 18 Mar 2023 13:40:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 596B0900003; Sat, 18 Mar 2023 13:40:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4B587900002 for ; Sat, 18 Mar 2023 13:40:54 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2308A120759 for ; Sat, 18 Mar 2023 17:40:54 +0000 (UTC) X-FDA: 80582734428.28.FCE69AA Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf25.hostedemail.com (Postfix) with ESMTP id 3D8C2A000E for ; Sat, 18 Mar 2023 17:40:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Yl7l77+G; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=olsajiri@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679161252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ev2W7AwgvE+3tr7BAXXjW37/uLiVAl5wqa5Vqup/X18=; b=GRmTfKZ0/U50K5mgHlbyojvuw057iwfFat/V4Uqz48CYy/AfhztFUum8GEirWLX8wd7Zb0 u57ESJZHHqoIXjSXTvRip8p3Lt1wmzWFJaoxbqLuqGzhdLxmZmQD9+t/ZdW+5Z/uKlXMvM Mwjw1JdPKzWqSLcDk6ACQN9fPC+UFSc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Yl7l77+G; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=olsajiri@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679161252; a=rsa-sha256; cv=none; b=mdtOnl+B/KsiM65lmpADl/13DTI/RyS8rkgEtbvR8G/vFPCU6kI4W9xIucjZ9IcprK/cnl KIuKBkMg1fodCjN+YOaX1Vb5U3KiU+YGJ1s3PvciKd835QqStLatsmZ4fCY6H2blWqyUaI rQT4vKwXLa8pYpxOaYff1Ir4OiYNwEs= Received: by mail-wm1-f44.google.com with SMTP id t17-20020a05600c451100b003edc906aeeaso168631wmo.1 for ; Sat, 18 Mar 2023 10:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679161249; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Ev2W7AwgvE+3tr7BAXXjW37/uLiVAl5wqa5Vqup/X18=; b=Yl7l77+G+vWuZBrzmXQxIW4PhdcbuiWftbjibBta14w9f+IW+cP4rAqaUOEf54VsBP XXcfsI0nfYwJA26CqS7T9F2Or0MsGLRdgDyme5Bhatkxfkcj3tht1cJWu9TO+QDzTDNj /+QwOVyIXX+kAOQ60wi/wjA2WoOlZiSPw/7SrmfgWl4W1SF52ThmMuN26J9efm9dsWZT wsgOC23KF0f0mJ0gi83B9lDDLlXm8j+xgWzfOmoVixSjCIi/R2VS0ynCo0MaWodEYm7Y HFFiy/qM9A7HDTs3Iizi2lRpDpkyc5F5Qu0y6qpkXshh+P2hNhr3cHN9B8b7g4ihnEOF 8tew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679161249; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ev2W7AwgvE+3tr7BAXXjW37/uLiVAl5wqa5Vqup/X18=; b=Z0ZYysh883q3QzKTkQMNYX+9nTGE5eYYCQfJHuzwEZ/ElivGGNq1bcjSNd3BB+dMwd WlKyqprIaMBb0dvqkmVOX8G+dhFtOVPc+1OGrLvP7khIVv2iPzpaN+pYPBriNFMGY0r3 pX2ny23XaYH+7Ng66c9CiiSeGa3cMHavuYDKpIXDMXq+2th2adQAgR6FIP3gw0IGtC9Z 9QFrK+qnK0E+RrFD6cEl128MAxV1j8hlc/YPlAC2xgSmXVUCmQjZORIXC4G3+aMq48tY qNGhOvISNMh2zNz5twq8CCzewpPReNZ71AO9PV2lbEkPPoc5uVCscETCiqKhXi1J0YfV Jxbg== X-Gm-Message-State: AO0yUKWk1bTvbbbpw525Ge4hkB1+aUqI2xatelcQZ70ygZwA51Cfq43Y oYXRja6qWtobZX7M4VknEZ0= X-Google-Smtp-Source: AK7set9zXPa/ih+Bbwm7sQZOKAnG69++6aoehqPt/kHsTPtM2UGAPjvGCSsnG1ECr9Gokzh9oSseng== X-Received: by 2002:a05:600c:358e:b0:3ed:2a41:8525 with SMTP id p14-20020a05600c358e00b003ed2a418525mr17932303wmq.22.1679161249516; Sat, 18 Mar 2023 10:40:49 -0700 (PDT) Received: from krava (net-93-147-243-166.cust.vodafonedsl.it. [93.147.243.166]) by smtp.gmail.com with ESMTPSA id b15-20020adfe30f000000b002c706c754fesm4797373wrj.32.2023.03.18.10.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 10:40:49 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Sat, 18 Mar 2023 18:40:45 +0100 To: Matthew Wilcox Cc: Jiri Olsa , Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann , Namhyung Kim , Dave Chinner Subject: Re: [PATCHv3 bpf-next 0/9] mm/bpf/perf: Store build id in file object Message-ID: References: <20230316170149.4106586-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3D8C2A000E X-Stat-Signature: o5q3a7x4ks6yt61fni3p6yzpegpimt9n X-HE-Tag: 1679161251-528534 X-HE-Meta: U2FsdGVkX19vEgnBjVOMNcRRsA5lFfpj+cwzAZv7WqlZjRmS8L4L39viUlcNZenW/mLVfkXe1oHY4GeOlpFm69BihQVfYUxSiuVsa7qz7LeQsAG817Cxisi2LGJN5nMG6mWvwZiq/LOqbJh1yWk03dfKtLSRVAoaNq+tZ79XNrECnXMCmIpGIDCFU8tk1JCWNDsH8Yg+ZDmEwptMNtlQb/eIaMy75ZWSGpn2GxDd2Djr9G9HMgU8DtVeouHJNE71Fqhpfs4yz495m2Kt0eyvSB3cjBDiWhHundV3ctHCauPfHkNQN5TBhcFTL196wniYWch1K/TGIP9dcw7gCLz/Kl50KLnLvhL3rXetgLub1KceltIw2obl/BAwr4OhYKPIuibO/LzTv9rdSpdd0QtjbxmOyTnVVUDlQFyjczKdpxXw1+sVs2Uf5EtW4Ut1SmiW+QCtg4Ddp0HqsNLpZe7OfuIP+iajCQotGKv2tISbbTQpYcRpgsF263XC33ZH2e1GgTzdLl8eLVoUA3rnr4jm4qQF7VEJatsEJRyhwYbZfmqpMOjRehCAahD/Mz5Gj3jBVWt+ADV156uAaKygxnk/+PD6FbWw8gErQ/bRXbFK5hsOMISFxWv7zZPtI4leAdfu+rEVRP9Uz0EE3zZBuV26Ml6Hb8ZZKkaXAZtFxdIbOcpX7XceBL3iR7noYLmPajHAfAxnw0XCcmhz4MLk+DIrcXxojawyJIUvLnNS5BnZf3DJh7k33U117s31ToCDPiQaAbBj78d2/rahxbhyRwXFvbosaPJEQVJtTkoELxH7IWDxrhGSJj+P6qW5dKQMNXBuk4upQ1MLjH7NPZIegb7P7GY0P+MSXdVCjFzx7waXxJqW9LWWhQfhsnG3edJZfxUqhDFFo+gfH7QAFgrYQ8ivVS2gpZ5rpK0xwxJgoHEh60wZGiwAVd/OowO9sl3Offbk0/j0Kvqetr30/hHfRy1 P6hrzyxe v/YRll/wB0lFS88btseZsp8bp3iiVLz7odMzJ5MLqeDnPaiyuzsn+YakucGLh5kL2k/A5/KHm0oRiRZKhFDp+sNZoIGIuLfAn7bhkaUEatqKpy1lkMExEABnsrQZqQNMB7Kj6mpbI5HxIgY2cAFq2iTsJAJ9cm0fuzKE0pBZPAOb2tbL90FtFR04e2LOelivqtx18kF1LD3sVXF3gWQirvWFcwDpzk7DUEN6ClXDjdcQl+IeTa1IXlx+zbyDivR5m398fzX3f/x27lZmJY7zta+QAnVZRtizdv8sVWlnSp2/KzvU4vu6Rxk6MEaWhe4EBlVBYXR6XqNN5qig3k4m1yt5FbsPMPVFngyly21SANO1kSstz/mk2HY1kKhQMqtWsqyNMQhEYSnZ9MVNgqrF5cirsoziTtbCpI/gaLuZvntSR0W9X/M2HuWW7SyFt/3fUgXAFMghJ2CayC2BQZJl2BmxFYHQkXd7blM7U+r28u7EwPUWJVNzk2yY4DiKprplXpG6AGtWsWssOkA0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 18, 2023 at 03:16:45PM +0000, Matthew Wilcox wrote: > On Sat, Mar 18, 2023 at 09:33:49AM +0100, Jiri Olsa wrote: > > On Thu, Mar 16, 2023 at 05:34:41PM +0000, Matthew Wilcox wrote: > > > On Thu, Mar 16, 2023 at 06:01:40PM +0100, Jiri Olsa wrote: > > > > hi, > > > > this patchset adds build id object pointer to struct file object. > > > > > > > > We have several use cases for build id to be used in BPF programs > > > > [2][3]. > > > > > > Yes, you have use cases, but you never answered the question I asked: > > > > > > Is this going to be enabled by every distro kernel, or is it for special > > > use-cases where only people doing a very specialised thing who are > > > willing to build their own kernels will use it? > > > > I hope so, but I guess only time tell.. given the response by Ian and Andrii > > there are 3 big users already > > So the whole "There's a config option to turn it off" shtick is just a > fig-leaf. I won't ever see it turned off. You're imposing the cost of > this on EVERYONE who runs a distro kernel. And almost nobody will see > any benefits from it. Thanks for admitting that. > sure, I understand that's legit way of looking at this I can imagine distros would have that enabled for debugging version of the kernel (like in fedora), and if that proves to be useful the standard kernel might take it, but yes, there's price (for discussion as pointed by Andrii) and it'd be for the distro maintainers to decide jirka