From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390ECC74A5B for ; Sat, 18 Mar 2023 08:03:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DC3F900003; Sat, 18 Mar 2023 04:03:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08CC9900002; Sat, 18 Mar 2023 04:03:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9731900003; Sat, 18 Mar 2023 04:03:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D9B9C900002 for ; Sat, 18 Mar 2023 04:03:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 96A0A1C5FBF for ; Sat, 18 Mar 2023 08:03:46 +0000 (UTC) X-FDA: 80581280052.20.FAE03B4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf28.hostedemail.com (Postfix) with ESMTP id C813BC0004 for ; Sat, 18 Mar 2023 08:03:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=MmHb31MI; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679126625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jXvcZJ9gcO/Gy66DNQ9ErC3M6Vf4j6rmw8rucTPwz/k=; b=wg0yYCwz1xJH2BCX92OKziE8wg1pQYUV3n01HRrWwVgT/3MdmdwlI7dE6UOr3Ik2YdVN1R Mx85wgcivhVsJkKXq5tmNvHdOrX9n8G8zLpTLJrlW6k/aSIrwOwpNNZhm0nFxiD2JlymkR EOl1/SdKJUbSG9wHc1EF0ZJ7ZgTeI0U= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=MmHb31MI; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679126625; a=rsa-sha256; cv=none; b=lEQCGr5LpnW1iOHR301XOD1UO3pM4mTWP7e3su1q/LuKe/NQlI6ExgsNSSYPvlYcCmi9mX oVR5y7flTCAilv3n2/BaoAV+yMNnogOGDtfEtozfyooyegeRcxginrK+bAiZSPbw75VMUL B75sd9GFUCsZmDmW/S/BVOipVBarAs8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 41FFD1FE51; Sat, 18 Mar 2023 08:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1679126623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jXvcZJ9gcO/Gy66DNQ9ErC3M6Vf4j6rmw8rucTPwz/k=; b=MmHb31MIdModKA5DHpShfuWrNKRWubjzSBPL4LnqH7XqLYdp9x4OScRGSl8yyr82uvLaUg i+qrF3WTifnW00av4PpDPAJCbygGp4sU1PhKv3YzSy7GYfAzxX8SbDxgYeNxlydn7hgvfH /sQpPcx/cnOp0WeBT7g3/OFckqcyy9Y= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A94F13A00; Sat, 18 Mar 2023 08:03:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id g3xTBV9wFWRqOQAAMHmgww (envelope-from ); Sat, 18 Mar 2023 08:03:43 +0000 Date: Sat, 18 Mar 2023 09:03:42 +0100 From: Michal Hocko To: Andrew Morton Cc: kernel test robot , Leonardo Bras , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Frederic Weisbecker , Peter Zijlstra , Thomas Gleixner , Marcelo Tosatti , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , LKML Subject: Re: [PATCH 2/2] memcg: do not drain charge pcp caches on remote isolated cpus Message-ID: References: <20230317134448.11082-3-mhocko@kernel.org> <202303180617.7E3aIlHf-lkp@intel.com> <20230317163229.51431ba28ba82c70eaa55d81@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230317163229.51431ba28ba82c70eaa55d81@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C813BC0004 X-Stat-Signature: yzbwh9i3ed81xjep44yie9gogmjm7qkb X-HE-Tag: 1679126624-930706 X-HE-Meta: U2FsdGVkX19bWyXXGQiymqESdQQ+4KCCmC45B2NoZXpdD2bgySvlCpgRuh9Xfc95snmrJXPvOQFrOlDaZ1kjN6eSwSChpoInS9SKIFF9SpMGbaNkpZs0TKm6jc9WT0SmEg8p/WNPdpaJNOqKBV7GAdEX2BH7Q/jJ+BEmI/XUctXP//JeK/6pqe5Xgwo/d42R6Ff0IIZilJnPRWni2lgSG/Nzmqtap+UqylAolu6ZCDukpe7OagdKcgPnBRaOYiBeqKJAyWkr+uzsEncBkWqz6Zz4i7FVhsc5ni6I0dr0AFeWvaUAcZwR1FFn1prgKnwaUdqlSksOianTeSBhyY5h9iuQuu/14ExZkHccl44g0GFw1ZTSd1mgbCp5luX5PuRlJobK/wVCj3c2Ef4n/8OJCyRTxJUpyH4r1i3Z80f/K60HXzOvccRA88B9+6q3E0bUuugVXca5B4AQD32SuLR/P/Zrh6w7G4lEZM7Vx3N2kkkNXRNQzta30Bj2SVgLr0ztSu51u32RG+Oc2muMdcESDrww7EjuxCCvaM4ulOT//L1psnwzAzO5HUi2x1FEv59E7SncQo+qUE6CatWRwGBtNgXrt2HPzFvVwHnHGus/4fCOgCbjiQT8I3mjPqZK4udkrUIDO3EaOSv8MDONy+YcjLUq2gOnuoJhiEKIbKRJIJU37ZPxsbbzES0os2XfO9OU6Qp9fOd1CVbR8+CZ8OXlVE9GJMgnzfXW37Gja1d6NH2thPRMNMRoILyM2q3W5vkyIMuYmgYLEV/zKQ4Vgkpf2jrnydnOcX9ZfeKDPom1yZZ+OSSOFLI6HPwGCIvkNkoliqPQfcROfc+1w25IfbgVBu8s5+Wl6EieY1K0dU4Z+1pg9d4jQ88dL0R0LC1D5Ceto+fkzGl7aGHM5agewfAtlWIuAK7LalzkzhUuXnaLlpDZx1xp8i4nULKm/RaFvxHBRdBmdIDcaCFoeY3/uoA X6HHsCAS 7FjTUIXbZlYcqBsp/aIii4pkzG0Xcl4plR/h/pF38Lh46CGouFiPpQ9a6TEyvWgR5uunPEEGBr8gnarAzUUIDu+ZrfrzGL387OeCymHZ7XtPchbbW+x/hT7bqHiYQYoK4JZ6ACFyJVq9P/mhATfyEvBDcPU8W/CsWrr7L1Dd7P+okzP1km/1CaazmS1qvh7Bq+T1Ell6JPhFS7QhyG/IALIZ/qyfP8aZjVStC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 17-03-23 16:32:29, Andrew Morton wrote: > On Sat, 18 Mar 2023 06:22:40 +0800 kernel test robot wrote: > > > mm/memcontrol.c: In function 'drain_all_stock': > > >> mm/memcontrol.c:2369:35: error: implicit declaration of function 'cpu_is_isolated' [-Werror=implicit-function-declaration] > > 2369 | else if (!cpu_is_isolated(cpu)) > > | ^~~~~~~~~~~~~~~ > > Thanks. > > --- a/mm/memcontrol.c~memcg-do-not-drain-charge-pcp-caches-on-remote-isolated-cpus-fix > +++ a/mm/memcontrol.c > @@ -63,6 +63,7 @@ > #include > #include > #include > +#include > #include "internal.h" > #include > #include Thanks a lot Andrew! > _ -- Michal Hocko SUSE Labs