From: Michal Hocko <mhocko@suse.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel test robot <lkp@intel.com>,
Leonardo Bras <leobras@redhat.com>,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Frederic Weisbecker <fweisbecker@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marcelo Tosatti <mtosatti@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] memcg: do not drain charge pcp caches on remote isolated cpus
Date: Sat, 18 Mar 2023 09:03:42 +0100 [thread overview]
Message-ID: <ZBVwXgaaF2r/v8At@dhcp22.suse.cz> (raw)
In-Reply-To: <20230317163229.51431ba28ba82c70eaa55d81@linux-foundation.org>
On Fri 17-03-23 16:32:29, Andrew Morton wrote:
> On Sat, 18 Mar 2023 06:22:40 +0800 kernel test robot <lkp@intel.com> wrote:
>
> > mm/memcontrol.c: In function 'drain_all_stock':
> > >> mm/memcontrol.c:2369:35: error: implicit declaration of function 'cpu_is_isolated' [-Werror=implicit-function-declaration]
> > 2369 | else if (!cpu_is_isolated(cpu))
> > | ^~~~~~~~~~~~~~~
>
> Thanks.
>
> --- a/mm/memcontrol.c~memcg-do-not-drain-charge-pcp-caches-on-remote-isolated-cpus-fix
> +++ a/mm/memcontrol.c
> @@ -63,6 +63,7 @@
> #include <linux/resume_user_mode.h>
> #include <linux/psi.h>
> #include <linux/seq_buf.h>
> +#include <linux/sched/isolation.h>
> #include "internal.h"
> #include <net/sock.h>
> #include <net/ip.h>
Thanks a lot Andrew!
> _
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-03-18 8:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 13:44 [PATCH 0/2] memcg, cpuisol: do not interfere pcp cache charges draining with cpuisol workloads Michal Hocko
2023-03-17 13:44 ` [PATCH 1/2] sched/isolation: Add cpu_is_isolated() API Michal Hocko
2023-03-17 18:33 ` Marcelo Tosatti
2023-03-17 18:35 ` Marcelo Tosatti
2023-03-18 8:04 ` Michal Hocko
2023-03-24 22:35 ` Frederic Weisbecker
2023-03-27 10:24 ` Marcelo Tosatti
2023-03-28 11:38 ` Frederic Weisbecker
2023-03-28 11:48 ` Michal Hocko
2023-03-29 14:20 ` Marcelo Tosatti
2023-03-30 13:28 ` Michal Hocko
2023-03-30 15:21 ` Marcelo Tosatti
2023-03-17 13:44 ` [PATCH 2/2] memcg: do not drain charge pcp caches on remote isolated cpus Michal Hocko
2023-03-17 20:08 ` Shakeel Butt
2023-03-17 21:51 ` kernel test robot
2023-03-17 22:22 ` kernel test robot
2023-03-17 23:32 ` Andrew Morton
2023-03-18 8:03 ` Michal Hocko [this message]
2023-03-18 3:23 ` Hillf Danton
2023-03-18 8:08 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBVwXgaaF2r/v8At@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbecker@suse.de \
--cc=hannes@cmpxchg.org \
--cc=leobras@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mtosatti@redhat.com \
--cc=muchun.song@linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox