From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B21C74A5B for ; Fri, 17 Mar 2023 21:37:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DE986B0075; Fri, 17 Mar 2023 17:37:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08F596B0078; Fri, 17 Mar 2023 17:37:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E983D6B007B; Fri, 17 Mar 2023 17:37:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DB02A6B0075 for ; Fri, 17 Mar 2023 17:37:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A9A3E1A04E3 for ; Fri, 17 Mar 2023 21:37:46 +0000 (UTC) X-FDA: 80579702532.08.061BDA7 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf28.hostedemail.com (Postfix) with ESMTP id CE0D2C0014 for ; Fri, 17 Mar 2023 21:37:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BMtstbKL; spf=pass (imf28.hostedemail.com: domain of htejun@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679089064; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VM4L650jvOHnOrzjxyybDkCmQtbFyLFT1T/BqqmyWcU=; b=kUH4tY3evSrkDzI3kGl4+ndspi3OjNOVNXzdNMk0TdobF0Irl5OWKKhZ7ZX5GsDFHSPsil eWQH5ffw4r4kpvktiuN2Pnu5oHN+uUQYEP/K4hzS1sI+R7E2BqihfyImC56yae9s7X2lOk EK17ScuZMidi05noqgz8oX//CKSa83A= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BMtstbKL; spf=pass (imf28.hostedemail.com: domain of htejun@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679089064; a=rsa-sha256; cv=none; b=L/3lk3WauzbjzYjkSgEpdxmLUe7IRarwhGXJ0ysFHpm8EjXX1yRegu5WTwBK4WNs1N7NAC Qzx/TSArLENijAmqtqWkBnOr+NN0aRCVqNnJaaCz9UBXywe33yqyp8TkJCKsUav+h3jiN5 0tfozEWRW1DI+0GgOL/8yyTeJ5yBRBM= Received: by mail-pj1-f45.google.com with SMTP id p13-20020a17090a284d00b0023d2e945aebso8958862pjf.0 for ; Fri, 17 Mar 2023 14:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679089063; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=VM4L650jvOHnOrzjxyybDkCmQtbFyLFT1T/BqqmyWcU=; b=BMtstbKLHuH8Y2UCzCOd8xm/eCyHo7c5eIYlFb96xgHM115JNQM+OFQ4k59hUkiBnE ftqWS3pKGpJsbiYoNoKCWwmz5P18p9hMSLR6skLG3iXxHg4OcB66U65UhRT0YDJ0d3CS Xs7YKbDPjetM1g4ow3EMHRk5kYw8gNzC5t7Q/4cOtnFzaZnaWjciLtLKPnC2R+8i0L/5 2fmcfzvbGluZoFNhqL9IWuH78tneHzxy1LGIdJR8mWsc3YufBwxahT4Yz2GsXRVCRkhB LeNU1/n9TxwTTM5LUq83iz4V24ouqBqsjeuXJwFOu+OBPySm82YBfjILXj532EBjLu+e xW8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679089063; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VM4L650jvOHnOrzjxyybDkCmQtbFyLFT1T/BqqmyWcU=; b=2CHlseGUAVQm2r/sk9C6W5wXJ5s9GMfS4/arPe8NedwDXLNxQYDHfuRjo0bhn2NcB6 tiQXPld12s+LwqJVwA97YXmAZoCzgSB3WJ7hAUifa5z8+h8hRZkTM2OKVVWAIPb0bO9t A0Sd3j95hbInWwKNwWqxGylmvlWtPtOXU/nGJ5o2Pvgari/50wOQxeTheE3/ulXMb8xt OeMbXbIkGlc3RTWFs2rN7mK0bwxywPjLX3b9D/MH4SlXsBclot7osgrQO/iL1f/1LXCi bU3lb6v8ERS3s+YOktPNR++zDNd8QICa8oFfuQJ7TI4MVFnMW6qh1R1zhguxDYQSxG3S EMOg== X-Gm-Message-State: AO0yUKXoY9Bp5lEJYDGhiKKbjefqR15HjJef/J70HkOYVdbPd53nTBad JS7U0svmtSkfMYD0lTLnl2w= X-Google-Smtp-Source: AK7set9GNEiVxeBdO0CFGjfPfAM2MhAmu+ExOcF0+C7WJ5Hy4TYmspAyMRLBJC8H/4V/UdY+FjkJxQ== X-Received: by 2002:a17:90a:51c5:b0:23d:4a9e:868b with SMTP id u63-20020a17090a51c500b0023d4a9e868bmr9873155pjh.31.1679089063439; Fri, 17 Mar 2023 14:37:43 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id e6-20020a170902b78600b0019edb3ae415sm2000828pls.14.2023.03.17.14.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 14:37:43 -0700 (PDT) Date: Fri, 17 Mar 2023 11:37:41 -1000 From: Tejun Heo To: Haifeng Xu Cc: longman@redhat.com, lizefan.x@bytedance.com, hannes@cmpxchg.org, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuset: Clean up cpuset_node_allowed Message-ID: References: <9953284e-05da-56b0-047d-ecf18aa53892@redhat.com> <20230228083537.102665-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230228083537.102665-1-haifeng.xu@shopee.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CE0D2C0014 X-Rspam-User: X-Stat-Signature: pnzofjogjmcyz5q6i815yh1eycpq5jrr X-HE-Tag: 1679089064-118389 X-HE-Meta: U2FsdGVkX18iOPySgP0eUburVFMLQ034TJMxhIxC6Q8VTV7nCSyKPQvNo7JsaIU0VxWvOD4o379ygWHtdjNrhPDUgpgQtB1tZBuuWGt8KAi26wZ7JJYhiMorN9Uj8gfz6h15gxfCGAfBdxlBYLXX4zV3sgUHPW7tyOQ0Pl+kpihsufffIZ++ZDGuQLUmnkc8SdMAas7UQ3T4oO9ExxMKSYtIvnesS5KiIZLF/2eSIs2VvkxWKM9zJAhF07hriB/6fGoVGDRCPv8MR/dqoXfEdr7omi0Btm50HJyyTDdlLdr/ibr5aEn2MGzhAro68fPZu1cFDb4rDFUGEi4DjyWRRmiZAFDhMXVpIJTWaTqUX7b7zKxXWWyAL+DcZtCidtuFcey4XM2kK1pb6UrZ+2DOLzTi/20U89JxYdpLn8kZyTzj/8WWGWO4BDftqC5AIzfE9uET1LOlw3ENokuGNgdcXdOJJd1n1/dS/hkrVn0hsMltc4ZWkqy3BM9LjEP/b19Z9p+azM1pOarVr1q1A77qqm5ZOKn5/Dn34V2Jj9G3vPt+qeLacrxjN6w+unIz8O66KqqiAaxOrAoIpA1ZTQDNV/ZgfeKinnZ8uhEA2p0teDtkelBNtjYixJtCMJCcQABYToBU/qNHWrNf1T7BerruZCv/CGuR93GnPVIFv7+PRYpUapEOx5sVuAPwC7evDeNqvGzxC8jjG1AaGCSpl3Qs5wmnWQvFLRPhTBS9nRykIYCqnHVak3q2CuG8vpKbSyTcJTBRy0PBXnews6n/IJcuLzsHeWFfyMViC6SSpUHNfsaLd8ACNiT7Y8TvhaQKTZFSoArfTKZlanQZxsTU8VcIAoQN4jxn63ZTuCz9nkTqS9AFmuFIvrUwnYw8RvoFUw3bDMNhZwHB4FndUyMvsa42geW8PQFjIR18sLZ0yL7ousj8xIe5xMfhKn9dmG23PHH1Y5UpW2g2xmU9PPslTN6 jdiVsoUZ K7BPPx5FplAf31+gCsB0O0trZiEo/N26skpj1smnjyaWYiOrgANkAg/2xDbbVZC7UCdSP/M0DBNqPhuPJ9sBHct9ZPx9SyVEqpuZmcL8KQUqsQenWre67VWhpiI5OsTZweT1i+U8SMzAg1Is47C7BxHrxVeIiXn9dGh9pfMGybSuWxOJyR5HpAFHETtjaZtnlXjv+hMuGJo9TllJw+rLf2fyPOhYriTGjX/iZvJGHDL6L9QbpR28xlgTPpsZiAkxbmgFPLtuwGy0tMWV3fgS/NbcsjWeEVjLnIJBVRXQflQyM08TZF4AkXcbsKAt7TCdn9Yj+0zcwovCpiN5HBI9PsYOiO142R4JV1UAU/d4F/S/NTmoXXRFrwPdWaaT5vErdvjqNQX8jhODu29cxSmRVufFysod5U3REoFtRruUp7aahzUtky4Ru/82VZL7QE0q7YOh7OqZQbz3aYxJ73G+5XQc1HjvMkTxMxQwoz0uOH9ZAQZx92FrLw2qEDQ8LHh9wOfuADnCxYdUEul1ZshlkGXtz1+fwcep6dlCoZM8mFUxAWEBFDAW3JwuIkQ0DOFx+TcEdY2lva/pXb6lPyWun/s+AL3UjToB8Z3dFDIv83h518DWIg92UvdSXIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 28, 2023 at 08:35:37AM +0000, Haifeng Xu wrote: > Commit 002f290627c2 ("cpuset: use static key better and convert to new API") > has used __cpuset_node_allowed() instead of cpuset_node_allowed() to check > whether we can allocate on a memory node. Now this function isn't used by > anyone, so we can do the follow things to clean up it. > > 1. remove unused codes > 2. rename __cpuset_node_allowed() to cpuset_node_allowed() > 3. update comments in mm/page_alloc.c > > Suggested-by: Waiman Long > Signed-off-by: Haifeng Xu Waiman, can you review and ack? Thanks. -- tejun