From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 860C5C74A5B for ; Fri, 17 Mar 2023 11:51:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21F826B0075; Fri, 17 Mar 2023 07:51:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CFC26B0078; Fri, 17 Mar 2023 07:51:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 097FC6B007B; Fri, 17 Mar 2023 07:51:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EFAEE6B0075 for ; Fri, 17 Mar 2023 07:51:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C43041C727B for ; Fri, 17 Mar 2023 11:51:24 +0000 (UTC) X-FDA: 80578224888.30.A5CEC49 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 18D6B40004 for ; Fri, 17 Mar 2023 11:51:22 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fzGhBj2c; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679053883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zwCDSXLI+49xXM9+Qar8VzATIGwnwYxr9Nze5FidqHY=; b=1bAhA6UI9TnRdlOJR/kvOLu66urfYKsc6IRRA8CnwPKz3BREfujagcph0BrgX/Xby+olfc M/QIgrlhrKF5GgHPawmjwCNziI2EqlNhqkeEj6lBNoacEshBXiaRociNFEpToerv1/rGe1 vSwf2LgoOayReFViiMh8vTn17F5czlI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fzGhBj2c; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679053883; a=rsa-sha256; cv=none; b=WLWin2QfSi5LIdUN2juWSPO33LMC/fuidLyD12966cTvZifULA+K+/bAxATek/By9YO2ah 4A4MAratumvJgWAMB2SgAvsjDueLu62KlSN9ud4tJ2YzUHXCAOTHNxHMQNVQAtiz1r7/dr 51gyM/QzZA9Ilx0TjyBeXMupp9E9Wrg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37C8A62276; Fri, 17 Mar 2023 11:51:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 876CEC433D2; Fri, 17 Mar 2023 11:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679053881; bh=EzVToRfdITg9u3nsfi0iMokgGQHKFv6SIwK3/2KDthY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fzGhBj2cq6QRZXZnXXd7tw4Jqpm1h1G9P95NySR0oBzoAAqgJqJIKcW/rRF8MkgTD y+DSCwzELoUQVjuXiK62u8/NgLSlIDrYcBpihffs7I4uuioETREJ5UMGIRZBKC76Io e4NK9S71zQ5GxlaiIdIiBxtmW0+NPIUiSu70/UPb7CezMpofuSuaa9cx1RGXWrZcMT KglfRemiunf7s7inHoCd+iwZMbiF3ctfchfI+f86/y5NBahFpVBSMdno46ejpGfUrq f/RZIZUfSX4BLNBskbBkkHLVSVhMtBmBTV8ewt4zY17Iuy/NYBIieughKRtyiZMA1+ C3mdsewfKhWrQ== Date: Fri, 17 Mar 2023 13:51:05 +0200 From: Mike Rapoport To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, linux-doc@vger.kernel.org, Lorenzo Stoakes Subject: Re: [PATCH v2 3/6] mm, pagemap: remove SLOB and SLQB from comments and documentation Message-ID: References: <20230317104307.29328-1-vbabka@suse.cz> <20230317104307.29328-4-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230317104307.29328-4-vbabka@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 18D6B40004 X-Stat-Signature: wqecnput6kczop3s91dj3ipd7r4ch1s4 X-HE-Tag: 1679053882-312762 X-HE-Meta: U2FsdGVkX19dEhB6kJqknTNxjWPlvCqYrbjRCIRt1jsetJhlfZRcc5WQS1k71qOOzJ2S82O8KccKJ62SCctCAAmlfuJ3SeTXxIy587sRcfjVMiuVRko0CfIv/rTEqFD+zvYd10AV7Wki4vpqiCKuauJuVxHi3CM6kX8ZlDAOhkMcQxe+p9RaWYaVqt+85S7GJ0BDnsY7uVwYzqMzrzMTvqEqmK+uhjOMKnzRO4RAS0Kz9evQJM6JRJTSkfmvAfa48qsK1RjzBNZh1F1vciILZgjopLZWkyJB22Bx0QxUUUw+MPRnNPdKRdaaOKowy4vR+iSZ2p06xLevkGt41BXOmti48gv2fJgNxw+O8lawcZ0sTG4Vjf711ZBn9oDRmUqwl7cWwVwKH+BaK0lCTlcYBRMkMlrk5dp09IFa2Ky9Sl0QZMcyFI5aP0s4L8WhdOJ/J3ItYWq2AMLYnceSNEU3c5DELhwkv2HAGWzNk+VoYcNma2JKRPUotfmfjZJ/0jMVndXH/pm6WV+tG6cZU44aoXP/ye74FgM3lqvPqxJuyUNYgvOuhxg69XE4j8LkG9h1eVt8fSh/cB8x1ojP3LbqgqDIc/k9cBHIccnF2uKpn0JUYTwkJaaFSjZ43fU1uAH47Z87ZAwBB3JieXbgxxKjCscOW89p6YpRrYCrblQiIa8hlED/NOHwMc1zM83rJRUEG9aMjBDDAxfM3wI0DZFuVLceoxXxJGNIkWHqS3taKCYECkJBboF9gH4CiHwkrfbTBDZvUWxUDa5LXfEoX4q4J19twjgA4qTv+6aUcvRpld1dMesXJQV9rNMnkqz+2rWX5TdzmBJp3gyapxdBiRlCOSxKZjI/oDH5jtzKxxOkmPilT7OaTSBC4iKrcZHx81zBi6JdLAEcnh1t34jv1yGw4hrKw9WsG4gfCPw1GVfmsXzUbejNpAsZV3v1tVRZAN0QcP+saG69hPABomSBvwf MJazs3LJ hsBhgGTSTZOOPbtqdd6v9d+mhSgwvRXQkSjL9pzQxAixmtxwuNfCUFJ84/I5zwS5XCq9LsrYKn6AIi3PulR6QulmHNggCTB/PVBQZEzd6hUN7aVgTDDukMuHfuVVZw7/PzT77NcvJgyd69CJ+1dOg3uxQaCPVMzL3gm4X78zY/S/0kCTpORtkanFGzaF5oK2sa/ngOiAgyy2H4jCjtqvJ/Y+273gM7tmXP/QAjBK+KaMpHdZDOlpZJS+C7TtfjevO9NpHFywYF+cYAU7lqI+OdbquMN8VB84QI+yyC53p+4PBVZkdqb85EZX4QNbSTiCqpEjNEbQRwPQGNbeeSRh92nk1Ik1W13YD9PRRdqnfvec6O+v+PLY+NPfcVRKnrKBo+vrhU+Xyo8pf26wqssAn2pnCKv4dh2U4EhBhK42UFhp2HA3/Se6J7pQAwl479n8W88ppcjIH6J4TZDY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 17, 2023 at 11:43:04AM +0100, Vlastimil Babka wrote: > SLOB has been removed and SLQB never merged, so remove their mentions > from comments and documentation of pagemap. > > In stable_page_flags() also correct an outdated comment mentioning that > PageBuddy() means a page->_refcount of -1, and remove compound_head() > from the PageSlab() call, as that's already implicitly there thanks to > PF_NO_TAIL. > > Signed-off-by: Vlastimil Babka > Acked-by: Lorenzo Stoakes Acked-by: Mike Rapoport (IBM) > --- > Documentation/admin-guide/mm/pagemap.rst | 6 +++--- > fs/proc/page.c | 9 ++++----- > 2 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/Documentation/admin-guide/mm/pagemap.rst b/Documentation/admin-guide/mm/pagemap.rst > index b5f970dc91e7..c8f380271cad 100644 > --- a/Documentation/admin-guide/mm/pagemap.rst > +++ b/Documentation/admin-guide/mm/pagemap.rst > @@ -91,9 +91,9 @@ Short descriptions to the page flags > The page is being locked for exclusive access, e.g. by undergoing read/write > IO. > 7 - SLAB > - The page is managed by the SLAB/SLOB/SLUB/SLQB kernel memory allocator. > - When compound page is used, SLUB/SLQB will only set this flag on the head > - page; SLOB will not flag it at all. > + The page is managed by the SLAB/SLUB kernel memory allocator. > + When compound page is used, either will only set this flag on the head > + page. > 10 - BUDDY > A free memory block managed by the buddy system allocator. > The buddy system organizes free memory in blocks of various orders. > diff --git a/fs/proc/page.c b/fs/proc/page.c > index 6249c347809a..195b077c0fac 100644 > --- a/fs/proc/page.c > +++ b/fs/proc/page.c > @@ -125,7 +125,7 @@ u64 stable_page_flags(struct page *page) > /* > * pseudo flags for the well known (anonymous) memory mapped pages > * > - * Note that page->_mapcount is overloaded in SLOB/SLUB/SLQB, so the > + * Note that page->_mapcount is overloaded in SLAB, so the > * simple test in page_mapped() is not enough. > */ > if (!PageSlab(page) && page_mapped(page)) > @@ -165,9 +165,8 @@ u64 stable_page_flags(struct page *page) > > > /* > - * Caveats on high order pages: page->_refcount will only be set > - * -1 on the head page; SLUB/SLQB do the same for PG_slab; > - * SLOB won't set PG_slab at all on compound pages. > + * Caveats on high order pages: PG_buddy and PG_slab will only be set > + * on the head page. > */ > if (PageBuddy(page)) > u |= 1 << KPF_BUDDY; > @@ -185,7 +184,7 @@ u64 stable_page_flags(struct page *page) > u |= kpf_copy_bit(k, KPF_LOCKED, PG_locked); > > u |= kpf_copy_bit(k, KPF_SLAB, PG_slab); > - if (PageTail(page) && PageSlab(compound_head(page))) > + if (PageTail(page) && PageSlab(page)) > u |= 1 << KPF_SLAB; > > u |= kpf_copy_bit(k, KPF_ERROR, PG_error); > -- > 2.39.2 > -- Sincerely yours, Mike.