From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E25EC74A5B for ; Fri, 17 Mar 2023 11:50:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E4CB6B0074; Fri, 17 Mar 2023 07:50:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 293D76B0075; Fri, 17 Mar 2023 07:50:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15CCD6B0078; Fri, 17 Mar 2023 07:50:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 02EA36B0074 for ; Fri, 17 Mar 2023 07:50:12 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B93911A182A for ; Fri, 17 Mar 2023 11:50:11 +0000 (UTC) X-FDA: 80578221822.15.93F8EAC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id D201A40024 for ; Fri, 17 Mar 2023 11:50:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G3tBAQGW; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679053809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PYpTxUWZV2PJ80J7wtmAYAmp3ZgVy+s5lbQ+KjOnBYo=; b=y/CM6rbfMNiUP2hvXoS+NEM39KGjUOrxrM9Ogxn3vp2YcOs1OpM8KvwrnyX025P6yLV8wO /Q1ZxTkiC7d+HUkuDZR/6KIPUWEl5ooNsEZ0VLRyzrKL2F6Lc8dco/GjrLPnAD1bA7yhPv s2UFnF9wAwtC/cUjX9kSac7ax/3hAr4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G3tBAQGW; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679053809; a=rsa-sha256; cv=none; b=Sg5w9siPQBmxuXgva2JxUdZHJhA6M8jvMMqBfE/AnJX8SuYj1PUbN8boUGtiEYAXa189Yd sD7qTC5NtgyM1mPNf8dgYzTZq+5GCQUxiqR1AXmbczDm9krVH2X9yNw5c/8b1HcyXm/pwN QMn3In6EvkysWQ5AVwm6crJU6Ho+tQM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E492462299; Fri, 17 Mar 2023 11:50:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8165DC433D2; Fri, 17 Mar 2023 11:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679053807; bh=T8NNfXFxQwO5AYO7a1OktwX6XNNJlHxRWVwZujDSwwM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G3tBAQGWyF+d/xztZGv8w2CJOXhMijhJ4Da4wdAf/DGrDr25vdbpQor3X0mjKeUoA EJAx3W+NLy0rFxU0oLEJVZyZPdpjcfKTe90OZL7MA1MB5qwW+YpJi6NzhnwdvqHows OlJuLWMlWh0AYgxV038lxwTtg3BZ4IVAO/Qe41OVIlyHwVa+F1UtjZ7pwC9Pxck2P9 ubkv23es+XVnoLL2NfqNwJ0TnWlU5ZCvQGfLM/gFp8kxDQgXtVgVzaCJFrgVGOFPzM EyVrtvSRLfz6oSyETvktfPDkVXIOxQBg25BXOJBaX3Bxk2xem/ZYHjO+Mclq9iVrAI ACIk3ZQqFNVpw== Date: Fri, 17 Mar 2023 13:49:53 +0200 From: Mike Rapoport To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, linux-doc@vger.kernel.org, Lorenzo Stoakes Subject: Re: [PATCH v2 1/6] mm/slob: remove CONFIG_SLOB Message-ID: References: <20230317104307.29328-1-vbabka@suse.cz> <20230317104307.29328-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230317104307.29328-2-vbabka@suse.cz> X-Rspamd-Queue-Id: D201A40024 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: y8xhq7idnfen7dxzeiqbgddweiwirh7x X-HE-Tag: 1679053809-325890 X-HE-Meta: U2FsdGVkX19VxroJTvZwVBk3q2bxCQksEYLe4q/2gPQu9fe3lK7m5reL67AzPgtpxY7Sq7HOva8EBvsrQYr3whE+CR1K58n5+vq95RKtdqz68q3uYNnkg7An/128k1zH2AAWiPXq6DASJq7LlwvpxDc6liHnzLj/q9MHqQ2HWaE9YsCaLaF0zNh4p7Ay4JY/tTGF0h9zmtv82KriBNuRCDAPMJM5UYWGd/C/UopJyqHZcJ5PPChyjM2ttz+Ev+GZrETFU9pOQcE1Z/2coZJV5VsUsu1QMq6GQ2brMwqDAuKWTcTAGx7YVvhFAO3I/j0FAy7tIdD5WDUkr6vFgrbFDSctQgASXp4y+5hejS7X9fvT8UAkpL/ZDRbxPl3BloDNKQaiLTgpN6FtAuuDpeMm33Ry3P3GHa3jZ7ij8klC9aROP1FkoNlAUkpoJd4AJBwo2gS306Tk34wPnDgYvFK4Q8A/nxjKNs5CR8YHZfXx4zokdp2CplJvbrj1uX847MTGIxpmcH4FwqzX3ovrgrCFfCrxTNwy2ip8VK7giiNI/Xg6l8jzMGLpocA06KyV59qLrQiolxIBjmdcIT8banaiXPFrgUab4VFSjpQiTf3x9lu6CYaLnr9m8FIrnUZStSL5fWr+Su/8gAAuZ1aCEWDxxEXEe76utILfU9cRNkKJFuQ16t0po/1l7Wfvb44tUxGs8qK5NgY1G+BOOWzK/JK9eP2pFS89C8sPW5KeH7pvVpC78kwLM9lRk5vsjRn3128+UWQvD8efmg8N/NqHaR6Fc0XJ3qFCAWBetwShkxuwX3kAv3K/ulh4MEB8awfS0YF5DfJzpNQ2s5FOapzWigvKaVRDtT3YxtxLXf/x38MMDuLMIAglLsyWdjsgMD9BUCh37L5JcRfFGKWQ7/D3LVchBpanc5IRB0yjNovB4FkVcTh49gnezp+dQ7INAL2Y/fQc+nvBB+0BX7ETgcc2t3l koIKopIZ K/JaGmdGPCKoW50sJfBgwYKmwzRScrYBw3kCEyhEz/7VmUm6GtAdVwLiGMP1c71LWil9mNjmQpow2Wq9VMR+ZCl33GryHLxITAeeGyeM1PLJQwXKEf6U88ZvlzJT7FDoBzhxR9lX5EbArLUK5OqfvKna9E1ODCBzv4kbg6FeWcgLi8D2r0VWa1ZuhRJWbMNRtBuJT6bqvkNftdnLp4Ggec+U1N2MMs8/Mk/gTElFD60gOAzGta01RZvcNeMQOmKyCZIVsfQeKt8lywF2bSHit4kR2jsq/FAuavficska5Ugxz5a37kH/yVptP5YLu2BlwdnBWFGI1/yXRudLNgGYNRGtO/xXMGi5ii/zbzBjODS4+erN/ZVzjhPbThwtZd/k1U9UDItm6JDnDPL5PRLr7e5k6oE1jOjqh4R9NdFFFEoF9UYDldlduMWZOHifu88+EdneBfThp/Elzq5U4ejSDaydZoKtc6dolrg6rDqXH/XbeeA2QZO2rtg4fmyFVEFlb/SQ3nUxrd+7CtqVDkEfWdMU900JU1ksVMmgCf2d2GxuOgFK3z/Kw95fBo4ozaYbzfc6X2vtuyufIAN9T+Ovjuvupng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 17, 2023 at 11:43:02AM +0100, Vlastimil Babka wrote: > Remove SLOB from Kconfig and Makefile. Everything under #ifdef > CONFIG_SLOB, and mm/slob.c is now dead code. > > Signed-off-by: Vlastimil Babka > Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Acked-by: Lorenzo Stoakes Acked-by: Mike Rapoport (IBM) > --- > init/Kconfig | 2 +- > kernel/configs/tiny.config | 1 - > mm/Kconfig | 22 ---------------------- > mm/Makefile | 2 -- > 4 files changed, 1 insertion(+), 26 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 1fb5f313d18f..72ac3f66bc27 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -973,7 +973,7 @@ config MEMCG > > config MEMCG_KMEM > bool > - depends on MEMCG && !SLOB > + depends on MEMCG > default y > > config BLK_CGROUP > diff --git a/kernel/configs/tiny.config b/kernel/configs/tiny.config > index c2f9c912df1c..144b2bd86b14 100644 > --- a/kernel/configs/tiny.config > +++ b/kernel/configs/tiny.config > @@ -7,6 +7,5 @@ CONFIG_KERNEL_XZ=y > # CONFIG_KERNEL_LZO is not set > # CONFIG_KERNEL_LZ4 is not set > # CONFIG_SLAB is not set > -# CONFIG_SLOB_DEPRECATED is not set > CONFIG_SLUB=y > CONFIG_SLUB_TINY=y > diff --git a/mm/Kconfig b/mm/Kconfig > index 4751031f3f05..669399ab693c 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -238,30 +238,8 @@ config SLUB > and has enhanced diagnostics. SLUB is the default choice for > a slab allocator. > > -config SLOB_DEPRECATED > - depends on EXPERT > - bool "SLOB (Simple Allocator - DEPRECATED)" > - depends on !PREEMPT_RT > - help > - Deprecated and scheduled for removal in a few cycles. SLUB > - recommended as replacement. CONFIG_SLUB_TINY can be considered > - on systems with 16MB or less RAM. > - > - If you need SLOB to stay, please contact linux-mm@kvack.org and > - people listed in the SLAB ALLOCATOR section of MAINTAINERS file, > - with your use case. > - > - SLOB replaces the stock allocator with a drastically simpler > - allocator. SLOB is generally more space efficient but > - does not perform as well on large systems. > - > endchoice > > -config SLOB > - bool > - default y > - depends on SLOB_DEPRECATED > - > config SLUB_TINY > bool "Configure SLUB for minimal memory footprint" > depends on SLUB && EXPERT > diff --git a/mm/Makefile b/mm/Makefile > index 8e105e5b3e29..e347958fc6b2 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -22,7 +22,6 @@ KCSAN_INSTRUMENT_BARRIERS := y > # flaky coverage that is not a function of syscall inputs. E.g. slab is out of > # free pages, or a task is migrated between nodes. > KCOV_INSTRUMENT_slab_common.o := n > -KCOV_INSTRUMENT_slob.o := n > KCOV_INSTRUMENT_slab.o := n > KCOV_INSTRUMENT_slub.o := n > KCOV_INSTRUMENT_page_alloc.o := n > @@ -81,7 +80,6 @@ obj-$(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP) += hugetlb_vmemmap.o > obj-$(CONFIG_NUMA) += mempolicy.o > obj-$(CONFIG_SPARSEMEM) += sparse.o > obj-$(CONFIG_SPARSEMEM_VMEMMAP) += sparse-vmemmap.o > -obj-$(CONFIG_SLOB) += slob.o > obj-$(CONFIG_MMU_NOTIFIER) += mmu_notifier.o > obj-$(CONFIG_KSM) += ksm.o > obj-$(CONFIG_PAGE_POISONING) += page_poison.o > -- > 2.39.2 > -- Sincerely yours, Mike.